| 00:21.37 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:21.37 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 06:03.19 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 06:39.05 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:39.05 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:41.42 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:2dbb:a18c:b6e6:fede) |
| 06:42.30 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 07:07.55 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:07.55 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:19.34 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:19.35 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 10:43.44 | *** join/#asterisk-dev gudea[m] (gudeamatri@gateway/shell/matrix.org/x-yaijhbvgbrxlxtti) |
| 11:48.31 | *** join/#asterisk-dev dan_j (sid21651@gateway/web/irccloud.com/x-zqpujsiuxwfqhhpf) |
| 12:45.51 | *** join/#asterisk-dev CELYA_ (~Thunderbi@92.184.97.6) |
| 13:12.38 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-mvhpsjlxtrhmuboy) |
| 13:12.38 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:12.24 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-ssopujyemwersqok) |
| 14:12.24 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:13.57 | *** join/#asterisk-dev darkunderlord (sid242683@gateway/web/irccloud.com/x-lsjfekhvrlpvkrzr) |
| 14:14.46 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:69ac:a7eb:3e71:8b41) |
| 14:34.24 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-zwvbbgptwovhoooz) |
| 14:34.24 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:44.31 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:44.31 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:54.09 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-mdkjsbykunmgdhxt) |
| 14:54.10 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:58.08 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-dczixmdzousbfafs) |
| 14:58.08 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:13.44 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 15:13.44 | *** mode/#asterisk-dev [+o jsmith] by ChanServ |
| 15:14.03 | jsmith | Any general feeling about how the 3.21.0/5.4.0 RCs are doing? |
| 15:19.27 | coreyfarrell | anyone with available system resources: I'd appreciate if someone can test the full testsuite using https://gerrit.asterisk.org/8854 (against Asterisk master). I did some spot checks but don't have the hardware for a full run (even before this patch the testsuite has some failures on my laptop). |
| 15:20.46 | coreyfarrell | jsmith: others probably know better than I but https://gerrit.asterisk.org/8855 is against 15.4 which I assume means that a 15.4.0-rc2 will happen. I don't see anything against 13.21. |
| 15:21.40 | cresl1n | jsmith: always good :-P |
| 15:21.45 | gtjoseph | coreyfarrell: I can test 8854 |
| 15:23.02 | gtjoseph | coreyfarrell: i also have a fedora28 docker image without python2 i can test with |
| 15:23.44 | coreyfarrell | gtjoseph: the ./self_test script runs lib/python/asterisk unit tests with python2 and python3 but the testsuite itself will not work with python3 yet. |
| 15:23.58 | gtjoseph | yeah, lust letting you know |
| 15:24.05 | gtjoseph | s/lust/just/ |
| 15:26.03 | coreyfarrell | cool.. just saying no point to try actually running any tests with python3 yet. `./runtests.py -l` should work with py3 but that's probably it. still lots of text encoding issues plus starpy is not compatible with py3 yet. |
| 15:26.16 | gtjoseph | kk |
| 15:32.52 | kharwell | gtjoseph: actually can you take a look at the failure for https://gerrit.asterisk.org/#/c/8855/ |
| 15:33.00 | gtjoseph | wilco |
| 15:33.16 | kharwell | something might need rebooting: https://jenkins2.asterisk.org/job/gate-ast-15-pjsip/512/console |
| 15:34.16 | gtjoseph | coreyfarrell: we caught an ari-stubs issue ^^ |
| 15:34.35 | gtjoseph | :) |
| 15:36.30 | coreyfarrell | gtjoseph: what is config_summary.log ? jenkins failed because that file exists after the build (I've never seen it before). |
| 15:36.44 | gtjoseph | i know, i generate it during the build :) |
| 15:36.50 | gtjoseph | i just forgot that i did |
| 15:37.40 | coreyfarrell | so do you want to add it to .gitignore ? |
| 15:37.52 | gtjoseph | no i'll fix it |
| 15:43.34 | gtjoseph | kharwell: should be ok to regate/recheck now |
| 15:43.55 | kharwell | alright thanks |
| 16:01.34 | cresl1n | kharwell, gtjoseph: is it too soon to start regating reviews? |
| 16:01.48 | gtjoseph | no should be ok now |
| 16:02.22 | rmudgett | ok. I'll start regating the REMB reviews. |
| 16:02.24 | kharwell | There is at least one testsuite test I know of that will fail every time due to the port patch stuff. |
| 16:03.00 | cresl1n | port patch? |
| 16:03.01 | kharwell | it's the 'channels/pjsip/dialplan_functions/pjsip_channel/' test. I know what the problem is. Trying to figure out an easy solution |
| 16:03.02 | rmudgett | Is that why the REMB patch failed to merge or is the intenet problem to blame. |
| 16:03.25 | kharwell | REMB was originally failing due to the ari-stubs stuff |
| 16:03.47 | kharwell | cresl1n: https://gerrit.asterisk.org/#/c/8689/ |
| 16:03.57 | cresl1n | Ahhhhhh |
| 16:03.59 | cresl1n | that patch |
| 16:04.39 | kharwell | the failing test has a hard coded check for port 6000 even though in the sipp file it uses 'media_port' |
| 16:21.07 | gtjoseph | coreyfarrell: kharwell: is there some reason we have to spit out... |
| 16:21.08 | gtjoseph | Running ['/usr/bin/python', '-m', 'asterisk.test_runner', 'tests/channels/pjsip/ami/pjsip_notify/to_uri'] ... |
| 16:21.08 | gtjoseph | Test ['/usr/bin/python', '-m', 'asterisk.test_runner', 'tests/channels/pjsip/ami/pjsip_notify/to_uri'] passed |
| 16:21.34 | gtjoseph | do we really need /usr/bin/python -m asterisk.test_runner in the output? |
| 16:24.46 | coreyfarrell | I think it would be fine (better) if we just said the name of the test being run instead of the command being used to run it. |
| 16:26.33 | gtjoseph | yeah. every time it changes pretty_print gets messed up. |
| 16:29.18 | rmudgett | Looks like an agent is out of disk space |
| 16:29.22 | coreyfarrell | gtjoseph: so just those two should be changed..? leave "FAILED TO EXECUTE %s, it must exist and be executable" as is? |
| 16:29.27 | gtjoseph | yeah i'm fixing it |
| 16:29.50 | gtjoseph | coreyfarrell: you lost me |
| 16:30.02 | gtjoseph | oh you mean those two messages? |
| 16:30.11 | gtjoseph | yeah |
| 16:30.23 | coreyfarrell | gtjoseph: yeah.. runtests.py also has print("FAILED TO EXECUTE %s, it must exist and be executable" % cmd) - I think this should print the full command instead of the test name. |
| 16:30.40 | gtjoseph | yeah, pp doesn't look for that one |
| 16:31.08 | coreyfarrell | also please amend my commit for this change, I don't know if it would conflict but I suspect.. |
| 16:31.50 | gtjoseph | wwe can change it later |
| 16:31.59 | gtjoseph | i'll just do an update to pretrty_print for now |
| 16:32.31 | coreyfarrell | wouldn't the pp update depend on the runtests.py output change? |
| 16:34.02 | gtjoseph | no. i changed it to only look for "tests/" and "(passed|failed|timed out)" and ignore anything else. |
| 16:38.46 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 16:53.00 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LFbn-1-11898-144.w90-93.abo.wanadoo.fr) |
| 17:56.43 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il) |
| 17:56.43 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:03.49 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 18:03.49 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 18:06.56 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-jprmgmarvznufgje) |
| 18:06.56 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 18:07.35 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-jprmgmarvznufgje) |
| 18:53.41 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.170) |
| 19:04.33 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-ufwdyifkwbcjpcry) |
| 19:04.33 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 19:20.44 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 19:22.57 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 19:22.57 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 20:31.04 | kharwell | cresl1n: which #defines in plc.h were you referring to? |
| 20:35.27 | cresl1n | PLC_PITCH_MIN |
| 20:35.31 | cresl1n | PLC_PITCH_MAX |
| 20:35.52 | cresl1n | CORRELATION_SPAN |
| 20:36.06 | cresl1n | #defines built on top of those |
| 20:36.35 | cresl1n | in plc.c ATTENUATION_INCREMENT |
| 20:37.01 | cresl1n | handling it outside of 8KHz is a trap, IMHO |
| 20:37.36 | cresl1n | kharwell ^ |
| 20:39.15 | kharwell | okay ya I was wondering if those were the ones you were referring too. I wasn't sure if those values might should be changed if dealing with something other than 8K |
| 20:39.52 | file | just add a comment about it in the new code |
| 20:40.26 | kharwell | so a couple of options. I can leave the code as is, or attempt to change the make_compatible_helper code to only be for 8Khz (although it's worked like it is since forever I believe) |
| 20:41.02 | kharwell | okay comment it is then |
| 20:42.52 | gtjoseph | kharwell: cresl1n rmudgett network down again? |
| 20:43.53 | cresl1n | kharwell: you can try, but I think that's a separate effort to make sure it all works again afterwards |
| 20:44.06 | cresl1n | definitely exceeds the originally intended scope of that task |
| 20:44.27 | cresl1n | I'd say it's probably better not to try in the context of the problem you're trying to solve |
| 20:45.43 | cresl1n | kharwell: I'm guessing that the generic plc code isn't used that often? |
| 20:45.48 | kharwell | cresl1n: I agree. I'm going to leave well enough alone for now. If we need to modify it later we can |
| 20:46.40 | kharwell | cresl1n: yes that is my guess as well. Actually from what I could tell the fill in code was never being called at least in 12+ (after media changes) not sure about before |
| 20:47.51 | coreyfarrell | cresl1n: when you get a chance can you hit https://gerrit.asterisk.org/8831 (self_test for 15) |
| 20:49.01 | coreyfarrell | thanks! |
| 20:49.09 | cresl1n | np |
| 21:43.45 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 21:43.46 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 22:08.42 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 22:08.42 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 23:20.14 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-ufwdyifkwbcjpcry) |