| 00:18.58 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:18.58 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 06:36.59 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:36.59 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 08:27.17 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:25.33 | *** join/#asterisk-dev Worldexe (~Worldexe@nl.free.zoogvpn.com) |
| 09:26.09 | *** join/#asterisk-dev Worldexe_ (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 09:46.33 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.169) |
| 13:14.08 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-67-173.dialup.adsl.anteldata.net.uy) |
| 13:34.29 | *** join/#asterisk-dev jkroon (~jkroon@196.33.18.28) |
| 13:40.05 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 14:07.58 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:07.58 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:10.23 | coreyfarrell | I always forget that "\t" is a 2 byte string that can't be used as a char :( |
| 14:12.57 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-kffrzwyewqsvhnno) |
| 14:12.57 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:29.17 | coreyfarrell | anyone have an opinion about adding '*.orig' to .gitignore? This would prevent accidental commit of files created when applying a patch from one branch to another. |
| 14:29.43 | gtjoseph | ok with me |
| 14:31.26 | kharwell | yup what about .rej as well? |
| 14:35.04 | coreyfarrell | we could, but once patch fails then I'd know I have to fix stuff before committing / pushing for review. in that case I use 'git status' to list the .rej files which I delete as I address each issue. |
| 14:36.34 | tzafrir_laptop | while you're at it: please add .pc/ , or even just /.pc/ (on the top-level directory) |
| 14:36.46 | tzafrir_laptop | Used by quilt in Debian packaging. |
| 14:37.39 | coreyfarrell | tzafrir_laptop: looks like /.pc is already in the .gitignore, is the trailing slash required? |
| 14:37.58 | coreyfarrell | in the top level .gitignore that is. |
| 14:39.44 | coreyfarrell | tzafrir_laptop: I just tested: mkdir .pc;touch .pc/test;git status - nothing listed so I think we're good on that already. |
| 14:42.08 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-ixcoqkfxsovzrmzc) |
| 14:42.08 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:42.47 | coreyfarrell | kharwell: any thoughts on my comment about .rej? what if jenkins got a check that gives Verify-1 if any .rej exists? if that file gets committed then it may indicate something is missing from the actual code changes? |
| 14:46.10 | kharwell | coreyfarrell: yeah that's fine to leave it out. That's a good point you bring up about seeing what failed. I'd be fine with adding a check in jenkins as well |
| 15:40.48 | gtjoseph | coreyfarrell: have you ever seen an instance of *.rej files checked into the repo? |
| 15:42.05 | coreyfarrell | gtjoseph: nope. kharwell brought it up when I asked about adding *.orig to the .gitignore so I figured why not check for it. I actually pushed an *.orig to gerrit today. :/ |
| 15:42.26 | gtjoseph | yeah i saw. how abou tjust adding .rej to .gitignore instead? |
| 15:43.38 | gtjoseph | and thanks for doing the gcc 8 stuff! |
| 15:44.39 | coreyfarrell | did you see my earlier discussion with kharwell about .rej in .gitignore? I think if the file is left behind it means that a patch was incompletely applied so it indicates a commit error. |
| 15:45.29 | coreyfarrell | no prob on the gcc 8 stuff. just upgraded to fedora 28 so I need it for me :) |
| 15:45.31 | gtjoseph | true but i'd hope someone would notice on the review that someone tried to check in a .rej file. :) |
| 15:46.18 | gtjoseph | and if a patch was applied incompletely the compile would most likely fail. |
| 15:46.50 | coreyfarrell | if you want me to abandon the jenkins check for .rej I'm fine with that. I don't think we should .gitignore the .rej because that could suppress a legit error. |
| 15:47.11 | coreyfarrell | I just figured catch the error earlier, abort the rest of testing if it exists. |
| 15:47.44 | gtjoseph | understood. i'm ok with it where it is. |
| 15:48.59 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.169) |
| 15:56.01 | coreyfarrell | FYI I just found an issue with my sipp patch which would misbehave if a specific media_port were selected and media_port + 2 were unavailable. just pushed an update to github. |
| 16:43.19 | *** join/#asterisk-dev zopsi (~zopsi@dir.ac) |
| 18:08.58 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-67-173.dialup.adsl.anteldata.net.uy) |
| 18:52.26 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 18:53.13 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 21:40.26 | *** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:161c:800:5c2f:f0e:d710:5c9f) |
| 21:45.44 | cresl1n | If anybody feels like +2'ing the res_hep review, I'd appreciate it :-) |
| 21:54.39 | coreyfarrell | I can't +2 but at least now the cherry-picks have +1 :) |
| 21:55.05 | cresl1n | thanks coreyfarrell |
| 23:01.16 | *** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:161c:800:5c2f:f0e:d710:5c9f) |
| 23:12.01 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-kffrzwyewqsvhnno) |