| 01:27.26 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 01:27.27 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 03:51.28 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 03:51.28 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 06:05.20 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:05.20 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:16.04 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-ubnprsdeehkyzgjo) |
| 07:42.42 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.126) |
| 07:43.22 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 13:24.08 | *** join/#asterisk-dev libardi (~libardi@177.194.124.58) |
| 14:00.23 | cresl1n | Does anybody know if alembic's alter_column is data destructive? |
| 14:00.34 | seanbright | i assume it depends on the underlying db |
| 14:00.55 | cresl1n | also, good morning seanbright |
| 14:01.02 | seanbright | good morning, cresl1n |
| 14:01.14 | gtjoseph | it's not desctrustive |
| 14:01.19 | cresl1n | eggcellent |
| 14:01.37 | cresl1n | goes out and finds his +1 stamp |
| 14:01.45 | seanbright | what if you have a varchar and you alter to a decimal(9,2) |
| 14:01.54 | cresl1n | I'm guessing that would kill it? |
| 14:02.05 | seanbright | kill it as in abort? |
| 14:02.11 | gtjoseph | it'll fail if there's data in that column |
| 14:02.13 | cresl1n | I think you know what I mean. |
| 14:02.25 | seanbright | k |
| 14:02.42 | file | alters reality to be upside down |
| 14:03.05 | cresl1n | sends file to the "upside-down" |
| 14:03.34 | cresl1n | Anybody else gonna touch the dundi review? |
| 14:03.41 | cresl1n | Or should I just change my +1 to a +2? |
| 14:03.52 | seanbright | isn't going to do anything with it |
| 14:03.53 | gtjoseph | feel free. :) |
| 14:04.03 | cresl1n | likes to watch the world burn |
| 14:04.41 | file | cresl1n: it'd be more like a small continent burning |
| 14:04.44 | cresl1n | Although I think I just violated due process |
| 14:04.46 | cresl1n | snap. |
| 14:05.00 | cresl1n | I probably should have bumped the original reporter for a a +1 |
| 14:05.04 | cresl1n | oh well... |
| 14:05.10 | cresl1n | It's happening now. |
| 14:05.12 | file | life goes on |
| 14:06.37 | cresl1n | runs an alter_column() on file |
| 14:07.50 | gtjoseph | yo'd have to import file to a db first |
| 14:08.05 | file | I only exist in the cloud |
| 14:08.25 | cresl1n | file > mongodb |
| 14:20.40 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-mtrcauatwduzyzzg) |
| 14:20.40 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:28.37 | cresl1n | waves to kharwell |
| 14:28.51 | kharwell | Aloha |
| 14:30.37 | file | hola |
| 14:43.03 | kharwell | anyone have any problem with any/all alembic changes going into 16.0? Seems weird in this case to have to potentially upgrade then downgrade your database schema. |
| 14:43.12 | kharwell | also prob some weirdness with alembic branching |
| 14:43.48 | file | is fine with it |
| 14:48.11 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-zgydutuxtebbldad) |
| 14:48.11 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:51.01 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-thbwuzcvtrrrwpyn) |
| 14:51.01 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:52.08 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-250-191.dhcp.nwtn.ct.charter.com) |
| 15:52.08 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 16:43.16 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-tjgatgcpexqnaerv) |
| 17:07.07 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 17:07.08 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 17:09.47 | rmudgett | coreyfarrell: I don't see why the --disalbe-binary-modules option is necessary. They are not enabled in menuselect by default. |
| 17:10.02 | file | Ditto |
| 17:11.57 | coreyfarrell | rmudgett: the option could just go in tests/CI/buildAsterisk.sh, I was thinking that if a new module is added the menuselect XML would be copy/pasted and nobody would have to touch the CI script. I can remove the option from ./configure / menuselect if prefered. |
| 17:14.07 | coreyfarrell | the main point of it is for the CI script which does enable entire categories, then it disables most of the binary modules if running master. that said the current CI script fails to disable res_digium_phone on master which is why I assumed it would be better to flag the menuselect options. |
| 17:21.36 | rmudgett | Could you put something to that effect in the commit message then. It isn't obvious why anyone would need that option. |
| 17:22.03 | coreyfarrell | sure it'll update the commit msg in a few then cherry-pick. |
| 18:04.52 | rmudgett | seanbright: It seems to me a better way to solve the IPv6 host:port issue is to make ast_sockaddr_split_hostport() recognize a plain IPv6 address without a port. Namely if it gets a string without []'s any IPv6 address cannot have a port. Then if it sees that the string has more than one ':' it then it must be an IPv6 address only. |
| 18:05.49 | rmudgett | [a:b:c::d]:port a:b:c::d a.b.c.d:port a.b.c.d example.com:port example.com |
| 18:06.22 | seanbright | rmudgett: will take a look |
| 18:06.46 | seanbright | that would be a behavior change to ast_sockaddr_parse() then, no? |
| 18:07.42 | rmudgett | It would also make ast_sockaddr_parse() live up to its doxygen list of accepted formats since it lists a:b:c:..:d as a format |
| 18:07.54 | seanbright | oh right... weird. i'm not sure how i missed that. |
| 18:08.26 | seanbright | i'll take a look |
| 18:08.31 | rmudgett | The patch would get smaller too |
| 18:08.34 | seanbright | yeah |
| 18:08.50 | seanbright | i'm not in love with going from string -> sockaddr -> string either in some of the logging places |
| 18:10.58 | rmudgett | Yeah. It is a roundabout way of getting there but IPv6 formats force that path if you have a plain address and you want a port added to the string. |
| 18:11.45 | seanbright | i suppose that in theory src_addr and src_name should be in sync. so maybe i can just use src_addr in those scenarios |
| 18:11.56 | seanbright | i will futz with it |
| 18:12.03 | *** join/#asterisk-dev tuxd00d (~tuxd00d@unaffiliated/tuxd00d) |
| 18:12.50 | seanbright | or. because we know that src_name is always an IP, a simple strchr might be enough to determine the address family |
| 18:13.00 | seanbright | don't have time to look at it today but will later this week |
| 18:17.17 | file | that's what other stuff in places does |
| 18:17.38 | rmudgett | I was thinking that ast_sockaddr_split_hostport() could be fixed by check '[' first like it does. Then strchr for a ':' for port and then check to see if there is another ':'. If the other is found then the string is only an IPv6 address without a port. Otherwise it is an IPv4 address or possibly a DNS name with port. |
| 18:18.01 | seanbright | yeah, i think that is a good change regardless/ |
| 18:36.06 | seanbright | i wish register_printf_function() was portable |
| 18:36.22 | seanbright | ... to solaris 11 |
| 20:44.43 | seanbright | rmudgett: just a quick reading of ast_sockaddr_split_hostport() makes me think that it is already behaving correctly |
| 20:45.24 | seanbright | the "not bracketed" branch already checks for multiple colons and sets port to NULL in that case |
| 20:45.47 | seanbright | so i'm not sure what my rationale was for creating a separate function. |
| 20:47.31 | rmudgett | Apparently I was misreading that for loop. I thought it quit when it saw the first ':'. Didn't notice about how it was handling *port. |
| 21:19.46 | seanbright | there has to be a way to make this code less sucky |
| 21:20.02 | seanbright | i just wrote this: |
| 21:20.22 | seanbright | is_ipv6 ? "[" : "", the_src_name, is_ipv6 ? "]" : "", |
| 21:20.25 | seanbright | and i hate it |
| 21:23.02 | seanbright | what about wrapping IPv4 address in brackets when we log them? :D |
| 21:45.28 | rmudgett | I think it's just a penalty for using unadorned IPv6 address strings. Should always have []'s when dealing with IPv6 address then the issue doesn't come up. :D |
| 22:08.28 | seanbright | i just wish there were an elegant want of inlining a function call (a la ast_sockaddr_stringify) that didn't need TLS and could magically use the caller's stack |
| 22:08.54 | seanbright | s/want/way/ |
| 22:09.25 | seanbright | but whatever, i'll get over it |
| 22:23.43 | file | seanbright: I dreamed a dream of nicer things... |
| 22:58.51 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 23:10.48 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-mtrcauatwduzyzzg) |