| 03:00.05 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01cb0583d31d001907ecfb943e4f19.ipv6.abo.wanadoo.fr) |
| 07:11.23 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 07:11.23 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 07:56.12 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 14:49.07 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 14:49.07 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 14:56.48 | seanbright | rmudgett: any chance of knocking the timer cleanup patch down to 0010? |
| 14:57.03 | seanbright | while you're in there, anyway |
| 14:57.21 | gtjoseph | i'm going to do that |
| 14:57.24 | gtjoseph | shortly |
| 14:57.39 | gtjoseph | waiting on Teluu to approve an update to the patch. |
| 14:57.42 | seanbright | roger roger |
| 14:58.59 | file | did gtjoseph get renamed to Roger? |
| 14:59.15 | seanbright | 'george george' doesn't have the same ring to it |
| 14:59.23 | file | it's true |
| 15:24.25 | seanbright | rmudgett needs to update git |
| 15:24.33 | seanbright | 2.7.4? casual |
| 15:25.05 | file | oh, I forgot to update the main one |
| 15:26.04 | rmudgett | seanbright: I'll renumber the timer cleanup patch |
| 15:26.31 | seanbright | sweet |
| 15:26.37 | gtjoseph | no need. i've already done it i'm just waiting fro Teluu to approve. |
| 15:26.42 | seanbright | sweeter |
| 15:26.56 | seanbright | george & richard - the dream team |
| 15:27.14 | gtjoseph | s/dream/nightmare/ |
| 15:27.25 | rmudgett | When that patch is put up then we'll get a better diff in gerrit :) |
| 15:27.44 | seanbright | they need to keep their github mirror up to date |
| 15:28.37 | file | gtjoseph / rmudgett: are either of you set up to quickly update our mirror? |
| 15:28.53 | file | ponders |
| 15:29.10 | rmudgett | I thought we no longer needed the mirror |
| 15:29.22 | rmudgett | since we have bundled |
| 15:29.46 | file | maybe that's something we should ask cresl1n to put on his todo list, again |
| 15:29.55 | cresl1n | hater. |
| 15:30.01 | seanbright | AGAIN |
| 15:30.42 | cresl1n | Right now, I think it's something gtjoseph and others have kept manually in sync |
| 15:30.47 | file | yes |
| 15:30.50 | gtjoseph | yep |
| 15:31.02 | cresl1n | gtjoseph thought that it was working well enough when I spoke to him last time about it :-P |
| 15:32.03 | gtjoseph | well, our public mirror stopped at 2.5 |
| 15:32.18 | file | we're pretty much a mirror of their mirror now |
| 15:32.45 | file | also - updated |
| 15:51.17 | gtjoseph | rmudgett: why did you believe an rbtree was more appropriate for the core bridges container? |
| 15:54.18 | jsmith | prefers yellow-purple trees, for the record :-) |
| 15:54.25 | gtjoseph | :) |
| 15:54.29 | seanbright | such a SJW |
| 15:54.46 | seanbright | /s |
| 15:54.58 | rmudgett | I needed a sorted container and so I could use partial matching in complete_bridge_live() |
| 15:56.22 | gtjoseph | so only for the cli? |
| 15:56.35 | file | gtjoseph: yet another case... |
| 15:57.24 | rmudgett | Also to replace duplicated bridges since the uniquieid is the key and a user can set it. |
| 16:18.48 | coreyfarrell | I'd like to get opinions on ast_json_pack object format strings. IMO the current way we write object formats is not very readable, "{s: s, s: o, s: i, s: s}" is a blur of names and values to me, I'd much prefer "{s:s, s:o, s:i, s:s}". having spaces after the ":" makes the spaces after "," visually insignificant. especially when an object has a bunch of keys and you need to find the format character of the 7th |
| 16:18.48 | coreyfarrell | value, the spaces make coding and reviewing more difficult. |
| 16:19.11 | coreyfarrell | I'm not proposing we do any kind of mass change but as a matter of policy could we drop the space after colon in future code? |
| 16:36.33 | gtjoseph | I'm ok with it. |
| 16:36.58 | file | I don't really mind either |
| 16:44.48 | kharwell | sounds good to me too |
| 16:46.00 | seanbright | is that exactly how the json is rendered? with the spaces where you put them? |
| 16:51.11 | rmudgett | yes it is how the json is rendered |
| 16:51.27 | seanbright | then there should be no spaces |
| 16:51.33 | rmudgett | at least I think so |
| 16:51.35 | coreyfarrell | no, the spaces in the format string have no technical significance, they are ignored by json_pack. |
| 16:51.41 | seanbright | ok, cool |
| 16:52.26 | coreyfarrell | json_pack actually ignores all the colons and commas too, they're only used to improve readability of the format string. |
| 16:53.28 | seanbright | it should cache the "plan" |
| 16:54.25 | seanbright | /nick arm-chair-quarterback |
| 16:57.40 | coreyfarrell | json_pack creates an in-memory object which does not contain any formatting. json_dump functions have flags to control indentation / compact output ("," vs ", "). |
| 17:21.47 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 17:21.47 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 17:30.56 | rmudgett | gtjoseph: Was it brought up that cache_remove() returns a ref that is not unrefed in the stasis_cache patch code you are removing? |
| 17:31.25 | rmudgett | https://gerrit.asterisk.org/#/c/asterisk/+/10139/ |
| 17:34.38 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-lqorpnevytqsblyu) |
| 17:39.15 | rmudgett | Did https://gerrit.asterisk.org/#/c/asterisk/+/10179/ get stuck? |
| 17:47.11 | coreyfarrell | rmudgett: I'd prefer to see further stasis_cache changes deferred to a separate patch. what's on gerrit fixes a leak regression in the current branches (I wish I could do a proper review but the app_voicemail changes are well outside what I'm comfortable judging) |
| 17:49.03 | rmudgett | That stasis_cache change is dependent upon the voicemail patch no longer needing subscribes cached. |
| 17:52.53 | *** join/#asterisk-dev ahmed89 (~ahmed@85.154.169.183) |
| 17:53.21 | ahmed89 | hi all |
| 17:54.11 | ahmed89 | where I can find asterisk development map ?? link , reference |
| 17:54.26 | ahmed89 | i want start learn asterisk development |
| 17:55.27 | coreyfarrell | rmudgett: I'm aware, that's why I haven't reviewed either patch. I agree it's weird that cache_remove returns the reference instead of cleaning it but I'd prefer we not let that delay merging the current fixes. |
| 17:57.28 | rmudgett | file: Were you going to rereview the voicemail patch? Or should I +2 them? |
| 17:57.38 | file | you can +2 them if you desire |
| 17:59.42 | rmudgett | Once those go in I'll +2 gtjoseph's stasis_cache patch |
| 18:00.39 | seanbright | god pjsip's code formatting is atrocious |
| 18:00.53 | seanbright | mixed tabs & spaces ftw |
| 18:01.06 | file | ahmed89: if you are referring to C code, there isn't really a guide/link - it depends on what you are wanting to do |
| 18:01.13 | rmudgett | Makes Asterisk code look downright purdy don't it? |
| 18:01.29 | seanbright | indeed it does |
| 18:02.57 | *** part/#asterisk-dev jpsharp (~jsharp@linode.fivecats.org) |
| 18:03.22 | ahmed89 | file: I mean asterisk it self, I have little development experience with freepbx, issabel & asterisk configuration, I want start learn development , any guideline |
| 18:03.27 | ahmed89 | more deep than https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines |
| 18:03.27 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d008cbe1948112af03e.ipv6.abo.wanadoo.fr) |
| 18:04.19 | file | Asterisk is extremely large and vast, like I said it really depends on what exactly... if you want to get your feet wet, you can look at the issue tracker for minor things, pick something, and explore/learn |
| 18:04.28 | coreyfarrell | ahmed89: if you are talking about C code I'd suggest finding a bug you want to fix. it's often easier to get bug fixes merged, the burden is higher for improvements & new features. https://issues.asterisk.org/ |
| 18:04.34 | file | if you are wanting to write something new then that depends on what |
| 18:04.56 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-smaublyqzifnhbxz) |
| 18:04.56 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 18:06.06 | ahmed89 | good , I will look around this , THanks coreyfarrell & file |
| 18:07.44 | coreyfarrell | ahmed89: when you are ready to work on a patch check out https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process and https://wiki.asterisk.org/wiki/display/AST/Code+Review. I'd suggest signing the CLA before you have any patches ready, the approval is not immediate. |
| 21:41.08 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:20cd:b017:556b:57fe) |
| 21:41.09 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 22:54.51 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.171) |
| 23:01.59 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-riheldoithhsmqvu) |
| 23:53.25 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:f0e7:5299:11af:477a) |
| 23:53.25 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |