| 07:11.52 | *** join/#asterisk-dev CELYA_ (~Thunderbi@185.14.178.189) |
| 07:15.45 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 07:31.33 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 09:38.11 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 11:37.47 | seanbright | file: can you abandon this review please? https://gerrit.asterisk.org/c/asterisk/+/13064 |
| 11:38.15 | file | I can, as soon as I find the right tab |
| 11:38.20 | seanbright | it's over there |
| 11:38.22 | seanbright | points |
| 11:38.39 | seanbright | thanks |
| 11:49.32 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 12:40.52 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-mjmachaejoghhwcz) |
| 12:40.52 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 13:02.50 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 13:05.28 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@68-114-57-249.dhcp.davl.vt.charter.com) |
| 13:05.28 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 13:40.01 | bford | seanbright: "README-SERIOUSLY.bestpractices.md: Speling correetions" |
| 13:40.01 | bford | :D |
| 13:53.09 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-rkhzgwvtqrosdfgl) |
| 13:53.09 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:01.19 | seanbright | it's an oldie but a goodie |
| 14:45.00 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-vllfpogrbkoymxdm) |
| 14:45.00 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:56.57 | *** join/#asterisk-dev pc-m (~pcm@cable-66-129-132-216.b2b2c.ca) |
| 17:26.01 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 18:44.25 | *** join/#asterisk-dev spatel (~spatel@pool-98-118-124-216.bstnma.fios.verizon.net) |
| 20:03.03 | seanbright | i'm having a hard time getting asterisk to compile on my toaster |
| 20:03.40 | file | seanbright: oh, did I show you the wiki page I made... |
| 20:04.01 | file | seanbright: https://wiki.asterisk.org/wiki/display/AST/Supported+Platforms |
| 20:05.11 | seanbright | very nice |
| 20:05.21 | kharwell | are ast_variable values guaranteed (or expected) to be non NULL? |
| 20:05.34 | kharwell | I'm guessing so since in ast_variable_new we do a strcpy without a NULL check |
| 20:05.55 | seanbright | i feel like i fixed a bug recently that involved that exact thing |
| 20:06.11 | kharwell | but after that are there potentially cases where ->value gets set to NULL |
| 20:06.14 | kharwell | or could be |
| 20:06.27 | kharwell | seanbright: something crashed due to NULLness? |
| 20:06.29 | file | kharwell: when allocated via the normal mechanism yes |
| 20:06.40 | kharwell | "normal" heh |
| 20:06.41 | seanbright | yes |
| 20:06.52 | seanbright | kharwell: let me look through gerrit |
| 20:07.18 | kharwell | sounds like I need to check for it just in case |
| 20:07.45 | file | if it's allocated I'd expect it to be non-NULL always |
| 20:08.33 | seanbright | kharwell: i'm not seeing it, but i feel like it had something to do with realtime |
| 20:09.17 | seanbright | it's also possible that i am mis-remembering |
| 20:09.23 | kharwell | so potentially with config loading. Which are some (if not most) of the spots I'm dealing with |
| 20:10.00 | seanbright | damn. i'm sorry. |
| 20:10.13 | seanbright | the only way to create an ast_variable is with ast_variable_new? |
| 20:11.28 | kharwell | I'd think that would be normal expected way, but the ast_variable struct is public so possible to create otherwise |
| 20:11.51 | kharwell | which also makes it possible for the value to be set after construction as well |
| 20:12.22 | seanbright | so i think it might have been this review https://gerrit.asterisk.org/c/asterisk/+/12964 |
| 20:12.42 | seanbright | and it's possible that early in my investigation i assumed an ast_variable value ptr was NULL |
| 20:12.48 | seanbright | so ignore everything i've said |
| 20:13.24 | *** join/#asterisk-dev sduthil (~sduthil@107-179-252-17.cpe.teksavvy.com) |
| 20:13.27 | file | kharwell: from a quick look I don't think anything uses it that way... |
| 20:13.52 | seanbright | doesn't it get allocated as one big chunk? |
| 20:13.56 | file | it does |
| 20:14.06 | seanbright | yeah, so setting after the fact would be bad |
| 20:16.37 | kharwell | actually I just realized too I am replacing some of these instances of alloca and copy, or ast_strdupa. In most of these cases so far they don't check for NULL and hasn't crashed yet |
| 20:16.45 | kharwell | so prob okay to continue not to |
| 20:20.24 | seanbright | so fwiw, i can't get AST_STACKSIZE to _not_ be a multiple of 4096... so i have no idea why he's seeing that error |
| 20:33.45 | seanbright | qemu can emulate arm64 on x86? |
| 20:33.51 | seanbright | we're living in the FUTURE |
| 20:50.00 | opticron | I do it daily |
| 20:50.29 | opticron | well...technically aarch32, but it's the qemu-system-aarch64 binary |
| 20:51.01 | seanbright | so fancy |
| 20:52.02 | opticron | it's certainly not a typical system I'm working on |
| 20:55.47 | seanbright | well, from what i have read, pthread_attr_setstacksize will return EINVAL if the size is less than PTHREAD_STACK_MIN or (on some systems) if it is not a multiple of the page size |
| 20:57.03 | seanbright | so given that his page size is 4k, unless his sizeof(void *) is like... 1 or something, i don't see how it could be failing |
| 22:24.38 | *** join/#asterisk-dev spatel (~spatel@pool-98-118-124-216.bstnma.fios.verizon.net) |