| 03:24.41 | *** join/#asterisk-dev sahmed (~sahmed@cpe-70-114-236-63.austin.res.rr.com) |
| 05:23.34 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 05:23.34 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 06:18.31 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.126) |
| 07:12.25 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 09:17.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@126.185-60-37.rdns.acropolistelecom.net) |
| 10:16.32 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 10:16.32 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 11:26.23 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 13:47.29 | *** join/#asterisk-dev sahmed (~sahmed@cpe-70-114-236-63.austin.res.rr.com) |
| 15:01.28 | seanbright | sahmed: you wanted to discuss https://gerrit.asterisk.org/c/asterisk/+/13503 ? |
| 15:01.58 | sahmed | sure, thanks |
| 15:02.48 | sahmed | why you abandoned that patch ? any idea please? |
| 15:03.18 | seanbright | yes, i don't know how to address issues raised in the code review |
| 15:04.32 | sahmed | Sorry to asked that, actually I meant, by using channel lock does not make it safe? |
| 15:04.54 | seanbright | it may, i can make that change and you can test? |
| 15:05.21 | sahmed | yeah I have ready environment, I can do test :) |
| 15:05.25 | seanbright | ok great |
| 15:05.32 | seanbright | will make the change shortly and let you know |
| 15:05.43 | sahmed | please |
| 15:07.57 | seanbright | ok, i updated to put the joint_caps stuff in the channel lock |
| 15:08.10 | seanbright | i didn't address the other comment about removing stuff, but we can work through that later if necessary |
| 15:08.26 | seanbright | sahmed: ^^^ |
| 15:09.23 | sahmed | okay I will check this, and post update here |
| 15:12.32 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 15:16.26 | seanbright | i think once session->channel is non-NULL it may be too late... but what do i know |
| 15:23.01 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-dkmskybzabbjtrkm) |
| 15:23.01 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:33.04 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-rzvpngqmzggojsqt) |
| 15:33.04 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:59.12 | sahmed | seanbright: I have done few test with some scenarios like "incoming codec different than negotiated", your patch working as well :) |
| 16:01.02 | sahmed | I think now, If the reviewer feel safe about this patch, we can start use this. |
| 16:06.26 | seanbright | ok, we'll try to get it moved through the pipeline |
| 16:06.28 | seanbright | thanks for testing |
| 16:06.51 | seanbright | sahmed: you can abandon 13595 if you like |
| 16:07.09 | seanbright | we'll assume my patch is the one that will (hopefully) make it in |
| 16:08.07 | sahmed | yeah correct |
| 16:08.30 | sahmed | I will mark 13595 as abandon |
| 17:47.20 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.110) |
| 17:47.22 | *** join/#asterisk-dev CELYA_ (~Thunderbi@93-158-26-107.subs.ibrowse.com) |
| 17:49.04 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-loybxvgsfspdipgv) |
| 17:49.04 | *** mode/#asterisk-dev [+o GameGamer43] by ChanServ |
| 18:14.21 | *** join/#asterisk-dev CELYA_ (~Thunderbi@93-158-26-107.subs.ibrowse.com) |
| 18:31.23 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-nmbfxeffayvxwrjf) |
| 18:31.23 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 18:34.47 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-wreqssdurbhjezoy) |
| 18:34.47 | *** mode/#asterisk-dev [+o GameGamer43] by ChanServ |
| 18:35.36 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-uvtkhmbbjoojpdpc) |
| 18:35.36 | *** mode/#asterisk-dev [+o jameswf] by ChanServ |
| 19:28.23 | *** join/#asterisk-dev file (sid178970@asterisk/developer-and-muffin-lover/file) |
| 19:28.23 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 19:48.26 | seanbright | is it worth removing the one-line patch from this issue? https://issues.asterisk.org/jira/browse/ASTERISK-28695 |
| 19:49.25 | seanbright | it's one of those "this is how 99% of people would fix this" things |
| 20:12.52 | *** join/#asterisk-dev csavinovich (sid296765@gateway/web/irccloud.com/x-tpuazdnjejfvczoj) |
| 20:12.52 | *** mode/#asterisk-dev [+o csavinovich] by ChanServ |