| 00:07.05 | rmudgett | Yes. There is only one lock built into an ao2 object. You have your choice in what it is: NONE, MUTEX, or RWLOCK. |
| 00:10.01 | rmudgett | The best ao2 object documentation available is astobj2.h. |
| 00:10.24 | rmudgett | That and the astobj source. :) |
| 00:20.03 | tmoore | thanks for the clarification and astobj.h has been very helpful :D, unfortunately that means an external lib is clobbering my ast obj.. gotta love maintaining open source projects! |
| 06:57.43 | *** join/#asterisk-dev CELYA_ (~Thunderbi@249-47.206-83.static-ip.oleane.fr) |
| 07:10.24 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 08:54.00 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.122) |
| 09:18.29 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.122) |
| 12:26.46 | seanbright | should wdoekes's reviews be cherry picked to maintenance branches? |
| 12:27.12 | seanbright | 13678 is technically a behavior change |
| 12:27.25 | seanbright | 13677 is just documentation |
| 12:29.48 | seanbright | also: the reporter on ASTERISK-26955 indicated that https://gerrit.asterisk.org/c/asterisk/+/13599 fixes the problem, can someone with the proper channels submit to teluu? |
| 12:32.58 | file | 13678 I think makes sense to cherry pick |
| 12:33.06 | file | and I'll submit to le Teluu |
| 12:34.51 | seanbright | good deal. thank you. |
| 12:37.20 | file | email sent |
| 12:37.45 | file | if you make it non-WIP I can comment as such |
| 13:07.25 | seanbright | file: done |
| 13:08.36 | file | nifty |
| 14:19.05 | seanbright | i'll wait to cherry pick until we hear back |
| 15:19.58 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-ekvrrwmvpmkthbps) |
| 15:19.58 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:23.13 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-pnpwmwywjcjunkln) |
| 15:23.13 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:32.31 | gtjoseph | seanbright wdoekes Things are a little confusing in Gerrit (clarify directmediapermit). Sean did you mean to +2 the master review? |
| 15:33.19 | seanbright | i did |
| 15:33.37 | gtjoseph | but not the others? |
| 15:34.04 | seanbright | i assumed we needed two +1s first |
| 15:34.12 | seanbright | but i can +2 them |
| 15:34.39 | gtjoseph | no wait. wdoekes did a "recheck" which triggered th eunit tests to run again. |
| 15:34.44 | gtjoseph | let me sort it. |
| 15:35.04 | seanbright | oops. |
| 15:35.17 | seanbright | ok, sorry, i already did it. will stop touching things until i hear from you. |
| 15:35.32 | gtjoseph | no prob. |
| 15:41.21 | gtjoseph | seanbright: i want to let some things clear out before +2ing anything else. I'll make another pass through gerrit and +2 the ones that are ready in an hour or so. |
| 16:18.28 | sahmed | A question about a scenario of video call, A-side offer w/o video and B-side endpoint has video enabled on his endpoint, what will be the call flow in this scenario? |
| 16:22.45 | sahmed | In this case should Asterisk offer video on B-Side? |
| 16:23.04 | gtjoseph | kharwell: ^^ ? |
| 16:25.17 | kharwell | I'm not sure how it currently works with video |
| 16:25.47 | gtjoseph | i wouldn't think we'd even offer video to "B" in that case. |
| 16:26.47 | sahmed | I did some test yesterday, in 16, asterisk doesn't offer video to B-side |
| 16:27.08 | sahmed | But in asterisk-13 it did offer to B-Side |
| 16:28.32 | gtjoseph | The new media "stream" stuff was introduced in Asterisk 16 |
| 16:29.07 | kharwell | quite possible the behavior changed with that |
| 16:29.29 | gtjoseph | it has more accurate format resolution |
| 16:29.32 | kharwell | Any reason for B to send video if A can't handle it? Server side recording maybe? |
| 16:29.35 | gtjoseph | between parties |
| 16:30.02 | *** join/#asterisk-dev sduthil (~sduthil@ipagstaticip-cf899324-841a-2614-948a-7dbf21746b29.sdsl.bell.ca) |
| 16:33.23 | file | no reason comes to mind |
| 16:33.45 | file | it was probably due to lack of streams and passing things around in some way... and lack of renegotiation |
| 16:39.05 | sahmed | right now I have no idea why we need that scenario, but some unit test failing for this feature |
| 16:59.40 | wdoekes | heh seanbright, I wonder if that ASTERISK-28719 fix will make things "work" that have been long forgotten. I found a "MUST be set to empty, or we lose the option 'empty' using realtime dynamic" added before 2012, so I'm guessing I was/am affected at one point |
| 17:17.18 | seanbright | wdoekes: potentially. that bit of code was heavily modified about 10 months ago (git blame), so it's possible the bug was introduced then or it may have existed before. |
| 17:17.39 | seanbright | it's possible that other realtime db drivers have the same problem but i haven't looked at them |
| 17:18.03 | *** join/#asterisk-dev CELYA_ (~Thunderbi@92.184.100.117) |
| 17:26.55 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.109) |
| 18:16.50 | *** join/#asterisk-dev file (sid178970@asterisk/developer-and-muffin-lover/file) |
| 18:16.50 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 19:35.16 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-jmmxomzwmywaiggv) |
| 19:35.16 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 19:40.01 | *** join/#asterisk-dev spatel (~spatel@static-71-174-102-210.bstnma.fios.verizon.net) |
| 21:59.09 | sahmed | One more thing want to discuss regarding PJSIP_MEDIA_OFFER, if we set PJSIP_MEDIA_OFFER="" then asterisk use empty codec in the outbound offer. This is in Asterisk-16, but in Asterisk-13 use the incoming codec list. Is this expected behavior in asterisk-16? |
| 22:09.41 | gtjoseph | sahmed: i can't check right now but if you set PJSIP_MEDIA_OFFER to an empty string and asterisk sends nothing in the offer, I'd _think_ that's the correct behavior. |
| 22:10.46 | sahmed | yeah that's really logical that offer empty in the offer |
| 22:11.38 | sahmed | but would it be nice if we set empty then offer what it received in incoming leg? |
| 22:13.05 | sahmed | I did a trivial change in the dialplan method and just add a condition to remove all existing cap. By this change it working as my expectation. |
| 22:15.44 | sahmed | I mean, added a condition to protect ast_format_cap_remove_by_type call while wanted to set empty in PJSIP_MEDIA_OFFER |
| 22:16.04 | gtjoseph | Check this out... https://wiki.asterisk.org/wiki/display/AST/Codec+Negotiation :) |
| 22:16.34 | gtjoseph | kharwell: is working on planning the codec negotiation improvements we want to work on this year |
| 22:17.36 | gtjoseph | My brain hurts every time I read it :) but feel free to add comments there. |
| 22:17.39 | sahmed | gtjoseph: Thanks a lot for this link, I will read this soon |
| 23:00.39 | *** join/#asterisk-dev file (sid178970@asterisk/developer-and-muffin-lover/file) |
| 23:00.39 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 23:02.11 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.109) |
| 23:03.04 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-dxzbhjggamyjsmjv) |
| 23:03.04 | *** mode/#asterisk-dev [+o bford] by ChanServ |