| 07:16.01 | *** join/#asterisk-dev electronic_eel (~quassel@HSI-KBW-46-223-65-185.hsi.kabel-badenwuerttemberg.de) |
| 07:17.54 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 07:20.23 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:6148:c511:2c84:cdbf) |
| 07:39.41 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 10:31.37 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.115) |
| 12:44.20 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 12:44.20 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 14:30.26 | *** join/#asterisk-dev sduthil (~sduthil@ipagstaticip-cf899324-841a-2614-948a-7dbf21746b29.sdsl.bell.ca) |
| 14:35.09 | tsearle | hey, what are the branches to cherry pic to these days? |
| 14:35.14 | tsearle | 16, 17 and master? |
| 14:35.25 | gtjoseph | yep |
| 14:35.35 | gtjoseph | assuming you're coming from 13 |
| 14:36.00 | tsearle | yup |
| 14:36.05 | tsearle | cherry-pick done |
| 14:36.39 | tsearle | I got the +1 from the great @file so usually that is my sign that it is safe to cherry pick, heh |
| 14:37.21 | gtjoseph | yep, that's a safe signal :) |
| 14:37.47 | file | it's A signal |
| 14:40.18 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.105) |
| 14:52.09 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-agstsgvujmjbvelq) |
| 14:52.09 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:12.48 | gtjoseph | seanbright: it's a monday morning so forgive me... i'm confused about the existing code in mixmonitor/filename_parse. |
| 15:12.59 | gtjoseph | oh wait. |
| 15:13.09 | gtjoseph | nevermind. |
| 15:14.20 | rmudgett | Yep, Monday... |
| 15:14.41 | gtjoseph | rmu |
| 15:14.48 | gtjoseph | rmudgett: you're around early |
| 15:15.28 | rmudgett | Hopefully, not too early :D |
| 15:31.17 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-aksirhcpwihbhugx) |
| 15:31.17 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:42.47 | seanbright | so for the mixmonitor change that i just put up for review - would anyone object to removing the magic wav49 -> WAV translation that occurs (in master only)? |
| 16:43.07 | seanbright | i'm not sure why it was ever necessary |
| 16:44.46 | seanbright | referring specifically to this code: https://github.com/asterisk/asterisk/blob/master/main/file.c#L318-L319 |
| 16:45.24 | file | hum |
| 16:46.31 | seanbright | https://issues.asterisk.org/jira/browse/ASTERISK-3883 |
| 16:46.32 | file | I... think? that'd be fine |
| 16:46.39 | seanbright | seems it was introduced by that |
| 16:46.50 | file | interestin' |
| 16:47.13 | seanbright | would prefer to clean it up rather than kick the can down the road |
| 16:48.51 | seanbright | will consider doing it as a separate change later |
| 16:50.23 | seanbright | as it is, it is a behavior change, which i will document in CHANGES |
| 16:51.07 | seanbright | i don't think it is breaking though, because if anyone is working around it now, they are _probably_ doing something like "if MIXMONITOR_FILENAME ends with wav49, change it to WAV to find the actual file" |
| 16:51.22 | seanbright | but i dunno |
| 16:51.27 | seanbright | i know it's minor |
| 17:04.17 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 18:07.17 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-hrbcvghodnwiwklc) |
| 18:07.17 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 18:14.32 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.105) |
| 18:27.47 | *** join/#asterisk-dev danjenkins (danjenkins@gateway/shell/matrix.org/x-bkdfnqgaxthnmsdi) |
| 18:27.47 | *** mode/#asterisk-dev [+o danjenkins] by ChanServ |
| 19:08.02 | kharwell | I'm starting some work on the initial new codec negotiation stuff. Adding in the first option. So the obvious place maybe to put this is in the ast_sip_endpoint_media_configuration struct |
| 19:08.16 | kharwell | however that will break abi if we want to put this anywhere but master |
| 19:08.58 | kharwell | Folks think there is any chance we'll want that stuff in < 18 or we just want to do 18+ only |
| 19:09.35 | gtjoseph | i'd say 18+ |