| 05:02.36 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.107) |
| 06:36.28 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.59) |
| 07:10.29 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 07:19.12 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 08:56.01 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 08:56.44 | *** join/#asterisk-dev tsearle (~tsearle@d8D876A4B.access.telenet.be) |
| 08:56.44 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 13:56.51 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-qwysgxfqnzoenrpa) |
| 13:56.51 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:06.06 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 14:39.11 | file | the world didn't explode when I changed the merge strategy on testsuite |
| 14:39.21 | file | do we feel like playing with fire on the Asterisk repo? |
| 14:40.59 | kharwell | sure why not |
| 14:41.01 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-nsifjbeavlzhyxuf) |
| 14:41.01 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:41.12 | file | done! |
| 14:41.23 | tsearle | *kaboom* |
| 14:41.31 | gtjoseph | eh what? |
| 14:42.15 | file | gtjoseph: submit type - it was "Merge if necessary", I changed it on testsuite to "Rebase if necessary" and the world didn't explode |
| 14:42.21 | file | I was asking if we want to tempt things and change it on Asterisk too |
| 14:42.36 | file | to get rid of merge commits in the future and clean up history |
| 14:42.36 | gtjoseph | gotcha. no more merge commits then |
| 14:42.40 | file | yeah |
| 14:42.44 | gtjoseph | wfm |
| 14:43.26 | tsearle | all voxbone is WFM next 2 days, thanks covid-19 |
| 14:43.53 | gtjoseph | WFH? |
| 14:44.03 | tsearle | work from home |
| 14:44.11 | DanJenkins[m] | working from hoem |
| 14:44.25 | tsearle | ah, I did missype |
| 14:44.26 | tsearle | sorry |
| 14:44.30 | gtjoseph | :) |
| 14:44.53 | tsearle | anyhow I do have the fix for the moh_passthru_inactive testsuite test in gerrit |
| 14:46.28 | coreyfarrell | only thing I can think of is that rebase will strip signatures from commits but signatures only existed for `git review` commits, anything that got cherry-picked from web ui never had signatures |
| 14:49.19 | file | I'm not that bothered over that |
| 14:51.07 | coreyfarrell | agreed I don't think it really matters |
| 15:00.09 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 15:13.34 | seanbright | i'd like some thoughts on API |
| 15:13.41 | seanbright | specifically as it related to DNS TXT records |
| 15:15.01 | seanbright | the way that the custom allocators in the newer DNS API work doesn't allow you to allocate additional memory beyond the single record struct (because there is no way to specify a free function) |
| 15:15.41 | seanbright | a single DNS TXT record can contain multiple strings |
| 15:15.58 | seanbright | so this is what i have right now |
| 15:16.00 | seanbright | int ast_dns_txt_get_next_string(const struct ast_dns_record *record, char *buffer, size_t *len, const char **stringp); |
| 15:16.29 | seanbright | buffer is where to store the text, len is the in/out size of buffer, and stringp is a way to save state between calls |
| 15:17.08 | seanbright | so the first call stringp points to a NULL and then it gets updated each time for each additional string in the record |
| 15:17.20 | seanbright | i like this because it doesn't do any unnecessary allocations |
| 15:17.40 | seanbright | i dislike this because it requires a fair amount of setup before the call |
| 15:18.11 | seanbright | i _could_ return a vector, but that would allocate memory and require cleanup |
| 15:18.27 | seanbright | just curious if anyone cares or has any thoughts on this |
| 15:18.54 | gtjoseph | i'd go for the vector |
| 15:20.01 | gtjoseph | if you look at backtrace.c there's an example oif returning a vector and providing a clean up function |
| 15:20.57 | seanbright | but what if i hate that idea? :P |
| 15:21.22 | gtjoseph | then you shouldn't have brought it up |
| 15:21.27 | seanbright | fair |
| 15:21.30 | gtjoseph | :) |
| 15:22.10 | seanbright | tangent: would anyone object to the introduction of a pj_str_t like type? |
| 15:22.17 | seanbright | ast_str_slice or something? |
| 15:22.56 | gtjoseph | rings a bell. i wanto say we had a conversation about that sometime in the past |
| 15:23.06 | gtjoseph | but i can't recall the outcome |
| 15:23.20 | gtjoseph | personally, i wouldn't have a problem with it |
| 15:27.45 | seanbright | alrighty |
| 15:27.48 | seanbright | can we typdef it? |
| 15:27.52 | seanbright | typedef* |
| 15:27.55 | seanbright | pretty please? |
| 15:31.40 | file | sure |
| 15:32.51 | seanbright | nice |
| 15:32.55 | seanbright | it's like christmas |
| 15:33.10 | file | but it's only March! |
| 15:33.15 | seanbright | says you |
| 15:33.22 | file | yes, says me, see above |
| 16:07.46 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.101) |