| 00:35.12 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 00:51.03 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 01:56.06 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 02:25.20 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 03:19.31 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 03:30.44 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 04:15.14 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 04:57.12 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 05:36.09 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 06:21.59 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:930:c5c8:8d76:ddf1) |
| 07:15.48 | *** join/#asterisk-dev skrusty (~skrusty@88.150.145.104) |
| 07:16.08 | *** mode/#asterisk-dev [+o skrusty] by ChanServ |
| 14:00.57 | *** join/#asterisk-dev infobot (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 14:00.57 | *** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 14:09.29 | file | gtjoseph: unless we extend things in the testsuite to be able to do python module dependency checks no versioning foo us |
| 14:10.27 | gtjoseph | I thought we did that already. |
| 14:10.43 | file | not that I could see in the dependencies code |
| 14:11.40 | gtjoseph | hmmmm |
| 14:13.44 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-opbikdgkceoihqhe) |
| 14:13.44 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:37.28 | file | coreyfarrell: merci |
| 14:44.47 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-fxkemvcrrhcjpwyh) |
| 14:44.47 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:52.57 | coreyfarrell | file: I think func_aes should also get the fix to MODULEINFO instead of AST_MODULE_INFO.. one question should the dialplan functions return an error if the res_crypto functions return an error? |
| 14:53.23 | file | yes, and yes |
| 14:53.24 | file | imo |
| 14:57.28 | coreyfarrell | done |
| 18:43.52 | *** join/#asterisk-dev CELYA_ (~Thunderbi@be.celya.fr) |
| 20:11.35 | *** join/#asterisk-dev infobot (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 20:11.35 | *** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 20:28.49 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 20:45.32 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lfbn-nan-1-178-51.w90-49.abo.wanadoo.fr) |
| 21:02.10 | jkroon | kharwell, you are pedandic. you happy with a static buffer on 40 bytes? |
| 21:06.43 | kharwell | ha yeah apologies. I got done "fixing" a bunch of those not long ago. |
| 21:07.00 | jkroon | no stress. i agree with the approach. fix it whilst it's being touched anyway. |
| 21:07.07 | kharwell | It's just an IP address right? |
| 21:07.23 | jkroon | ha->addr |
| 21:07.43 | jkroon | so as far as I know yes, it can ONLY be an address... can make it 64 if you prefer to play VERY safe |
| 21:08.40 | kharwell | I'd think 40 would be plenty then, but can do more if ya want. |
| 21:08.57 | jkroon | 40 is minimum due to v6. |
| 21:09.08 | jkroon | 32 nibbles + 7 colons. |
| 21:09.19 | kharwell | oh yeah forgot about v6 heh. |
| 21:09.45 | file | there's a define |
| 21:09.53 | file | AST_SOCKADDR_BUFLEN |
| 21:09.57 | kharwell | I haven't looked close. Does the stringify loop over each potential IP in addr? There can be more than one right possibly? |
| 21:10.04 | jkroon | awesome, i'll use that rather thanks file! |
| 21:10.09 | kharwell | ah yeah |
| 21:11.18 | jkroon | 45 + 2 + 1 + 5 + 1 <-- interesting. how do we get to that value? 45 + [] + : + 65535 + \0, but 45? |
| 21:13.15 | jkroon | kharwell, https://gerrit.asterisk.org/c/asterisk/+/13951 if you're happy with that i'll cherry pick again |
| 21:14.08 | jkroon | kharwell, for each call to stringify there can be only one IP, and an ACL defines IP/mask pairs, so can't (as far as I can tell from the code) include port numbers either. |
| 21:14.26 | seanbright | ipv4 mapped ipv6 addresses can be 45 bytes |
| 21:15.27 | seanbright | also: https://www.pjsip.org/pjlib/docs/html/group__PJ__SOCK.htm#ga29a062374255dd3f90272161610cc5e3 |
| 21:15.44 | jkroon | seanbright, ::ffff:a.b.c.d - I count 22 |
| 21:15.55 | kharwell | jkroon: looks good to me |
| 21:16.00 | seanbright | jkroon: oh you're right |
| 21:16.03 | seanbright | update the define |
| 21:17.10 | jkroon | look, reality is it's legal to write something like dead:beef:dead:beef:dead:a.b.c.d - which can be 45, but a native v6 won't ever convertto that. |
| 21:17.23 | seanbright | i literally do not care |
| 21:17.28 | seanbright | i don't understand why you care |
| 21:17.38 | seanbright | use AST_SOCKADDR_BUFLEN |
| 21:17.40 | seanbright | move on with your life |
| 21:17.53 | jkroon | i find it interesting :). |
| 21:17.59 | seanbright | well that makes 1 of us |
| 21:18.06 | jkroon | and let's just leave the define at 45 |
| 21:18.15 | seanbright | whatever you think is best |
| 21:23.11 | jkroon | https://gerrit.asterisk.org/c/asterisk/+/13362 - more interested in getting feedback on this. but it's a fairly tricky patch so i'd rather wait for a proper review, even though I've been running this since beginning December in production. |
| 21:25.22 | seanbright | i think all reviews are looked at |
| 21:39.17 | jkroon | kharwell, thank you. i've just fixed a compile issue that didn't happen on my side here. appreciate the nitpick. |
| 21:41.28 | jkroon | seanbright, indeed they are, and eventually it will get a review, doesn't mean i'm not wondering what (if any, it could be OK as it stands) the feedback will be on that. i'd rather it sit there another week than something slips through (it's one of those that could break things for people, similar to the change in chan_sip peer finding did some time last year) |
| 21:41.33 | kharwell | Anytime. I'm here Mon-Thurs. and some Fridays :-D |
| 21:42.02 | jkroon | kharwell, well, it's just about Thu here now :). |
| 21:43.24 | jkroon | next set I'd like to attempt is some way to vary settings based on transport in use for pjsip. |
| 21:53.37 | *** join/#asterisk-dev tmoore (~tmoore@50-253-243-17-static.hfc.comcastbusiness.net) |
| 22:25.18 | *** join/#asterisk-dev snuff-work (~snuff-wor@202-161-112-134.tpgi.com.au) |
| 22:25.18 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |