| 00:56.32 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@rrcs-66-57-14-122.midsouth.biz.rr.com) |
| 00:56.32 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 03:34.44 | *** join/#asterisk-dev infobot (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 03:34.44 | *** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 04:37.09 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-172-88-21-24.socal.res.rr.com) |
| 05:08.37 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:7040:bf4e:43da:55c4) |
| 07:39.25 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:7040:bf4e:43da:55c4) |
| 09:08.51 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:9425:152:9dd9:beb0) |
| 09:49.24 | *** join/#asterisk-dev pchero_work (~pchero@51.247.195.35.bc.googleusercontent.com) |
| 11:24.48 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:9425:152:9dd9:beb0) |
| 12:58.23 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 13:13.42 | *** join/#asterisk-dev sduthil (~sduthil@107-179-252-17.cpe.teksavvy.com) |
| 13:48.23 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:48.23 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:59.08 | *** join/#asterisk-dev pchero_work (~pchero@ip-213-127-79-161.ip.prioritytelecom.net) |
| 14:01.17 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-niqefesefvcxtqxl) |
| 14:01.17 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:03.12 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-naxpznahnnqzotso) |
| 14:03.12 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:34.22 | seanbright | file: are people e-mailing you directly and then you respond to the mailing list |
| 14:34.35 | file | not usually? |
| 14:34.35 | seanbright | or am i just not seeing the original e-mail? |
| 14:34.59 | file | not seeing it? |
| 14:34.59 | seanbright | ah, right. i don't see 'Administrator's e-mail |
| 14:35.38 | file | gtjoseph had a suspicion that something was up with the list |
| 14:35.40 | file | gtjoseph: did you EUS? |
| 14:35.45 | gtjoseph | negative |
| 14:35.50 | gtjoseph | will do now |
| 14:35.51 | file | odd |
| 14:35.58 | seanbright | it's in my spam |
| 14:36.20 | file | greattttttttt |
| 14:36.58 | file | something is certainly up, I see a response to mine but it's not in my gmail |
| 14:37.01 | seanbright | doesn't help that his "name" is Administrator |
| 14:37.53 | file | true |
| 14:37.59 | seanbright | all of his e-mails end up in my spam folder |
| 14:38.57 | seanbright | lol... some of these spam e-mail messages... wow |
| 14:39.20 | seanbright | emoji game is on point |
| 14:39.39 | file | I don't think I've ever looked at my Sangoma spam emails |
| 14:40.33 | file | "Using IBM mainframes/servers? Need input." |
| 14:41.10 | file | "get seo that works for asterisk.org" |
| 14:41.17 | seanbright | you're lucky |
| 14:41.30 | seanbright | i have a lot of people that really want to date me |
| 14:41.37 | file | that one went to security, so gtjoseph and others got it too! :D |
| 14:52.05 | *** join/#asterisk-dev Gugge (gugge@guggemand.dk) |
| 15:00.22 | Kobaz | so, sadly still using chan_sip |
| 15:00.23 | Kobaz | but |
| 15:00.27 | Kobaz | <PROTECTED> |
| 15:00.40 | Kobaz | looking at pcaps... i don't see any legitimate reason whatsoever this connection should drop |
| 15:00.57 | Kobaz | it was chugging along just fine and then asterisk dumps that... and sends RST |
| 15:01.13 | Kobaz | I think select() got interrupted and never tried again |
| 15:03.17 | Kobaz | checks the source |
| 15:10.40 | *** join/#asterisk-dev rmudgett (~rmudgett@170.249.191.178) |
| 15:10.40 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:10.59 | rmudgett | la |
| 15:11.05 | rmudgett | bye |
| 15:11.07 | jkroon | file, kharwell - https://gerrit.asterisk.org/c/asterisk/+/13362 - i know it'll get reviewed when it gets reviewed, just figured i'd check in and ask if there are any concerns currently that you're aware of (I've got a bit of time now to try adres them if any) |
| 15:12.28 | Kobaz | so... -2 is not a normal return from select() |
| 15:12.34 | Kobaz | -2 looks like an internal asterisk thing |
| 15:12.35 | Kobaz | ? |
| 15:13.18 | Kobaz | select() On error, -1 is returned, and errno is set to indicate the error; the file descriptor sets are unmodified, and timeout becomes undefined. |
| 15:14.45 | seanbright | yes |
| 15:14.55 | seanbright | XMIT_ERROR is -2 |
| 15:14.57 | file | jkroon: no, I haven't reviewed it again yet so I can't have concerns yet |
| 15:15.00 | seanbright | which is a chan_sip thing |
| 15:15.05 | Kobaz | makes sense |
| 15:15.11 | Kobaz | what if we add more retrys? |
| 15:15.29 | seanbright | go for it |
| 15:15.37 | Kobaz | see any issue with that? |
| 15:15.48 | seanbright | it's chan_sip |
| 15:15.52 | Kobaz | haha |
| 15:16.06 | Kobaz | __sip_xmit can try again if it would otherwise return -2 |
| 15:16.11 | seanbright | unlikely to get merged unless people are feeling brave |
| 15:16.26 | Kobaz | i'm feeling brave at the moment |
| 15:16.40 | Kobaz | because i'm getting 100 of these every day and people screaming they can't make calls |
| 15:16.45 | Kobaz | "wait 10 seconds and try again?" |
| 15:16.50 | jkroon | file, thanks, and sorry for being a pain about it. |
| 15:17.09 | seanbright | i think the more concerning thing should be 'Interrupted system call' |
| 15:17.19 | seanbright | i'm not sure why that would be occurring so often |
| 15:17.29 | Kobaz | it's on vmware |
| 15:17.34 | Kobaz | soooo, anything's possible? |
| 15:17.44 | jkroon | Kobaz, I believe I already submitted fixes for that issue you're seeing now. |
| 15:17.48 | Kobaz | OH?? |
| 15:17.56 | Kobaz | i could hug you right now |
| 15:17.58 | jkroon | goes to find |
| 15:18.01 | Kobaz | buuut, you know... covid |
| 15:18.27 | Kobaz | this is regarding TLS SIP |
| 15:18.38 | jkroon | all TCP based was affected. |
| 15:18.43 | Kobaz | makes sense |
| 15:18.43 | seanbright | https://gerrit.asterisk.org/c/asterisk/+/13366 |
| 15:18.48 | Kobaz | oh man oh man |
| 15:19.00 | Kobaz | this is almost as exciting as christmas |
| 15:19.20 | jkroon | https://gerrit.asterisk.org/c/asterisk/+/13366 |
| 15:19.24 | Kobaz | 'be less annoying' |
| 15:19.30 | Kobaz | is this only a logging fix? |
| 15:19.37 | seanbright | read the commit message |
| 15:19.42 | Kobaz | yeah i;m gonna |
| 15:22.08 | Kobaz | okay so looking at the diff... it does an immediate return on write fail |
| 15:23.18 | kharwell | jkroon: I haven't gotten to look back at that review yet too |
| 15:28.41 | jkroon | kharwell, thank you. |
| 15:29.16 | jkroon | Kobaz, it's a trivial change with a massive impact. my logs are probably about 50% less cruft in it. |
| 15:29.39 | jkroon | and after some techs kept running down that rabbit hold it had to be fixed. |
| 15:30.11 | Kobaz | ah |
| 15:30.22 | Kobaz | but, this really looks like a logging fix |
| 15:30.37 | Kobaz | i don't see any behavior changes for the -2 type result |
| 15:31.29 | seanbright | are these TLS connections or TCP? |
| 15:31.34 | Kobaz | yes |
| 15:31.41 | seanbright | ... |
| 15:31.51 | Kobaz | oh sorry, TLS+TCP |
| 15:31.57 | seanbright | ok, rando-theory |
| 15:32.17 | seanbright | let me find the review |
| 15:32.54 | seanbright | what version of asterisk? |
| 15:33.25 | seanbright | https://gerrit.asterisk.org/c/asterisk/+/13508 |
| 15:33.29 | seanbright | that is my theory |
| 15:33.34 | Kobaz | don't kill shoot me... but... 1.8 |
| 15:33.38 | seanbright | oh fuck you |
| 15:33.39 | seanbright | ERR |
| 15:33.42 | seanbright | i mean, hmm |
| 15:33.51 | seanbright | that's interesting |
| 15:33.53 | Kobaz | hehe |
| 15:33.57 | seanbright | have a great day |
| 15:34.07 | Kobaz | awww |
| 15:34.29 | Kobaz | i'm going to add a single retry on this transmit if it's -2 |
| 15:36.45 | Kobaz | you'll be happy though... i'm getting closer to being able to upgrade |
| 15:36.55 | Kobaz | i merged one of my bigger changes to trunk |
| 15:37.15 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@rrcs-66-57-14-122.midsouth.biz.rr.com) |
| 15:37.15 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 15:39.59 | Kobaz | i'm really excited to move to pjsip although i need to make some changes to that as well |
| 15:42.23 | *** join/#asterisk-dev pchero_work (~pchero@51.247.195.35.bc.googleusercontent.com) |
| 15:45.38 | *** join/#asterisk-dev Gugge (gugge@guggemand.dk) |
| 15:46.03 | Kobaz | jkroon: but this logging adjustment and adding a retry, should hopefully be something |
| 15:49.23 | Kobaz | here goes |
| 15:50.04 | Kobaz | [2020-04-08 11:49:52.839] WARNING[2053]: chan_sip.c:3376 __sip_xmit: sip_xmit of 0x7f2dc4029c50 (len 632) to 174.225.142.225:6069 returned -2: Success -- Retry |
| 15:50.04 | Kobaz | [2020-04-08 11:49:52.839] WARNING[2053]: chan_sip.c:3390 __sip_xmit: sip_xmit of 0x7f2dc4029c50 (len 632) to 174.225.142.225:6069 returned -2: Success -- Retry Failed |
| 15:50.06 | Kobaz | awwwww |
| 15:51.18 | Kobaz | what the heck is -2 success |
| 15:51.47 | seanbright | considering it is your code, how would we know? |
| 15:52.21 | seanbright | because a -2 return value means that the value of errno is not relevant |
| 15:52.32 | seanbright | so doing a strerror(errno) when res == -2 is meaningless |
| 15:52.34 | Kobaz | right, ah true |
| 15:52.45 | seanbright | and you're on an unsupported version of asterisk |
| 15:52.48 | seanbright | and this is not a support channel |
| 15:52.50 | Kobaz | i know... :( |
| 16:03.16 | jkroon | success = strerror, so if errno=0 ... |
| 16:03.42 | jkroon | Kobaz, which version of asterisk do you have there? and is there a diff to look at? |
| 16:04.20 | jkroon | and your issue is the socket has disconnected already, unlike UDP you can't TX on a disconnected socket. |
| 16:04.34 | Kobaz | 1.8.12 |
| 16:05.02 | Kobaz | but, the interrupted system call thing is so weird... why would it drop the connection |
| 16:05.22 | Kobaz | i have a pcap and there's no external reason for the connection to be closed |
| 16:06.54 | Kobaz | everthing's marching along find and dandy for a new call. unauthenticated INVITE comes in... asterisk response with 401, endpoint ACK's... endpoint sends an authenticated INVITE, asterisk goes to respond. and bam, it fails |
| 16:07.27 | Kobaz | pretty much on the dot, it's repeatible |
| 16:07.59 | Kobaz | so why would it drop at that exact same spot if it was some sort of OS or network thing |
| 16:08.19 | Kobaz | and it's not the external network because it's asterisk that's saying unable |
| 16:08.38 | seanbright | the interrupted system call thing is a read herring |
| 16:08.46 | seanbright | red* |
| 16:08.48 | Kobaz | could be |
| 16:08.54 | seanbright | is |
| 16:09.39 | Kobaz | i added logging to make sure... because -2 could be an overwrite of res ECONNREFUSED with XMIT_ERROR |
| 16:09.55 | Kobaz | in the case atatement right after ast_sendto/sip_tcptls_write |
| 16:10.10 | Kobaz | i want to know if the -2 is coming from the low level or not |
| 16:10.11 | coreyfarrell | keep in mind almost any function you call will reset errno so it might be that you're failing to `int saved_errno = errno; /* do stuff */ errno = saved_errno; return XMIT_ERROR;` |
| 16:10.27 | Kobaz | right, i handled that in the redo |
| 16:11.14 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:9425:152:9dd9:beb0) |
| 16:11.23 | Kobaz | i really don't think it's a a ECONNREFUSED, becuase there's no network traffic to warrant that... but it could be the os sending that back |
| 16:11.35 | seanbright | coreyfarrell: i'm nearly 24 days smoke free |
| 16:11.41 | Kobaz | oh nice |
| 16:11.48 | coreyfarrell | seanbright: congrats! |
| 16:11.53 | Kobaz | my dad quit using the patch |
| 16:11.54 | seanbright | hey thanks |
| 16:12.02 | seanbright | still want to, though :) |
| 16:12.03 | Kobaz | definitely is a process |
| 16:12.09 | seanbright | but it gets better each day |
| 16:13.21 | Kobaz | thankfully this particular system is pretty close to being plain |
| 16:13.27 | coreyfarrell | seanbright: from personal experience I'll say you can never have "just one". I did that once after not smoking for like 3 months.. just one turned into a pack per day within a week. |
| 16:13.31 | Kobaz | i can swap in pjsip and see if we still have an issue |
| 16:13.36 | Kobaz | if my "fix" doesn't work |
| 16:14.09 | seanbright | coreyfarrell: yeah, that has been my experience before when i've quit |
| 16:14.17 | seanbright | and that makes me sad |
| 16:14.18 | seanbright | heh |
| 16:17.03 | Kobaz | these people need to stop making phone calls |
| 16:17.36 | Kobaz | https://i.imgur.com/y7Hm9.jpg |
| 16:17.41 | Kobaz | I try not to make a habit of it |
| 16:18.10 | Kobaz | unfortunately i can't get this to break in any other environments |
| 16:25.13 | jkroon | Kobaz, connection is dropped *before* that error triggers. |
| 16:25.21 | jkroon | probably from the remote side. |
| 16:25.43 | jkroon | have you applied my patch? And WHY oh WHY are you still using 1.8? |
| 16:25.58 | Kobaz | heh |
| 16:26.38 | jkroon | no, read and understand my patch. that entire error output is a red herring. |
| 16:26.51 | Kobaz | ah okay |
| 16:26.52 | jkroon | i suggest get in there with tcpdump if it's that repeatable and SEE what's going on. |
| 16:26.58 | Kobaz | yeah, i have the pcap |
| 16:27.19 | jkroon | return -2 is an INTERNAL error, so errno (which is what indicates interrupted system call) doesn't even relate. |
| 16:27.46 | kharwell | so looking into a dtmf issue. If chan_pjsip is configured for auto or auto_info should those ever initiate dtmf inband from the core? |
| 16:28.01 | kharwell | RFC_4733 shouldn't it seems, but that's the one I'm fixing |
| 16:28.14 | kharwell | oh looks like auto_info doesn't already |
| 16:31.08 | Kobaz | jkroon: right right, yeah, making more sense |
| 16:31.23 | file | kharwell: um |
| 16:31.43 | file | kharwell: auto is a yes. |
| 16:32.55 | Kobaz | I just had to explain to a customer that if I'm on the phone, I can't work on your issue |
| 16:33.04 | Kobaz | this guy is a support vampire, srsly |
| 16:34.28 | kharwell | file: if I understand then really only when "inband" is configured is the only time it inband should be done |
| 16:34.47 | file | kharwell: no - "auto" is supposed to use inband if RFC is not negotiated |
| 16:38.10 | kharwell | hrm okay. looks like a race condition could happen in that case though if rtp has not been established yet. Since there is a difference between not established yet, and not negotiated |
| 16:38.18 | kharwell | might have to break out the logic for those options |
| 16:41.29 | Kobaz | jkroon: yeah, sorry for missing some important bits. I see the early return 0. So yeah, this makes sense |
| 16:42.13 | *** join/#asterisk-dev elguero (~miguel323@c-73-238-205-3.hsd1.nh.comcast.net) |
| 16:45.32 | Kobaz | k, squeeked in the patch the calls dropped to 0 |
| 16:48.07 | jkroon | ?? |
| 16:52.55 | Kobaz | ?? to which? |
| 16:53.25 | jkroon | calls dropping to 0 - badness or it allowed you to restart asterisk to load the patch? |
| 16:53.39 | Kobaz | oh, it allowed me to load it in |
| 16:54.08 | tsearle | astridevcon 2018 minutes got updated...... |
| 16:56.49 | file | I moved it |
| 16:56.55 | file | it was in the top level of the entire wiki |
| 16:57.23 | tsearle | ah ok |
| 16:57.30 | tsearle | that explains why diff found nothing |
| 16:58.01 | tsearle | I was curious why somebody was digging back so far |
| 16:58.29 | tsearle | how is lockdown going for everybody? |
| 16:59.19 | jkroon | Kobaz, and ... is it making a difference for you? |
| 17:00.03 | file | my life is unchanged |
| 17:00.28 | tsearle | then you are quite lucky file |
| 17:00.41 | file | well, except I don't walk to Wendy's |
| 17:01.01 | tsearle | meaning you cook more? |
| 17:01.17 | file | ahahahahahahaha no. |
| 17:01.26 | tsearle | so you drive there now |
| 17:01.30 | file | alas no. |
| 17:01.33 | file | :D |
| 17:02.03 | file | there's delivery, but I also used to use it as a change of scenery which no longer occurs |
| 17:02.32 | file | if the weather ever fully improves I'll partake in working from the deck... but with a "winterlike" storm coming tomorrow/Friday I don't know when that'll be |
| 17:02.34 | tsearle | when the closed all the restaurants, I started to loose weight |
| 17:03.27 | tsearle | it has been amazingly sunny pretty much since lockdown started, trying to lure us all outside |
| 17:08.35 | Kobaz | jkroon: don't know yet, we have a test scheduled for 1:15... it doesn't happen to everyone, but when it does it's consistent |
| 17:08.57 | jkroon | Kobaz, is this is with TLS right? |
| 17:09.01 | Kobaz | yes |
| 17:09.12 | jkroon | and once it happens you're dead in the water? |
| 17:09.18 | Kobaz | yeah |
| 17:09.25 | Kobaz | that connection is completely dead |
| 17:09.30 | jkroon | are clients able to reconnect at all? |
| 17:09.32 | Kobaz | they are |
| 17:09.44 | Kobaz | MicroSIP will immediately reconnect and then you can make a call |
| 17:09.51 | Kobaz | and then 10 calls later it'll drop like that again |
| 17:09.52 | jkroon | then it's not the ulimit related bug I've bumped into. This really belongs in #asterisk though. |
| 17:10.11 | Kobaz | well, yes and no... this is related to the low level handling |
| 17:10.18 | Kobaz | definitely a dev issue |
| 17:10.27 | jkroon | on an outdated (no longer supported) version of *. |
| 17:10.33 | Kobaz | i mean, yes it's not a supported version, but, is low level related |
| 17:10.39 | jkroon | nobody in their right minds should be helping you. |
| 17:10.43 | Kobaz | i know :( |
| 17:11.00 | Kobaz | we're getting there, we should have our system running on 17 by summer |
| 17:11.50 | file | 17 goes security fix only October 28th |
| 17:12.13 | jkroon | Kobaz, i have no concept of what TZ you're in, or even which hemisphere, so that means nothing to me. |
| 17:12.17 | Kobaz | hehe |
| 17:12.20 | Kobaz | 3 minutes |
| 17:41.32 | Kobaz | okay so |
| 17:41.45 | Kobaz | the error went away |
| 17:41.48 | Kobaz | but the connection still drops |
| 17:42.18 | Kobaz | connection reset by peer, on the soft phone |
| 17:42.26 | Kobaz | i'm going to rebuild with pjsip and then re-test |
| 17:42.57 | Kobaz | for me, at least the error is useful for letting me know it was a connection issue |
| 17:43.05 | Kobaz | here it looks like the call ends normally. asterisk shows got hangup |
| 17:43.39 | Kobaz | i'm really curious if pjsip will fix the issue or we'll still have something going on |
| 17:46.18 | opticron | huh, looks like the coding guidelines still reference using svn to make a unified diff |
| 17:54.03 | kharwell | ha goes to show how often that page is read |
| 17:55.43 | opticron | man...how long ago was the change to git? |
| 17:55.47 | opticron | 5+ years? |
| 17:55.54 | Kobaz | a wee bit |
| 17:57.56 | kharwell | it's been a while |
| 17:58.57 | kharwell | seanbright: thanks for updating |
| 18:00.22 | seanbright | https://gerrit.asterisk.org/c/asterisk/+/902 |
| 18:00.27 | seanbright | that's the earliest review i can see |
| 18:00.38 | seanbright | so almost 5 years |
| 18:15.21 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:29c0:155a:c1a7:9cd5:8abb) |
| 18:59.14 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:9425:152:9dd9:beb0) |
| 19:04.29 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:9425:152:9dd9:beb0) |
| 19:13.52 | seanbright | kharwell: does the commit message wrapping look weird to you if you go here: https://gerrit.asterisk.org/c/asterisk/+/14142 |
| 19:15.00 | kharwell | yes. Not sure why. should all be <80. I'll fix it up. Or try to |
| 19:15.07 | seanbright | 72 is the magic number |
| 19:15.12 | seanbright | (don't ask me why) |
| 19:15.20 | kharwell | ah that's probably why then |
| 19:15.31 | seanbright | the minorest of minor issues |
| 19:16.05 | kharwell | lucky me it doesn't cherry pick cleanly either |
| 19:49.19 | *** join/#asterisk-dev Deeewayne (~dwayne@2605:a601:a816:5000:f7ce:535c:c78:9ec3) |
| 19:49.19 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 20:24.09 | *** join/#asterisk-dev pchero_work (~pchero@51.247.195.35.bc.googleusercontent.com) |
| 21:23.49 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 21:58.37 | *** join/#asterisk-dev pchero_work (~pchero@51.247.195.35.bc.googleusercontent.com) |
| 22:03.43 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@be.celya.fr) |
| 23:12.44 | *** join/#asterisk-dev snuff-work (~snuff-wor@202-161-112-134.tpgi.com.au) |
| 23:12.45 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
