| 07:11.54 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 08:17.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lfbn-nan-1-1995-213.w90-105.abo.wanadoo.fr) |
| 11:51.44 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 13:44.06 | seanbright | so current reviews against 13 & 17... abandon? review & merge? |
| 13:48.20 | file | anything put up before the security fix only date is eligible imo |
| 13:48.59 | file | anything new is not, and anything which has findings and is not being worked on I'd say is not |
| 13:52.23 | seanbright | roger |
| 13:52.24 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-urlipicokjjbpcez) |
| 13:52.24 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 13:52.41 | seanbright | no, i don't like kevin either, but he is a valuab |
| 13:52.46 | seanbright | err, wrong window |
| 13:53.11 | seanbright | (see what i did there?) |
| 13:53.48 | file | seanbright: I just did clean up on Gerrit, so it should reflect reality |
| 13:54.45 | file | "reality" |
| 13:56.37 | seanbright | hmm, should that voicemail early media patch go into 16 too? |
| 13:57.20 | file | sure |
| 14:11.53 | file | seanbright: https://gerrit.asterisk.org/c/asterisk/+/15122 |
| 14:18.31 | seanbright | very elegant |
| 14:18.46 | seanbright | i love patches that are like -200,+6 |
| 14:18.57 | file | quite |
| 14:19.08 | seanbright | now the question is... does it work |
| 14:19.22 | file | probably |
| 14:25.44 | seanbright | yes, i broke the voicemail reviews. that is what i get for editing in the browser. fixing shortly. |
| 14:26.20 | file | seanbright: will you make them https://www.youtube.com/watch?v=gAjR4_CbPpQ |
| 14:27.33 | seanbright | there is little doubt |
| 14:33.07 | Dovid | file: How do I find out if it was added to the specific version of asterisk (https://gerrit.asterisk.org/c/asterisk/+/15066). Also should I create it for 18 and "trunk" ? |
| 14:33.36 | kharwell | seanbright: how was I suppose to know you didn't like chocolate chips in your chocolate chip cookies |
| 14:34.51 | file | I don't know what that means exactly... but the branch field tells you what the review is against, and changes should always go to all applicable branches which can be done by clicking the three dots beside Edit and selecting Cherry Pick, then entering the branch to cherry pick it to (such as 18), then cherry picking would have to be done again to master |
| 14:35.24 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-cnlfdqpssjpjiwal) |
| 14:35.24 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:39.29 | seanbright | kharwell: it's like you don't even know me |
| 14:39.59 | seanbright | file: did you have a reproducing case for ASTERISK-29022? |
| 14:40.05 | file | no |
| 14:40.20 | file | could potentially orchestrate it with hacking up the code |
| 14:41.06 | seanbright | but not easily reproducable from outside of asterisk? |
| 14:41.16 | seanbright | i know the answer already |
| 14:41.17 | file | right |
| 14:41.23 | Dovid | file: How do I find out if my code will be added to the next version of 16? |
| 14:41.41 | file | Dovid: if it is merged before the next version of 16, then it will be in it |
| 14:41.43 | file | if it's not, then it won't |
| 14:41.55 | Dovid | so I would see an update that it's merged. correct? |
| 14:42.12 | file | the Asterisk issue is automatically updated with the versions that it is released in |
| 16:34.54 | *** join/#asterisk-dev elcontrastador (~textual@70-90-215-98-BusName-ca.sacra.hfc.comcastbusiness.net) |
| 18:08.49 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lfbn-nan-1-1995-213.w90-105.abo.wanadoo.fr) |
| 20:17.58 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-172-88-21-24.socal.res.rr.com) |
| 20:55.07 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |