| 01:30.30 | *** join/#asterisk-dev pchero (~pchero@211.178.226.108) |
| 01:30.30 | *** mode/#asterisk-dev [+o pchero] by ChanServ |
| 02:26.08 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.107) |
| 02:26.09 | *** mode/#asterisk-dev [+o jkroon] by ChanServ |
| 06:11.30 | *** join/#asterisk-dev csavinovich (sid296765@gateway/web/irccloud.com/x-rsprbfpzeyhegijl) |
| 06:11.30 | *** mode/#asterisk-dev [+o csavinovich] by ChanServ |
| 08:52.01 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 09:51.36 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 10:08.54 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 14:43.11 | gtjoseph | what would you guys think about automatically adding a '\n' to the end of log messages if one wasn't automatically present? |
| 14:44.25 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-hllpmsfwkptwjdjd) |
| 14:44.25 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:47.17 | gtjoseph | s/wasn't automatically/wasn't originally/ |
| 14:50.55 | seanbright | where does that occur? |
| 14:51.21 | seanbright | i mean i know it's the tracing code, but i haven't looked to understand why |
| 14:53.45 | seanbright | i see |
| 14:53.54 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 14:53.56 | seanbright | the alternative being SCOPE_EXIT_RTN_VALUE(0, "\n") i assume? |
| 14:54.34 | file | such a thing would not bother me |
| 14:56.23 | gtjoseph | actually it's be in format_log_message_ap |
| 14:57.00 | gtjoseph | the actual trace code already does it in __ast_trace |
| 14:57.22 | gtjoseph | it's the accompanying debug message that doesn't get the treatment |
| 14:57.48 | seanbright | shrugs |
| 14:58.26 | seanbright | format_log_message_ap is nutty |
| 14:58.59 | gtjoseph | you can say that about a lot of the code :) |
| 14:59.24 | seanbright | so we use a thread local to build a string which we then copy into a string field |
| 14:59.38 | seanbright | why not just use ast_string_field_build_va() and skip the thread local |
| 14:59.47 | seanbright | anyway, good times |
| 15:00.20 | gtjoseph | it has something to do with callid that's already placed in TLS by another module. |
| 15:00.37 | gtjoseph | don't get me started. |
| 15:16.25 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-hdhzzwjuhlcdefmh) |
| 15:16.25 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:21.27 | *** join/#asterisk-dev pchero (~pchero@211.178.226.108) |
| 15:21.27 | *** mode/#asterisk-dev [+o pchero] by ChanServ |
| 16:43.00 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 17:33.10 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.107) |
| 17:33.10 | *** mode/#asterisk-dev [+o jkroon] by ChanServ |
| 18:24.37 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |