| 00:27.26 | *** join/#asterisk-dev pchero (~pchero@211.178.226.108) |
| 00:27.26 | *** mode/#asterisk-dev [+o pchero] by ChanServ |
| 00:46.57 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 02:26.07 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 03:42.36 | *** join/#asterisk-dev electronic_eel (~quassel@213.240.182.67) |
| 09:17.08 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 10:02.34 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00dd6c39e4e3d4e964.ipv6.abo.wanadoo.fr) |
| 11:28.05 | *** join/#asterisk-dev tsearle (tsearlenim@gateway/shell/matrix.org/x-nijpxqfqlmadcxop) |
| 11:28.06 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 14:06.52 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@rrcs-66-57-14-122.midsouth.biz.rr.com) |
| 14:06.52 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 14:27.30 | gtjoseph | jkroon: https://gerrit.asterisk.org/c/asterisk/+/15259 ... Have you looked at using named_locks.h? |
| 14:35.46 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 14:36.41 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 14:42.14 | jkroon | gtjoseph, no, wasn't aware it existed. |
| 14:42.16 | jkroon | will look |
| 14:42.39 | gtjoseph | yeah, it may just make that whole function easierf. |
| 14:50.25 | jkroon | indeed, if it does what it says :). |
| 14:51.53 | jkroon | how would I unload safely? |
| 14:53.09 | jkroon | i also don't see a way to timeout ... ? |
| 14:55.00 | jkroon | gtjoseph, and LUA_VERSION => LUA_VERSIONS done. |
| 14:55.07 | gtjoseph | :), thanks |
| 14:55.25 | jkroon | i love the nitpick. tells me people think about stuff. |
| 14:55.39 | gtjoseph | let me look at the named locxk stuff in a sec. working on another review. |
| 14:57.03 | jkroon | hmm, honestly, no, LOCK/UNLOCK is recursive, so named_locks would require quite a bit of additional work to be done. |
| 14:57.48 | gtjoseph | ok, it's not a big deal. was just wondering. |
| 14:59.10 | jkroon | LOCK + UNLOCK don't match count in case of channel being destroyed with lock held ... so three issues that would need to be overcome: |
| 14:59.27 | jkroon | 1. recursive locking |
| 14:59.38 | jkroon | 2. can we recursively unlock on channel destroy |
| 14:59.46 | jkroon | 3. how do we track for module unload. |
| 15:00.20 | jkroon | 4. locks must be timed on acquire. |
| 15:00.45 | gtjoseph | OK, due dilligence done. :) I'm OK with the review as is then. |
| 15:01.52 | jkroon | again, i appreciate that you don't just blindly accept, i'd rather answer hard questions and we get the right (best) solution rather than just some random solution. |
| 15:02.29 | jkroon | (it's been running in production on one host now that depends heavily on this since I posted it, for what that's worth) |
| 15:05.05 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-zfatbzpzqbrinbvf) |
| 15:05.05 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:27.56 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-tlffvddzketajmny) |
| 15:27.56 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 16:13.22 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 17:03.06 | *** join/#asterisk-dev sduthil (~sduthil@198-48-220-170.cpe.pppoe.ca) |
| 19:28.24 | *** join/#asterisk-dev tmoore (~tmoore@2600:1702:4110:3d10:a87:4347:8dff:c7de) |
| 22:51.11 | *** join/#asterisk-dev pchero (~pchero@211.178.226.108) |
| 22:51.11 | *** mode/#asterisk-dev [+o pchero] by ChanServ |
| 23:03.17 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.106) |
| 23:03.18 | *** mode/#asterisk-dev [+o jkroon] by ChanServ |