| 01:24.21 | *** join/#asterisk-dev pchero (~pchero@211.178.226.108) |
| 01:24.21 | *** mode/#asterisk-dev [+o pchero] by ChanServ |
| 06:44.17 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lfbn-nan-1-1995-213.w90-105.abo.wanadoo.fr) |
| 07:00.39 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:4cf4:a7b2:9bb8:51eb) |
| 10:01.16 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 10:03.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:4cf4:a7b2:9bb8:51eb) |
| 10:09.05 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:f555:40eb:6d34:2887) |
| 10:15.58 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 10:53.42 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00dd6c39e4e3d4e964.ipv6.abo.wanadoo.fr) |
| 13:06.42 | *** join/#asterisk-dev CELYA_ (~Thunderbi@pop.92-184-105-169.mobile.abo.orange.fr) |
| 13:10.19 | *** join/#asterisk-dev CELYA_ (~Thunderbi@pop.92-184-105-169.mobile.abo.orange.fr) |
| 13:30.58 | *** join/#asterisk-dev CELYA_ (~Thunderbi@pop.92-184-105-169.mobile.abo.orange.fr) |
| 13:31.54 | *** join/#asterisk-dev sduthil (~sduthil@198-48-220-170.cpe.pppoe.ca) |
| 14:28.16 | seanbright | can gerrit users be consolidated? looks like nick french has two accounts |
| 14:29.47 | file | I haven't found a way |
| 14:31.58 | seanbright | k |
| 14:39.15 | file | I used to be able to muck with such things when it was in the database, but they moved lots of stuff to NotesDB which has made things... harder |
| 14:40.54 | seanbright | https://ovirt-infra-docs.readthedocs.io/en/latest/General/Gerrit_account_merge/index.html |
| 14:41.02 | seanbright | not sure how old that might be |
| 14:41.18 | file | 'tis old |
| 14:41.31 | seanbright | roger |
| 14:41.38 | file | gsql doesn't exist anymore |
| 14:42.11 | file | let's see if their script was changed... |
| 14:42.41 | file | alas, gone |
| 14:43.41 | seanbright | well, he'll just have multiple personalities from here on out |
| 15:09.13 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 15:14.31 | Kobaz | fun |
| 15:22.52 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-qfopiqglxxcdqjng) |
| 15:22.52 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:28.45 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-ukthcwovtcdubolg) |
| 15:28.45 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:30.01 | seanbright | Kobaz: both of your patches have coding guidelines problems. specifically leading whitespace (we use tabs) and in one case you have an 'else' on a separate line from the '}' |
| 15:30.24 | seanbright | https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines |
| 15:30.44 | Kobaz | i tabified it all |
| 15:30.45 | Kobaz | hmm |
| 15:31.02 | Kobaz | at least I was pretty sure I did |
| 15:31.39 | seanbright | then you used an incorrect number of tabs in some places |
| 15:31.51 | seanbright | it's very obvious in the diff |
| 15:31.54 | seanbright | https://gerrit.asterisk.org/c/asterisk/+/15549/1/main/logger.c |
| 15:31.56 | Kobaz | k |
| 15:32.18 | seanbright | line 265, 436, etc. |
| 15:32.41 | Kobaz | yeah, but it |
| 15:32.44 | Kobaz | *got it |
| 15:32.56 | Kobaz | typically i'm very pedantic on the tabs and get those fixed before sending anything |
| 15:34.39 | Kobaz | but otherwise, functionally? the big question is... it's going to go into a major release and not be a minor update, so is changing console behavior okay based on existing options |
| 15:34.58 | Kobaz | would it be a reasonable expectation that use_callids would just turn this on everywhere, or is another option needed |
| 15:35.16 | seanbright | i don't have an opinion on the functional change |
| 15:35.46 | seanbright | and i only brought it up here because it is easier to say "check your formatting" than to highlight the individual places where it was wrong in the review |
| 15:35.53 | Kobaz | sure, no problem |
| 18:22.12 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 19:49.11 | seanbright | thoughts on requiring a timing module be loaded? |
| 19:51.24 | file | for what reason? |
| 19:52.31 | seanbright | because i wanna |
| 19:52.42 | file | oic |
| 19:53.34 | seanbright | there is an open issue about a crash when a timer isn't loaded |
| 19:53.39 | seanbright | trying to find it again |
| 19:54.52 | file | yes, with DTMF |
| 19:54.58 | seanbright | https://issues.asterisk.org/jira/browse/ASTERISK-28800 |
| 19:55.03 | seanbright | yeah |
| 19:55.50 | seanbright | my thought is that we have code in main/channel.c that assumes a timing module is present |
| 19:55.57 | file | we do now. |
| 19:56.10 | seanbright | right |
| 19:56.15 | file | it wasn't originally like that, it shouldn't assume a timing module is present |
| 19:56.20 | seanbright | i see |
| 19:56.30 | seanbright | i don't like the proposed fix though |
| 19:56.56 | seanbright | alright, good times |
| 19:57.08 | file | offers seanbright a slice of cake |
| 19:57.49 | seanbright | i'm on a diet you insensitive clod |
| 19:58.22 | file | oic |
| 19:59.08 | seanbright | not really |
| 20:09.33 | seanbright | random question: how important is the order of channel variables? |
| 20:10.25 | seanbright | meaning if tomorrow we started randomizing the insert order of the variable into the chanvars list, would that affect people in a meaningful way |
| 20:10.40 | file | shouldn't be important at all |
| 20:11.05 | seanbright | that was my feeling as well |
| 21:13.25 | Kobaz | if I recall, channel variables were a linked list at some point and it was kind of like a last-one-wins type of thing. there could be multiple instances of the same variable name in the list |
| 21:13.46 | Kobaz | not sure if that's like a hash table now or something more 1:1 |
| 21:13.54 | seanbright | that was a bug that should have been fixed |
| 21:14.02 | seanbright | and they are still a list |
| 21:14.37 | seanbright | https://gerrit.asterisk.org/c/asterisk/+/12744 |
| 21:16.14 | Kobaz | gottcha |
| 21:16.38 | Kobaz | that's the benefit of randomizing the insert order? |
| 21:17.59 | seanbright | none |
| 21:18.46 | seanbright | i'm looking at potentially changing the list to a hashtable |
| 21:18.55 | seanbright | which would not have deterministic iteration order |
| 21:19.35 | Kobaz | ah right. I can't imagine a good use-case for iterating the list of variables in some predictable order |
| 21:21.14 | Kobaz | ... as in, relying on a precitable order coming out of asterisk |