| 00:14.54 | jsmith | leifmadsen: I'm back... |
| 00:15.07 | leifmadsen | jsmith: sweet |
| 00:15.20 | leifmadsen | jsmith: just started on some static->XML conversion |
| 00:15.24 | leifmadsen | just learning how all this works |
| 00:15.30 | leifmadsen | seems pretty straight forward |
| 00:15.30 | jsmith | OK... |
| 00:15.36 | leifmadsen | I'm just gonna do this one function |
| 00:15.39 | jsmith | Yeah, we tried to make it simple |
| 00:15.44 | leifmadsen | seems easy enough |
| 00:15.53 | leifmadsen | what would you like to work on tonight, and how would you like to do it? |
| 00:15.56 | jsmith | Easiest way is to just add the stuff to a copy of core-en_US.xml |
| 00:16.14 | leifmadsen | well, apparently it should exist in the .c file |
| 00:16.22 | leifmadsen | in /*** DOCUMENTATION |
| 00:16.22 | jsmith | Then run "xmllint -noout -xinclude -dtdvalid appdocsxml.dtd core-en_US.xml" to validate it |
| 00:16.27 | jsmith | Then stick in the .c file |
| 00:16.41 | leifmadsen | ah gotcha |
| 00:16.45 | leifmadsen | ok, I will do that |
| 00:16.58 | leifmadsen | then I can remove the static struct right? |
| 00:17.06 | jsmith | I think so, yes |
| 00:17.16 | jsmith | You have to change app_register to app_register_xml |
| 00:17.19 | leifmadsen | static struct ast_custom_function smdi_msg_retrieve_function = { |
| 00:17.23 | jsmith | if I remember correctly |
| 00:17.57 | leifmadsen | ast_custom_function_register_xml I presume |
| 00:17.59 | leifmadsen | checks another file |
| 00:18.30 | leifmadsen | hmmm... not in this file anyways |
| 00:23.05 | jsmith | What's the function you're working on? |
| 00:23.45 | leifmadsen | SMDI_MSG_RETRIEVE |
| 00:29.01 | jsmith | Ok... maybe register_xml stuff is only for apps |
| 00:29.04 | jsmith | Still figuring it out |
| 00:29.07 | leifmadsen | np |
| 00:45.41 | leifmadsen | jsmith: so what did you want to work on? |
| 00:45.50 | leifmadsen | jsmith: I don't want to waste all the time on this when I can just do that stuff tomorrow |
| 00:47.05 | jsmith | leifmadsen: Mind taking a look at that link I sent you? |
| 00:47.15 | jsmith | leifmadsen: Let's hack on that tonight, try to make the stuff look better |
| 00:47.15 | leifmadsen | sure, let me load it up |
| 00:47.20 | leifmadsen | jsmith: okie |
| 00:47.48 | jsmith | http://jsmith.fedorapeople.org/AstXML/out8.html |
| 00:47.59 | leifmadsen | loaded up |
| 00:48.02 | leifmadsen | found it in -dev |
| 00:48.35 | leifmadsen | jsmith: would it be worth it to colourize every other box between white and light grey? |
| 00:48.41 | leifmadsen | to separate the rows |
| 00:48.48 | jsmith | I can probably do that |
| 00:49.05 | jsmith | I'd rather concentrate on the content first though, and then work on the stylish stuff |
| 00:52.02 | leifmadsen | ok, then I misunderstood what you meant |
| 00:52.02 | leifmadsen | <jsmith> leifmadsen: Let's hack on that tonight, try to make the stuff look better |
| 00:52.21 | jsmith | OK... what I'm trying to say is |
| 00:52.42 | jsmith | Let's discuss what we want to display, not how to display it |
| 00:52.55 | jsmith | Is all the information there? |
| 00:53.18 | leifmadsen | gotcha -- well, that'll take a while to go through I think... let me load up core-en_US.xml and start at the top |
| 00:53.45 | jsmith | While you're working on that, I'll see if I can do the "one page per application/function/etc" thing. |
| 00:53.56 | leifmadsen | coolio |
| 00:54.11 | leifmadsen | btw: we might be able to re-use the stylesheet from astbook.asteriskdocs.org too (maybe) |
| 00:54.32 | leifmadsen | that might save some time in the style area later |
| 00:55.24 | jsmith | Sure |
| 00:55.42 | jsmith | (I'm less worried about that, as the Drupal theme will give us some styling as well) |
| 00:57.42 | *** join/#asterisk-doc eliel (n=eliels@120-17-235-201.fibertel.com.ar) |
| 00:59.31 | jsmith | eliel! |
| 00:59.34 | jsmith | You're just in time! |
| 00:59.39 | eliel | :-) |
| 00:59.45 | jsmith | You can teach leifmadsen how to add XML docs for a function |
| 01:00.07 | jsmith | eliel: There no special register function for dialplan functions with XML docs like there is for apps, right? |
| 01:00.25 | eliel | right |
| 01:01.03 | leifmadsen | ugh |
| 01:01.21 | leifmadsen | jsmith: is there any way you can make the order of the output not be alphabetical, but rather match core-en_US.xml ? |
| 01:01.30 | leifmadsen | otherwise I'm going to have to jump all over the place |
| 01:01.32 | jsmith | leifmadsen: Your wish is my command |
| 01:01.35 | leifmadsen | thanks! |
| 01:02.01 | leifmadsen | eliel: tomorrow I'm going to do the other functions and apps in that bug note I think |
| 01:02.09 | leifmadsen | I didn't get to it today because I was doing business stuff |
| 01:02.15 | leifmadsen | (which sucks since I don't get paid to do that :)) |
| 01:02.51 | eliel | welcome aboard! :) |
| 01:03.26 | eliel | if i have the time i will help you with some of those files |
| 01:04.12 | leifmadsen | eliel: no problem -- I want to learn how to do them |
| 01:04.24 | leifmadsen | I will post a patch for review when I get them done |
| 01:04.35 | eliel | good |
| 01:09.42 | jsmith | http://jsmith.fedorapeople.org/AstXML/out9.html |
| 01:10.32 | leifmadsen | loading |
| 01:10.44 | leifmadsen | will let you know what I find |
| 01:11.44 | jsmith | XSL file is at http://jsmith.fedorapeople.org/AstXML/astxml_html.xsl |
| 01:11.47 | leifmadsen | coolio |
| 01:11.52 | jsmith | (patches gladly accepted) |
| 01:11.55 | leifmadsen | just going through that file, and will do the comparison |
| 01:12.53 | leifmadsen | jsmith: I don't even know if this is possible... but can you make it so it also doesn't break it out by application, function, etc... ? |
| 01:13.02 | leifmadsen | this .xml file seems to be in some random order.... |
| 01:13.14 | leifmadsen | oh, no it's not |
| 01:13.19 | leifmadsen | it's alphabetical, uncategorized |
| 01:13.35 | leifmadsen | nope, that's not true either |
| 01:13.37 | leifmadsen | eeps |
| 01:13.44 | leifmadsen | it fooled me! :) |
| 01:13.52 | eliel | the core file is not in any order |
| 01:14.08 | leifmadsen | ya... |
| 01:14.36 | leifmadsen | not sure how jsmith is building his html file, so not sure if he can make it follow the xml thing totally |
| 01:15.10 | jsmith | xsltproc astxml_html.xsl core-en_US.xml > out9.html |
| 01:15.15 | jsmith | That's how I'm building it :-) |
| 01:18.30 | eliel | jsmith: we will need to fix the syntax generator |
| 01:18.40 | eliel | for example the Goto() application is wrong |
| 01:19.14 | eliel | it should be: Goto([[context,]extensions,]priority) and it is Goto([context[,extensions[,priority]]]) |
| 01:20.21 | eliel | To fix this we first need to verify the order of evaluation |
| 01:20.55 | jsmith | eliel: Ah, right... |
| 01:21.10 | jsmith | eliel: If you can write it in pseudo-code, I can code the XSL |
| 01:21.25 | jsmith | (or, if you grok XSL, feel free to fix it yourself) |
| 01:21.58 | eliel | the algorithm is the same, for both cases, except that based on parameters you start from the first parameter to the end, or you start with the last parameter and go to the first |
| 01:22.27 | russellb | looks at the XSL file and his head explodes |
| 01:22.55 | jsmith | russellb: Oh c'mon, it's not that bad |
| 01:23.02 | russellb | :-) |
| 01:23.07 | russellb | I just have no idea what I'm looking at |
| 01:23.09 | jsmith | (and yes, it's a bit of a mess... but it's fairly straightforward) |
| 01:23.13 | jsmith | Want me to explain? |
| 01:23.21 | jsmith | I'd be happy to give you the nickel tour |
| 01:23.23 | russellb | No, I honestly was very surprised how concise it was |
| 01:23.30 | russellb | I thought it would be crazy huge or something |
| 01:23.34 | russellb | nice job |
| 01:23.38 | jsmith | functional languages are concise :-) |
| 01:23.52 | russellb | i'll ask more about how it works later ... dinner time! |
| 01:24.01 | jsmith | should really grab some dinner too |
| 01:24.12 | eliel | http://pastebin.ca/1447007 |
| 01:24.17 | jsmith | leifmadsen: Do you have enough to keep you busy if I grab some dinner quickly? |
| 01:25.06 | jsmith | eliel: OK... what do you mean by "node = lastparam" or "node = firstparam" |
| 01:25.15 | jsmith | Does that mean we parse them backwards or not? |
| 01:26.03 | eliel | yes, sorry, this was a copy and paste from main/xmldoc.c |
| 01:26.08 | leifmadsen | jsmith: yes, I have lots |
| 01:26.37 | eliel | jsmith: the function generating the syntax is named: xmldoc_get_syntax_fun() in that file (main/xmldoc.c) |
| 01:27.19 | jsmith | OK, I'll read that |
| 01:29.15 | eliel | the better example is the Goto() application |
| 01:29.34 | eliel | you need to start from the last parameter and it is required so you put: |
| 01:29.40 | eliel | priority) |
| 01:29.53 | eliel | then you have another parameter but it is optional so you put: |
| 01:30.03 | eliel | extension,]priority) |
| 01:30.15 | eliel | and open brackets++ |
| 01:30.24 | eliel | so at the end we can close them |
| 01:30.36 | eliel | then we have another optional parameter and we add it |
| 01:30.52 | eliel | context,]extension,]priority) |
| 01:31.20 | eliel | now it is time to close open brackets (if you are using recursion it is time to return...) |
| 01:31.34 | eliel | [[context,]extension,]priority) |
| 01:31.59 | eliel | now print the name of the app/fun with the parenthesis: |
| 01:32.11 | eliel | Goto([[context,]extension,]priority) |
| 01:32.44 | jsmith | Right... I understand. |
| 01:33.50 | jsmith | Now I just have to find out how to do it correctly in XSL |
| 01:35.27 | jsmith | I'm gonna grab some dinner, and then I'll hack on it |
| 01:35.49 | leifmadsen | jsmith-dinner: holy crap.... this is going to take me days to review |
| 01:36.09 | leifmadsen | it's taken me just 15 mins to get 1/3rd of the way through just making sure the apps even exist |
| 01:36.23 | leifmadsen | I haven't even started to check content |
| 01:36.32 | *** join/#asterisk-doc Khratos (n=Khratos@190.166.130.142) |
| 01:37.46 | leifmadsen | I think I just need to review all the data on your page after making sure all the apps exist, then just see if there is anythign that looks funny, and if so, check the XML, and make sure they match -- if they do, then I'll worry about fixing the docs after |
| 01:37.55 | leifmadsen | if they don't match, then I'll let you know |
| 01:38.28 | eliel | leifmadsen: every app in xml exist |
| 01:38.53 | leifmadsen | eliel: no, I'm making sure what jsmith generated is the same as the core xml file |
| 01:39.03 | leifmadsen | (i.e. that what he is generating is an accurate representation of the XML) |
| 01:39.11 | leifmadsen | (i.e. he didn't miss anything) |
| 01:39.16 | eliel | oh, sorry |
| 01:39.22 | leifmadsen | np :) |
| 01:40.53 | leifmadsen | jsmith-dinner: what version of asterisk is this against? trunk? I just found an app that exists in my XML, but not in your document: VoicemailUsersList |
| 01:45.16 | leifmadsen | ok -- all apps in your list match my list, except for the above |
| 01:47.24 | leifmadsen | wow... only when you start looking through the new XML stuff do you realize just how much documentation is really missing :) |
| 01:48.26 | eliel | and you didn't arrive to the manager actions yet |
| 01:48.58 | eliel | only one line trying to explain each action... |
| 01:51.23 | leifmadsen | ya... |
| 01:51.33 | leifmadsen | yuck... so much work to be done on the docs |
| 01:52.22 | leifmadsen | I'm not sure how relevant or necessary it is to state what is returned... like 0, -1, etc.... |
| 01:52.29 | leifmadsen | seems more like that should be in the developer documentation |
| 01:52.42 | leifmadsen | since it's not something you can check from the dialplan |
| 01:55.26 | Khratos | Is it a manager command that returns -1 or 0 you say? |
| 01:58.58 | Khratos | Maybe it would be good to write somewhere that you MUST set an extension as a peer in order to have it reporting its status (when using hints) for outgoing & incoming calls |
| 02:03.14 | leifmadsen | Khratos: no, what I'm saying is a dialplan application documentation that states what the application returns (programmatically) makes no sense to me since you can't do anything with it |
| 02:04.29 | Khratos | Good point, not too useful for anyone, and it could confuse a totally-newbie |
| 02:04.42 | leifmadsen | jsmith-dinner: ok, I just got through all the applications, and this all looks fine to me! |
| 02:04.57 | leifmadsen | I'm going to spend some time with the g/f now, then bed. I'll finish up the rest tomorrow. |
| 02:06.45 | Khratos | In a future, leifmadsen , if possible, could someone extend the PICKUPMARK stuff of Pickup() ? , I got to understand it fine but is not really very clear |
| 02:07.00 | leifmadsen | Khratos: patches welcome |
| 02:07.23 | leifmadsen | Khratos: I have no idea how it works either, and now that you know how, you should write up some docs -- I'll clean them up |
| 02:07.47 | leifmadsen | just create an issue with a small patch that updates the documentation with some information you think should be there |
| 02:07.58 | Khratos | I'll confirm what I thought I understood with some dude on -dev , and drop you a line by email |
| 02:08.29 | Khratos | or create the issue as you mentioned |
| 02:09.08 | leifmadsen | Khratos: awesome, thanks for contributing! |
| 02:09.30 | Khratos | U're welcome :) |
| 02:10.33 | leifmadsen | heads off for the night |
| 04:11.53 | Juggie | got all the docs written yet? :) |
| 04:14.09 | Juggie | jsmith: ping |
| 04:31.49 | *** part/#asterisk-doc Khratos (n=Khratos@190.166.130.142) |
| 05:59.15 | *** join/#asterisk-doc Juggie (n=Juggie@99.224.81.113) |
| 06:29.31 | *** join/#asterisk-doc oej (n=olle@eduroam-193-157-113-80.uio.no) |
| 07:13.52 | *** join/#asterisk-doc Juggie (n=Juggie@CPE001601df17fb-CM001ceac25ada.cpe.net.cable.rogers.com) |
| 10:42.47 | *** join/#asterisk-doc sgpm (n=chatzill@61.17.185.118) |
| 10:43.04 | *** join/#asterisk-doc SunSon (n=chatzill@61.17.185.118) |
| 10:43.42 | SunSon | Am in new to asterisk how to connect socket program in asterisk using java |
| 12:29.48 | *** join/#asterisk-doc leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:29.48 | *** mode/#asterisk-doc [+o leifmadsen] by ChanServ |
| 12:42.31 | *** join/#asterisk-doc eliel (n=eliels@200.61.172.61) |
| 13:53.54 | leifmadsen | eliel: ping |
| 13:54.05 | eliel | leifmadsen: pong |
| 13:54.09 | leifmadsen | can I have nested optionlists ? |
| 13:54.14 | leifmadsen | <optionlist> |
| 13:54.16 | leifmadsen | <option> |
| 13:54.21 | leifmadsen | <PROTECTED> |
| 13:54.23 | leifmadsen | etc... |
| 13:54.34 | leifmadsen | this is what I'm thinking of using that one |
| 13:54.38 | leifmadsen | <PROTECTED> |
| 13:54.38 | leifmadsen | <PROTECTED> |
| 13:54.38 | leifmadsen | <PROTECTED> |
| 13:54.38 | leifmadsen | <PROTECTED> |
| 13:54.39 | leifmadsen | <PROTECTED> |
| 13:54.41 | leifmadsen | <PROTECTED> |
| 13:54.53 | leifmadsen | I want to create another list inside there for the D, A, B, N |
| 13:55.15 | eliel | i think that should be an enumlist instead |
| 13:55.19 | leifmadsen | oh really? |
| 13:55.26 | leifmadsen | inside the option? |
| 13:55.48 | leifmadsen | Typical examples are: |
| 13:55.52 | leifmadsen | <enumlist> |
| 13:55.59 | leifmadsen | <enum name="D"> |
| 13:55.59 | leifmadsen | ? |
| 13:56.57 | eliel | yes |
| 13:57.18 | leifmadsen | awesome, let me give that a shot |
| 13:57.22 | eliel | you can't (at the moment) put an optionlist inside another option, but adding that is easy for me.. but: |
| 13:57.39 | leifmadsen | what is the difference between an enum list and an option list? |
| 13:57.39 | eliel | You use optionlist when more that one of the options could be put together like: |
| 13:57.52 | eliel | Dial(....., aBM()) |
| 13:58.02 | leifmadsen | aha! |
| 13:58.05 | eliel | a, B, M are options inside an optionlist |
| 13:58.15 | leifmadsen | then I should probably use enum list here, and not option list |
| 13:58.23 | leifmadsen | enumlist is for using 1 of a list? |
| 13:58.35 | leifmadsen | 1 of the following values (for example) |
| 13:58.36 | eliel | exactly |
| 13:58.44 | leifmadsen | ok cool -- then optionlist is just wrong usage here |
| 13:58.48 | leifmadsen | I will fix |
| 13:58.49 | leifmadsen | thanks! |
| 13:59.12 | eliel | np |
| 13:59.19 | leifmadsen | eliel: and it's <enum name="foo"> ? |
| 13:59.57 | eliel | yes with <para> elements inside it to explain it |
| 14:00.02 | leifmadsen | ok coolio |
| 14:00.18 | leifmadsen | <option> doesn't use para though right? |
| 14:01.07 | eliel | option elements accept: variablelist, enumlist, para, and special tags (warning, note) |
| 14:01.41 | eliel | oh, and 'argument' |
| 14:01.42 | leifmadsen | ok cool |
| 14:01.50 | leifmadsen | I think I was using optionlist entirely wrong ;) |
| 14:01.51 | eliel | <!ELEMENT option (argument|para|note|warning|variablelist|enumlist|xi:include)*> |
| 14:02.16 | eliel | looking at appdocsxml.dtd is a simple way to check what is accepted at the moment inside every element. |
| 14:02.42 | leifmadsen | ah coolio |
| 14:02.43 | leifmadsen | thanks! |
| 14:02.56 | eliel | ur welcome |
| 14:11.26 | leifmadsen | eliel: hopefully last question :) |
| 14:11.28 | leifmadsen | ast_custom_function_register(&smdi_msg_retrieve_function); |
| 14:11.32 | leifmadsen | what should I replace that with now? |
| 14:11.40 | leifmadsen | since I just took out the documentation that was there before |
| 14:12.41 | leifmadsen | ast_custom_function_register and unregister? |
| 14:13.04 | leifmadsen | oh wait... that's what is there now |
| 14:13.29 | leifmadsen | aha, I think I see |
| 14:13.31 | leifmadsen | someting like this: |
| 14:13.33 | leifmadsen | static struct ast_custom_function volume_function = { |
| 14:13.33 | leifmadsen | <PROTECTED> |
| 14:13.33 | leifmadsen | <PROTECTED> |
| 14:13.33 | leifmadsen | }; |
| 14:14.17 | *** join/#asterisk-doc Khratos (n=khratos@190.166.103.254) |
| 14:15.59 | leifmadsen | I think I got it now actually |
| 14:17.36 | leifmadsen | I just removed too much |
| 14:22.01 | eliel | leifmadsen: removing the summary, description, etc from the ast_custom_function and leaving just name and write/read is enough to make the register function search in the xmldocs for that function documentation |
| 14:22.13 | leifmadsen | yep, just figured that part out :) |
| 14:22.40 | eliel | actually this is being done in every call to register _xml is the same register implementation except that no documentation is being passed |
| 14:23.24 | eliel | to avoid those NULL parameters we made macros to simplify code |
| 14:25.12 | leifmadsen | nice |
| 14:39.00 | leifmadsen | eliel: can you see what I have wrong here? |
| 14:39.01 | leifmadsen | http://pastebin.com/m5f2728ce |
| 14:40.05 | eliel | 'requires' should be 'required' |
| 14:40.19 | leifmadsen | doh! |
| 14:40.21 | leifmadsen | I keep making that typo |
| 14:40.26 | leifmadsen | aha... duh |
| 14:40.29 | eliel | required="false" is the default so you don't need put it |
| 14:40.58 | leifmadsen | ah gotcha |
| 14:43.40 | jsmith | Morning folks... |
| 14:44.40 | eliel | jsmith: morning |
| 14:44.59 | jsmith | is hacking on the syntax generator again |
| 14:50.56 | russellb | you h4x0r! |
| 14:51.25 | eliel | 31337 |
| 14:51.57 | Juggie | jsmith:ping |
| 14:52.30 | russellb | 31337 is the most l33t conference bridge ev4r |
| 14:53.07 | jsmith | Juggie: pong |
| 14:53.20 | Juggie | jsmith: are you guys pulling all the * docs right from the xml inside the source? |
| 14:53.21 | eliel | is now known as 37137 |
| 14:53.27 | jsmith | russellb: I'm serious about walking you through the XSL file, if/when you have time and interest |
| 14:53.35 | jsmith | Juggie: Aye! |
| 14:53.40 | Juggie | jsmith: thats hot |
| 14:53.58 | jsmith | Juggie: As hot as leifmadsen's g/f? |
| 14:53.58 | Juggie | not meghan fox hot, but hot :P |
| 14:54.16 | Juggie | is he dating meghan fox? |
| 15:02.42 | Juggie | guess not :) |
| 15:03.25 | jsmith | I don't know... he's apparently dating some blonde, but I haven't seen the pictures yet |
| 15:12.50 | leifmadsen | jsmith: http://photos-g.ak.fbcdn.net/photos-ak-snc1/v2137/55/84/512680761/n512680761_1316942_2487.jpg |
| 15:14.12 | jsmith | leifmadsen: She's not hard to look at |
| 15:15.21 | leifmadsen | jsmith: :D |
| 15:16.38 | jsmith | I don't know about the blonde part though... blondes make me nervous |
| 15:16.57 | leifmadsen | lol |
| 15:16.58 | leifmadsen | me too |
| 15:26.49 | Juggie | jsmith: ping |
| 15:26.52 | Juggie | any idea what i |
| 15:26.58 | Juggie | er, what i'm doing wrong here, http://pastebin.ca/1447668 |
| 15:27.17 | Juggie | w/o the sub select the query runs fine but with it returns a bazillion rows and puts mysql @ redline. |
| 15:27.37 | Juggie | i've used the sub query in a few other places w/o issue but they never had any outer joins. |
| 15:29.54 | jsmith | Why do you have a GROUP BY clause? |
| 15:30.14 | Juggie | not sure i didnt write the query |
| 15:30.23 | Juggie | and its kind of causing a problem atm and it wasnt jumping out at me :) |
| 15:31.26 | Juggie | removing the group by didnt help. |
| 15:32.40 | Juggie | seems like its creating a situation where there are a million rows to return |
| 15:32.44 | Juggie | thep rocess list says sending data |
| 15:32.49 | Juggie | but i'm not sure why |
| 15:34.17 | Juggie | ok... |
| 15:34.19 | Juggie | its not |
| 15:34.24 | Juggie | just returns the same # of rows |
| 15:34.31 | Juggie | but it takes 188 seconds w/ the subselect |
| 15:34.42 | Juggie | and 0.3 w/o :) |
| 15:52.15 | leifmadsen | eliel: ping?! |
| 15:52.17 | leifmadsen | :) |
| 15:52.29 | eliel | leifmadsen: looking at your patch :) |
| 15:52.33 | leifmadsen | #if defined(HAVE_SYSINFO) |
| 15:52.37 | leifmadsen | how should i handle that? |
| 15:52.57 | leifmadsen | only certain values are listed in the options to SYSINFO() if something is set it seems |
| 15:52.59 | eliel | i think it is related to the operating system |
| 15:53.10 | leifmadsen | ya.... I'm just curious how to code that in XML.... |
| 15:54.14 | eliel | mm, that is a good question, there was a discussion about this and the conclusion was to put everything in the docs with warnings about this optional features based on those requirements |
| 15:54.22 | leifmadsen | ok cool |
| 15:56.20 | leifmadsen | how should I add a note to an enum? <enum><para>...</para><note>...</note></enum> ? |
| 15:58.31 | eliel | <note><para>Message</para></note> |
| 15:59.01 | leifmadsen | aha |
| 15:59.08 | eliel | your patch looks good |
| 15:59.17 | leifmadsen | can I do a <para>, then a <note><para> on the next line? |
| 15:59.25 | eliel | yes |
| 15:59.30 | leifmadsen | i.e. is note valid inside an <enum> ? |
| 15:59.34 | leifmadsen | I presume it is |
| 15:59.34 | eliel | but not a <note> inside a <para> |
| 15:59.39 | leifmadsen | ok -- got it |
| 16:02.22 | leifmadsen | eliel: thanks for the review! It'll be part of the larger patch when I submit it |
| 16:02.46 | eliel | i recommend using one patch for each file |
| 16:02.57 | eliel | then i will be commiting every file you upload to the issue |
| 16:03.13 | eliel | it is simple to read than having a big patch with all the docs |
| 16:04.55 | leifmadsen | ok, makes sense to make |
| 16:04.58 | leifmadsen | makes sense to me* |
| 16:05.08 | leifmadsen | I will create individual patches then |
| 16:07.20 | eliel | leifmadsen: one minor thing, try to avoid <para>\n....</para> or tabs inside <para> at the first line, because they will be replaced by a space... |
| 16:08.36 | leifmadsen | eliel: oh ok -- I will try and fix that |
| 16:08.50 | eliel | i have already fix you uploaded patch |
| 16:08.54 | eliel | it is ready to be commited |
| 16:08.55 | leifmadsen | sweet |
| 16:09.04 | leifmadsen | awesome -- I'm just working on the next function |
| 16:09.08 | leifmadsen | already almost done |
| 16:09.13 | leifmadsen | after the first one, these will be easy |
| 16:20.04 | Juggie | jsmith: ping |
| 16:20.13 | jsmith | Juggie: pong |
| 16:20.25 | Juggie | jsmith the problem was the sub query in the field list |
| 16:20.29 | Juggie | needed to move it to a join |
| 16:21.03 | Juggie | such that it only did the sub for the rows that mached the first two joins |
| 16:21.09 | Juggie | and not the entire result set before the joins. |
| 16:22.16 | jsmith | Juggie: That was going to be my next suggestion |
| 16:27.33 | eliel | leifmadsen: remember to put see-also when possible :) |
| 16:31.29 | leifmadsen | eliel: ah yes, good call |
| 16:47.48 | Juggie | eliel, how goes SOC? |
| 16:49.27 | eliel | we are designing the data API, i have already write some code, the progress is in /team/group/data_api_gsoc2009 |
| 16:49.38 | Juggie | i have high expectations :) |
| 16:49.59 | eliel | hope to end up with a useful api |
| 16:50.13 | Juggie | it cannot be any worse then the current state |
| 16:50.23 | Juggie | and should remove a nice portion of code in every module |
| 16:50.50 | eliel | and add code in other parts :) |
| 16:50.58 | Juggie | ya |
| 16:51.04 | Juggie | but modules have no business doing formatting |
| 16:51.37 | eliel | yes |
| 16:52.22 | Juggie | infact i'd argue they should not even register commands |
| 16:52.25 | Juggie | just datasets. |
| 16:53.58 | Juggie | at that point you'd just have a config file that says sip show peers uses dataset chan_sip_peers and uses these fields (x,y,x) from the set :) |
| 16:54.14 | Juggie | then if someone wants to extend it to include more info, no problem :P |
| 16:54.38 | Juggie | that would be amazing. |
| 16:55.37 | Juggie | waits for someone to agree :P |
| 16:56.49 | Juggie | echo echo echo |
| 16:58.38 | Juggie | eliel: ? |
| 17:02.12 | *** join/#asterisk-doc oej (n=olle@193.214.121.5) |
| 17:03.54 | russellb | quick visit! |
| 17:06.42 | eliel | Juggie: yes, it would be great, at least this api is the first step, have all the information in a common format |
| 17:12.52 | jsmith | eliel, leifmadsen, russellb, et al... Does the syntax for Goto() look better now? http://jsmith.fedorapeople.org/AstXML/out9.html |
| 17:13.26 | eliel | jsmith: yes :) |
| 17:14.11 | jsmith | eliel: Do you see problems with the syntax of any other applications? |
| 17:15.22 | eliel | jsmith: yes, in gotoiftime |
| 17:15.26 | *** join/#asterisk-doc oej (n=olle@193.214.121.5) |
| 17:15.38 | eliel | GotoIfTime(times,weekdays,mdays,months[,timezone]?[labeliftrue][:labeliffalse]) |
| 17:15.45 | eliel | ^^^ it should be |
| 17:16.06 | eliel | but it is: GotoIfTime(condition,destination) |
| 17:16.48 | jsmith | Ouch... I didn't look at that |
| 17:16.51 | jsmith | I'll fix that one up next |
| 17:17.43 | eliel | the problem is that if there are <argument> elements inside a <parameter> you should generate a syntax using those arguments, the parameter is just a container in those cases |
| 17:18.09 | eliel | it is kind of recursive |
| 17:18.39 | jsmith | Yeah... I thought I had that working, but I must have broken it |
| 17:19.12 | jsmith | This syntax generator is going to be longer than the rest of the XSL file, by far! |
| 17:19.17 | eliel | http://pastebin.ca/1447751 |
| 17:23.41 | leifmadsen | hawtness abounds |
| 17:23.47 | leifmadsen | lookin' good so far! |
| 17:54.17 | *** join/#asterisk-doc RobH (n=RobH@rob.tech.wikimedia.org) |
| 18:00.41 | jsmith | eliel: Do you know of any apps that have an optional parameter in the middle? |
| 18:01.53 | eliel | if they have an optional parameter in the middle is because they also have optional parameters at the start or the end |
| 18:03.34 | jsmith | eliel: I saw your logic accounted for that, and I fixed my syntax generator to do the right thing, but couldn't think of any apps with optional parameters in the middle. |
| 18:03.50 | jsmith | eliel: But your logic said "if ((!reqfinode && reqlanode) || (reqfinode && reqlanode && optmidnode))" |
| 18:03.54 | jsmith | Notice the second clause there... how could they have a required first node and required last node *and* an optional middle node |
| 18:04.34 | jsmith | Just curious... anyway, my generator does the correct thing in that case now |
| 18:04.51 | eliel | is thinking way he did that |
| 18:05.13 | jsmith | eliel: Another question... my XSL right now only looks for required="true", but the DTD allows for "true" or "yes" |
| 18:05.24 | jsmith | eliel: Should we change the DTD or change my XSL? |
| 18:05.55 | eliel | i am using ast_true() and ast_true allow for "1", "y", "yes", "true", "go ahead" ,heheh |
| 18:07.36 | jsmith | Right... OK. |
| 18:07.41 | jsmith | I'll fix my XSL to follow the DTD |
| 18:11.35 | eliel | i think that the code checking the middle node condition is useless and it is wrong, i will review it again when i get some time |
| 18:13.41 | jsmith | OK. |
| 18:17.14 | *** join/#asterisk-doc oej (n=olle@193.214.121.5) |
| 18:38.02 | leifmadsen | jsmith: http://blog.voiptrunk.com/?p=36 |
| 18:40.53 | eliel | eliel@digium? |
| 18:40.58 | eliel | lol |
| 18:44.38 | jsmith | leifmadsen: Beat you to it, my friend |
| 18:44.57 | leifmadsen | :) |
| 18:45.05 | leifmadsen | jsmith: I didn't see it yesterday |
| 18:45.15 | leifmadsen | eliel: hehehe |
| 18:54.17 | Juggie | leifmadsen: http://www.realtor.ca/PropertyDetails.aspx?vd=&SearchURL=%3fMode%3d0%26vs%3dResidential%26ret%3d300%26curPage%3dpropertySearch.aspx%26sts%3d0-0%26beds%3d0-0%26baths%3d0-0%26pro%3d-1%26st%3dkeltie%26zip%3dk2j0a4%26mp%3d0-0-0%26mrt%3d0-0-4%26trt%3d2%26of%3d1%26ps%3d10%26o%3dA&Mode=0&PropertyID=8351703 |
| 18:54.49 | leifmadsen | Juggie: nice ) |
| 18:54.51 | leifmadsen | :) |
| 18:54.57 | leifmadsen | you have a lot of beige... or pink.... |
| 18:55.01 | Juggie | no pink |
| 18:55.18 | Juggie | two shades of 'earth tones |
| 18:55.20 | Juggie | ' |
| 18:55.41 | Juggie | flash makes it look weird |
| 18:55.54 | Juggie | but in person its brown and lighter brown |
| 18:55.59 | Juggie | same paint card :) |
| 18:56.21 | Juggie | i had to get rid of the CFL's in my bathroom vanity |
| 18:56.27 | Juggie | they did the same thing, made the paint look pink |
| 18:56.36 | Juggie | regular bulbs are fine |
| 19:01.26 | Juggie | look alright? |
| 19:03.53 | leifmadsen | yep, looks fine to me! |
| 19:26.40 | *** join/#asterisk-doc RobH (n=RobH@cpe-173-169-30-118.tampabay.res.rr.com) |
| 19:26.54 | leifmadsen | eliel: ping? |
| 19:27.06 | eliel | here |
| 19:27.16 | leifmadsen | I can't seem to figure out what I have wrong here.... |
| 19:27.17 | leifmadsen | doc/core-en_US.xml:3256: parser error : expected '>' |
| 19:27.17 | leifmadsen | </enumlist> |
| 19:27.17 | leifmadsen | <PROTECTED> |
| 19:27.23 | leifmadsen | you probably need to see the XML though |
| 19:27.30 | eliel | :-) |
| 19:27.36 | eliel | yes please |
| 19:27.48 | eliel | unless you have res_internetvision |
| 19:28.33 | eliel | leifmadsen: that is sometimes caused by an element not being properly closed like <enumlist><enumlist> <- missing / |
| 19:28.47 | leifmadsen | eliel: ya, that's what I was looking for, but can't see it |
| 19:28.54 | eliel | let me try |
| 19:29.19 | eliel | (the power of peer reviewing) |
| 19:30.34 | leifmadsen | http://pastebin.com/m2cf11c40 |
| 19:30.36 | leifmadsen | there you go |
| 19:31.00 | leifmadsen | I must have a typo somewhere |
| 19:32.37 | eliel | look at the <enum name="email"> |
| 19:32.47 | eliel | in MINIVMACCOUNT |
| 19:32.51 | eliel | it is not properly closed |
| 19:33.20 | leifmadsen | aha! |
| 19:33.24 | leifmadsen | too many lines :) |
| 19:33.24 | leifmadsen | thanks |
| 19:33.32 | eliel | ur welcome |
| 19:36.00 | leifmadsen | ok, one more done and ready for review now :) |
| 19:36.05 | leifmadsen | off to get ready to pick up the g/f! |
| 19:36.31 | eliel | nice |
| 19:36.43 | leifmadsen | then back to work! :) |
| 20:18.16 | *** join/#asterisk-doc telecos (n=sergio@210.167.219.87.dynamic.jazztel.es) |
| 20:51.28 | Juggie | leifmadsen: ping |
| 20:51.30 | Juggie | this makes me laugh. |
| 20:51.31 | Juggie | Bell makes travelling easy with access to Canada's largest 3G network1, as well as coverage in over 200 countries worldwide. Please see below for details on where and how. |
| 20:51.31 | Juggie | 1 Based on total square km of the 1xEV-DO network vs. Rogers HSPA coverage as of March 5, 2009. |
| 20:51.36 | Juggie | yessss... |
| 20:51.44 | Juggie | lets compare 1x EVDO to HSPA |
| 20:51.56 | Juggie | a fair comparison would be EVDO to EDGE |
| 20:53.27 | file | ...no :P |
| 20:53.48 | Juggie | well EVDO isnt even close to the speed of HSPA |
| 20:54.06 | file | it's still high speed |
| 20:54.42 | Juggie | i guess but HSPA can be up to 7.2 |
| 20:54.45 | Juggie | evdo is ~1 at best |
| 20:55.01 | file | EVDO rev A is theoretical at 3.1 if I remember right |
| 20:55.16 | file | real world of course depends |
| 20:55.30 | Juggie | you cant depend on much w/ bellus :) |
| 20:55.38 | Juggie | bell & telus are switching to gsm too |
| 20:56.34 | file | LTE, yes |
| 20:56.42 | Juggie | still gsm :) |
| 20:56.56 | Juggie | they are just peeved apple wont make a cdma iphone i guess :P |
| 20:57.19 | Juggie | rogers cleans up on roaming agreements |
| 20:57.30 | Juggie | you can bet anything the first area to be built up will be BC |
| 20:57.47 | Juggie | so that bell and tellus can try and get some contracts for the winter games |
| 21:35.51 | *** part/#asterisk-doc Khratos (n=khratos@190.166.103.254) |
