| 13:41.24 | *** join/#asterisk-doc newtonr (~newtonr@nat/digium/x-ftmqzgnrwhpaywxe) |
| 13:42.33 | leifmadsen | jsmith: ohai |
| 13:42.45 | leifmadsen | jsmith: what do you know about %if macro and string comparison in spec files? :) |
| 13:44.38 | jsmith | leifmadsen: Some... why? |
| 13:44.51 | jsmith | leifmadsen: Or, in other words, can you be more specific about what you're trying to do? |
| 13:45.24 | leifmadsen | well, I have called via mock a --define astversion 1.8.18.0 |
| 13:45.28 | leifmadsen | and I know it is defined |
| 13:45.34 | leifmadsen | however, I get a parse error on this: |
| 13:45.52 | leifmadsen | %if %{astversion} == "1.8.18.0" || %{astversion} == "1.8.14.1" |
| 13:45.53 | leifmadsen | <PROTECTED> |
| 13:46.03 | leifmadsen | I am now trying %if %{?astversion} == "... |
| 13:47.19 | leifmadsen | this is the best page I've found on conditionals, as the rest of the documentation I've found is pretty terrible, especially if you're talking string comparisons (not numeral comparisons with < or >= and the like): http://backreference.org/2011/09/17/some-tips-on-rpm-conditional-macros/ |
| 13:47.38 | seanbright | what is the parse error? |
| 13:48.37 | leifmadsen | shoot... I tried a new build so I don't have the log, but it complains about parse error, returns -1 if I remember correctly |
| 13:50.05 | seanbright | have you tried quoting %{astversion}? |
| 13:50.12 | leifmadsen | that doesn't work like you think it does :) |
| 13:50.14 | leifmadsen | see link above |
| 13:50.17 | seanbright | yeah... |
| 13:50.42 | seanbright | i'll let jsmith help, i'm just grasping at straws |
| 14:00.31 | jsmith | leifmadsen: That link seanbright posted explains it a lot better than I can |
| 14:00.32 | jsmith | leifmadsen: ... but in short, think of string comparisons, just like you would with Asterisk dialplan expressions... |
| 14:00.53 | jsmith | leifmadsen: $[x${FOO} != x], etc. |
| 14:01.08 | seanbright | jsmith: you get any snow? |
| 14:01.14 | leifmadsen | yea, that's generally what I figured as well... I guess quotes around the 1.8.18.0 is unnecessary? |
| 14:01.35 | leifmadsen | %if %{?astversion} == 1.8.18.0 ? |
| 14:02.38 | jsmith | seanbright: four to five inches... you? |
| 14:03.04 | seanbright | about the same |
| 14:03.12 | seanbright | i'm the only idiot that drove to work though |
| 14:03.52 | seanbright | still coming down a bit |
| 14:04.07 | jsmith | seanbright: Lucky you... |
| 14:04.50 | jsmith | leifmadsen: I'd also suggest that you use conditionals to define other flags |
| 14:04.57 | jsmith | leifmadsen: such as: |
| 14:06.09 | jsmith | <PROTECTED> |
| 14:06.09 | jsmith | %define b5x 1 |
| 14:06.09 | jsmith | %undefine b6x |
| 14:06.09 | jsmith | %endif |
| 14:06.09 | jsmith | That way, it's a whole lot easier to just say %{?b5x} |
| 14:18.36 | leifmadsen | jsmith: oh awesome it's basically an issue with rpm itself |
| 14:18.42 | leifmadsen | https://bugzilla.redhat.com/show_bug.cgi?id=456103 |
| 14:18.50 | leifmadsen | need to figure out another way to work around it |
| 14:19.37 | leifmadsen | the weirdest part though is that astversion IS defined |
| 14:21.54 | leifmadsen | maybe have a new work around |
| 14:22.10 | leifmadsen | %if 0%{?astversion} <= 018180 |
| 14:33.11 | jsmith | Or you could break out major, minor, revision values separately |
| 14:33.42 | jsmith | %if 0{?astsupermajor} == 1 |
| 14:34.16 | jsmith | <PROTECTED> |
| 14:34.32 | jsmith | <PROTECTED> |
| 14:34.34 | leifmadsen | I read that nested if's don't expand |
| 14:34.34 | jsmith | etc, |
| 14:34.48 | jsmith | Oh? I thought they do |
| 14:36.53 | jsmith | I guess you get to play games with: %if 0%{?astsupermajor} == 1 && 0%{?astmajor} == 8 && 0%{?astminor} == 18 |
| 14:38.57 | jsmith | I'm seeing several examples of nested %ifs |
| 16:50.05 | leifmadsen | jsmith: so I found a "work around" |
| 16:50.09 | leifmadsen | it's not pretty but it works |
| 16:50.46 | leifmadsen | %if 0%{?ver_18141:1} || 0%{?ver_18180:1} |
| 16:51.03 | leifmadsen | <PROTECTED> |
| 16:51.06 | leifmadsen | then from my script |
| 16:51.06 | leifmadsen | <PROTECTED> |
| 16:51.07 | leifmadsen | 216 CMD="mock --quiet --root epel-6-$BASEARCH --define 'astversion $AST_VERSION' --define 'ver_${AST_VERSION//./} 1' $EXTRA_DEFINES --buildsrpm --configdir $LOCALMOCKCFGS --spec $START/trunk/rpmbuild/SPECS/$SPEC --sources $START/trunk⇉ |
| 16:51.39 | leifmadsen | this is what I get for creating a single spec file to support multiple versions of an RPM |
| 17:02.55 | jsmith | Right... |
| 17:02.55 | jsmith | Looks good to me :-) |
| 18:28.02 | leifmadsen | lol |
| 18:28.10 | leifmadsen | QA: Works for me! |
| 18:28.22 | leifmadsen | really need to find some time to do some koji stuff I think |
| 18:28.41 | leifmadsen | that won't get on my radar at all for a while. It falls on the infrastructure team, and it won't fall on them either. |
| 18:35.03 | jsmith | :-/ |
| 18:35.06 | jsmith | Koji rocks :-) |
| 19:40.50 | leifmadsen | so I've heard |