| 00:48.49 | *** join/#brlcad zero_level (~zero_leve@117.205.25.46) |
| 01:05.58 | *** join/#brlcad zero_level (~zero_leve@117.205.17.76) |
| 07:10.43 | *** join/#brlcad ibot (~ibot@rikers.org) |
| 07:10.43 | *** topic/#brlcad is BRL-CAD || http://brlcad.org || logs: http://ibot.rikers.org/%23brlcad/ || GSoC 2013! http://brlcad.org/wiki/Google_Summer_of_Code |
| 07:16.51 | *** join/#brlcad zero_level (~zero_leve@117.205.18.247) |
| 08:26.37 | *** join/#brlcad zero_level (~zero_leve@117.212.26.157) |
| 08:57.58 | *** join/#brlcad kesha (~kesha@49.249.18.210) |
| 09:16.20 | *** join/#brlcad Izak (29cac660@gateway/web/freenode/ip.41.202.198.96) |
| 09:24.17 | *** join/#brlcad kesha_ (~kesha@49.249.18.15) |
| 09:31.16 | *** join/#brlcad kesha__ (~kesha@49.249.18.15) |
| 09:31.29 | Izak | Kesha how far? |
| 09:31.46 | Izak | have you obtained commit acces ? |
| 09:34.19 | *** join/#brlcad kesha_ (~kesha@49.249.199.245) |
| 09:35.47 | *** join/#brlcad kesha_ (~kesha@49.249.199.245) |
| 09:38.18 | Izak | In what format should patches be sub,itted? |
| 09:38.32 | Izak | su,itted = submitted |
| 09:54.24 | *** join/#brlcad kesha_ (~kesha@49.249.199.245) |
| 11:16.38 | *** join/#brlcad zero_level (~zero_leve@117.212.31.234) |
| 11:47.42 | *** join/#brlcad kesha_ (~kesha@49.249.199.245) |
| 12:01.23 | *** join/#brlcad zero_level (~zero_leve@117.212.24.27) |
| 12:27.15 | *** join/#brlcad zero_level (~zero_leve@117.212.28.236) |
| 12:37.53 | Notify | 03BRL-CAD:phoenixyjll * 55805 (brlcad/trunk/src/libbrep/intersect.cpp brlcad/trunk/src/libbrep/opennurbs_ext.cpp): It seems that we inappropriately prepTrims when m_removeTrimmed is false, causing get_closest_point() to fail. Someone who wrote this code needs to check whether this change is correct. |
| 12:42.17 | Notify | 03BRL-CAD Wiki:Phoenix * 5446 /wiki/User:Phoenix/GSoc2013/Reports: /* Week 1 */ |
| 12:45.15 | Notify | 03BRL-CAD Wiki:Phoenix * 5447 /wiki/User:Phoenix/GSoc2013/Reports: /* Week 1 */ |
| 12:46.32 | Notify | 03BRL-CAD Wiki:Phoenix * 5448 /wiki/User:Phoenix/GSoc2013/Reports: /* Week 1 */ |
| 12:57.03 | Notify | 03BRL-CAD Wiki:Phoenix * 5449 /wiki/User:Phoenix/GSoc2013/Reports: /* Week 1 */ |
| 12:58.14 | Notify | 03BRL-CAD:phoenixyjll * 55806 brlcad/trunk/src/libbrep/intersect.cpp: Use a smaller depth for PSI to improve performance. |
| 13:00.25 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 13:16.34 | *** join/#brlcad zero_level (~zero_leve@117.205.25.64) |
| 13:40.39 | *** join/#brlcad kesha_ (~kesha@49.249.199.245) |
| 14:15.46 | *** join/#brlcad zero_level (~zero_leve@117.205.21.173) |
| 14:32.05 | zero_level | hi ``Erik |
| 14:55.50 | ``Erik | yargh, sorry, had a briefing this morning, just now getting to look at the patch. |
| 15:23.40 | *** join/#brlcad zero_level (~zero_leve@117.205.22.119) |
| 15:32.58 | zero_level | hi: ``Erik posted the updated patch in the same thread. |
| 15:33.16 | zero_level | see patch 188 |
| 15:54.54 | *** join/#brlcad kesha_ (~kesha@49.249.18.225) |
| 16:09.25 | *** join/#brlcad kesha_ (~kesha@49.249.191.151) |
| 16:19.31 | *** join/#brlcad kesha_ (~kesha@49.202.239.120) |
| 16:34.54 | *** join/#brlcad kesha__ (~kesha@49.249.9.42) |
| 16:59.57 | *** join/#brlcad kesha (~kesha@49.249.18.13) |
| 17:03.45 | *** part/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 17:07.31 | *** join/#brlcad kesha (~kesha@49.249.200.90) |
| 17:15.21 | *** join/#brlcad kesha_ (~kesha@49.202.239.218) |
| 17:25.46 | *** join/#brlcad zero_level (~zero_leve@117.205.28.87) |
| 17:34.16 | *** join/#brlcad kesha__ (~kesha@49.249.1.90) |
| 17:56.18 | *** join/#brlcad zero_level (~zero_leve@117.205.23.92) |
| 18:06.02 | Notify | 03BRL-CAD Wiki:Harman052 * 5450 /wiki/User:Harman052/GSoc2013/Logs: |
| 18:24.31 | *** join/#brlcad kesha__ (~kesha@49.249.1.90) |
| 18:39.44 | *** join/#brlcad cstirk (~quassel@96.255.19.39) |
| 19:57.16 | Notify | 03BRL-CAD:starseeker * 55807 brlcad/trunk/src/librt/primitives/bot/bot_wireframe.cpp: This is less pretty than using edges (doesn't cull all the lines we would want to cull) but should be faster - if this can't be made 'fast enough' adding more processing on isn't workable either. |
| 19:59.28 | Notify | 03BRL-CAD Wiki:41.92.210.20 * 5451 /wiki/User:Izak/GSOC_2013_logs: /* From June 17th to June 21 */ |
| 19:59.40 | zero_level | hey ``Erik : |
| 20:08.16 | Notify | 03BRL-CAD Wiki:Level zero * 5452 /wiki/Google_Summer_of_Code/2013: /* added zero_level Information */ |
| 20:21.07 | Notify | 03BRL-CAD Wiki:NyahCh3ck20 * 5453 /wiki/User:NyahCh3ck20/GSoc2013/Coding_Repor: /* Coding Log Report for GSoc 2013 */ |
| 20:23.45 | Notify | 03BRL-CAD Wiki:Tbrowder * 5454 /wiki/Google_Summer_of_Code/2013: /* Getting started */ |
| 20:26.56 | Notify | 03BRL-CAD Wiki:Tbrowder * 5455 /wiki/Google_Summer_of_Code/2013: /* Getting started */ |
| 20:28.29 | Notify | 03BRL-CAD Wiki:Tbrowder * 5456 /wiki/Google_Summer_of_Code/2013: /* Getting started */ |
| 20:37.19 | *** join/#brlcad mpictor (~mark@2601:d:b280:9:d63d:7eff:fe2d:2505) |
| 20:39.09 | Notify | 03BRL-CAD Wiki:NyahCh3ck20 * 5457 /wiki/Google_Summer_of_Code/2013: /* Accepted Projects */ |
| 20:59.54 | *** join/#brlcad zero_level (~zero_leve@117.205.20.130) |
| 21:51.10 | brlcad | zero_level: finishing your statement before hitting the enter key will tend to get you a response |
| 21:51.53 | brlcad | don't just mention someone's name hoping for them to respond if they're here -- just say what you would have said if they said hi/hey/whatever back |
| 22:09.25 | zero_level | hey ``Erik: in the mean time you review my updated patch (patch num 188) i am working on icv_rect function from group 1(Cropping). |
| 22:12.40 | zero_level | brlcad: i need your help here. If I have completed work on a patch (say icv_convert). And now if work on a completely new work sat icv_rect do i remove the previous files from my working copy. or just add it in the new patch ? |
| 22:12.57 | zero_level | provided the previous patch is itself large. |
| 22:16.13 | brlcad | zero_level: state in any subsequent patch submissions if other patches must be applied first, that way they are reviewed and committed in order |
| 22:17.23 | brlcad | but keep pinging on folks to help review them and keep checking them to make sure they have no issues and will apply cleanly |
| 22:19.05 | zero_level | brlcad: pinging on folks? on IRC? |
| 22:49.14 | *** join/#brlcad zero_level (~zero_leve@117.205.25.76) |
| 23:23.56 | zero_level | brlcad, ``Erik posted a new patch for icv_rect function |
| 23:24.15 | zero_level | patch num #196 https://sourceforge.net/p/brlcad/patches/196/ |
| 23:31.59 | ``Erik | zero_level: sorry I didn't get a chance to really focus on the convert patch, had some work issues come up. I was happy to see a pix load functions (I think that by itself is easily worthy of being a patch by itself), still not keen on the 'size' struct, and it seems like the convert function itself is superfluous |
| 23:32.54 | ``Erik | I've not had a chance to really look at the 3to1 function... as a general observation: the patch is too big and tries to do way too much |
| 23:35.39 | ``Erik | if you were to, say, split the pix load function out and call that a patch by itself, that would probably be pretty quick to review and either provide solid feedback or apply. Strive for atomic concise patches :) |
| 23:38.27 | ``Erik | ok, see, crop.patch is 554 lines, I just don't have the time right now to look at that much... I have time for a patch with maybe 20 lines... the bwhisteq patch was excellent in size and scope, the only reason it wasn't an easy accept was that it exposed a vague and unexpected behavior that'd been lurking in the code since 1986, and I'm not keen on letting a bug or incorrect behavior survive |
| 23:38.58 | ``Erik | (also; it had a trailing whitespace, but that's a minor issue) |
| 23:42.26 | zero_level | ``Erik this patch has a long history |
| 23:42.47 | zero_level | 171 176 178 |
| 23:44.23 | zero_level | so i will create pix load as a patch |
| 23:45.48 | zero_level | about the superfluosness of convert patch ! that is just a representation of the uses of current load/save utilities |
| 23:46.34 | zero_level | ``Erik also 3to1 is a conversion of the utility pix-bw |
| 23:46.50 | zero_level | and 1to3 is conversion of the utility bw-pix |
| 23:47.54 | zero_level | these will be helfpful for conversion between images of different depth |
| 23:54.53 | ``Erik | yeah, I caught that they were bw<->pix helpers, I just haven't had a hcance to dig into them |
| 23:55.33 | ``Erik | I've written up some documentation and a function prototype for loading ... give me a minute to verify it compiles ok |
| 23:56.15 | ``Erik | (btw, writing doxygen comments for icv functions could also be a good patch to help towards a commit bit) |
| 23:58.36 | zero_level | ok, ``Erik are u compiling patch 188 or 196 ? |
| 23:58.49 | Notify | 03BRL-CAD:erikgreenwald * 55808 (brlcad/trunk/include/icv.h brlcad/trunk/src/libicv/fileformat.c): stub out an icv_image_load() prototype with some docs |
| 23:59.01 | ``Erik | compiling 55808, actually... :) |
| 23:59.30 | ``Erik | 188 and 196 are too big |