| 00:24.49 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 00:30.22 | Constitution | anyone know of a server currently up that has a map with drawinfo stuff? |
| 00:43.23 | *** join/#bzflag nitroxis (n@nxs.re) |
| 00:51.21 | *** join/#bzflag JBdiGriz (~dbw@108-197-33-160.lightspeed.sndgca.sbcglobal.net) |
| 01:11.20 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |
| 01:15.39 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 01:48.04 | *** join/#bzflag Pimpi (~frank@pD9E1044A.dip0.t-ipconnect.de) |
| 02:25.20 | alezakos | Constitution: helit.org:5154 has an airplane that flies around the playable area of the map |
| 02:26.56 | Constitution | okay, thanks |
| 02:28.16 | *** join/#bzflag Constitution (~josh@bzflag/developer/Constitution) |
| 02:57.34 | *** join/#bzflag miss_america (4408ab6f@gateway/web/freenode/ip.68.8.171.111) |
| 02:57.45 | miss_america | heyyyyy I made it |
| 03:00.00 | BulletCatcher | Is Miss American Pi your call sign? |
| 03:00.26 | miss_america | yeah. I'm trying to connect with my phone. |
| 03:00.39 | BulletCatcher | You have succeeded. |
| 03:00.40 | BulletCatcher | Welcome. |
| 03:00.53 | miss_america | well, this is on the comp. (: but thanks. |
| 03:04.47 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 03:19.55 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |
| 03:20.30 | *** join/#bzflag Delusional_ (~Delusiona@unaffiliated/delusional) |
| 03:43.20 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 04:00.20 | *** join/#bzflag miss_america (4408ab6f@gateway/web/freenode/ip.68.8.171.111) |
| 05:21.39 | *** join/#bzflag Cobra_Fast_ (~coprah@wtwrp.de) |
| 05:23.31 | *** join/#bzflag brad (~brad@2001:41d0:a:14be::bad) |
| 05:23.32 | *** join/#bzflag brad (~brad@unaffiliated/brad) |
| 05:54.08 | *** join/#bzflag Constitution (47d1af0d@bzflag/developer/Constitution) |
| 05:58.33 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 06:44.17 | *** join/#bzflag infobot (ibot@69-58-76-73.ut.vivintwireless.net) |
| 06:44.17 | *** topic/#bzflag is http://BZFlag.org || https://www.ohloh.net/p/bzflag || http://wiki.BZFlag.org/Getting_Help || Channel Logs: http://ibot.rikers.org/%23bzflag/ || 2.4.2 Current version https://goo.gl/ZaiNzX |
| 06:44.17 | *** mode/#bzflag [+v infobot] by ChanServ |
| 06:48.50 | *** join/#bzflag dngor_ (~abuse@c-67-172-78-202.hsd1.fl.comcast.net) |
| 07:29.41 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 08:05.42 | *** join/#bzflag Shuist (~Shuist@ppp203-122-213-220.static.internode.on.net) |
| 10:40.20 | *** join/#bzflag BZnotify (~BZnotify@192.30.252.41) |
| 10:40.20 | BZnotify | [13bzflag] 15blast007 pushed 2 new commits to 062.4: 02http://git.io/vmr3t |
| 10:40.20 | BZnotify | 13bzflag/062.4 14d0c2c8d 15Scott Wichser: No need to convert filenames to c-style strings. |
| 10:40.20 | BZnotify | 13bzflag/062.4 147f24c67 15Scott Wichser: Remove some remnants of the old local password database. |
| 10:40.20 | *** part/#bzflag BZnotify (~BZnotify@192.30.252.41) |
| 11:02.44 | blast007 | hmm https://github.com/BZFlag-Dev/bzflag/blob/2.4/plugins/webStats/webStats.cpp#L492 (duplicate comparison) |
| 11:22.34 | *** join/#bzflag BZnotify (~BZnotify@192.30.252.34) |
| 11:22.34 | BZnotify | [13bzflag] 15blast007 pushed 1 new commit to 062.4: 02http://git.io/vmrET |
| 11:22.34 | BZnotify | 13bzflag/062.4 147f4b6fe 15Scott Wichser: Unsigned variables won't be below zero. |
| 11:22.34 | *** part/#bzflag BZnotify (~BZnotify@192.30.252.34) |
| 12:34.04 | *** join/#bzflag Constitution (~josh@bzflag/developer/Constitution) |
| 12:48.42 | blast007 | hmm, another duplicate comparison in plugins/rabbitTimer/rabbitTimer.cpp on lines 73 and 104 |
| 13:30.18 | *** part/#bzflag jelly (jelly@pdpc/supporter/active/jelly) |
| 15:37.29 | BulletCatcher | Regarding validating the CIDR value, atoi() returns an int so it would be better to test that int range before stuffing the value into the unsigned char. |
| 15:38.13 | BulletCatcher | I'm happy to make that happen unless it is already part of your plan. |
| 15:57.42 | blast007 | feel free |
| 15:58.03 | BulletCatcher | k |
| 15:58.17 | blast007 | I've been going through the output of 'cppcheck --enable=all' and cleaning some stuff up |
| 15:59.02 | BulletCatcher | cool |
| 15:59.39 | BulletCatcher | I was wondering how you found those duplicate comparisons. |
| 16:17.05 | blast007 | didn't get it pushed before I left, but I was working on cleaning up some var.size() == 0 (and similar) checks to use var.empty() instead |
| 16:29.45 | blast007 | ran another static code analysis, but that one is rather noisy (most of which would be resolved by changing everything to std::string) |
| 16:38.47 | BulletCatcher | We already have issue #4 about converting character arrays to std::string. |
| 18:30.34 | blast007 | yup :) |
| 18:51.27 | blast007 | how goes the isnan() stuff? |
| 19:12.11 | BulletCatcher | Checking for NaN would be fairly straightforward, but I have taken the more difficult path of doing range checks on the floats in selected messages. |
| 19:12.17 | BulletCatcher | The tests are fairly refined from live testing, but for the 2.4.4 release I am willing to be especially conservative and just do loose tests such as (fabsf(val) <= MAXFLOAT). |
| 19:12.20 | BulletCatcher | We should do the tests in both the server and client (to protect the client from rogue game servers), and I have a subroutine both can use needs a home under either src/common or src/game. |
| 19:13.32 | BulletCatcher | My client mods are currently in Player.cxx and playing.cxx. |
| 19:15.22 | BulletCatcher | To avoid alarming players, I think the client should quietly ignore received messages with bogus values. |
| 19:15.40 | BulletCatcher | The server should kick players that send bogus values. |
| 19:17.39 | blast007 | what does the MAXFLOAT comparison do? can the value that comes out of fabsf() be greater than MAXFLOAT without being NaN? |
| 19:18.57 | BulletCatcher | MAXFLOAT is just a .h macro constant that should be the largest value a float can hold. |
| 19:19.49 | blast007 | but not guaranteed? |
| 19:19.54 | BulletCatcher | (NaN <= MAXFLOAT) should always be false. |
| 19:20.22 | BulletCatcher | MAXFLOAT is defined as such. An implementation could be broken. |
| 19:20.33 | blast007 | k |
| 19:21.41 | blast007 | is that something we should be testing for once at runtime, or is it not something we could reliable test for? |
| 19:22.41 | blast007 | thought being that if an implementation is broken, should it be running the game at all |
| 19:23.30 | BulletCatcher | Bailing out if (!(NaN <= MAXFLOAT)) is true would be a reasonable thing to do. |
| 19:24.16 | blast007 | yeah |
| 19:25.14 | BulletCatcher | There are many such tests, e.g., (0 < 1). :-) |
| 19:25.52 | blast007 | would that eliminate the need to test for fabsf(val) <= MAXFLOAT all over? or is that just one case that might fail? |
| 19:26.51 | blast007 | (or was that just placeholder code for when we have reasonable limits for later?) |
| 19:27.06 | BulletCatcher | My suggestion is to use something like (fabsf(val) <= MAXFLOAT) instead of (!isnan(val)), with the idea that we would later change MAXFLOAT to a smaller value. |
| 19:27.24 | blast007 | k, that makes sense |
| 19:27.56 | BulletCatcher | For instance, we want x and y tank positions to always be within the map boundary. |
| 19:28.25 | BulletCatcher | IIRC, we already test for that specific case. |
| 20:27.46 | blast007 | with a bit too much fudge room |
| 20:31.06 | BulletCatcher | mmmm, fudge! |
| 20:35.01 | BulletCatcher | In 2.6 we could have the client check to be sure that it always sends a tank position that is within the map boundary, then the server could rigorously enforce the same restriction with no fudge factor. |
| 20:56.24 | *** join/#bzflag bizarrefish (~lee@86.ip-5-196-225.eu) |
| 21:02.52 | *** join/#bzflag BZnotify (~BZnotify@192.30.252.45) |
| 21:02.52 | BZnotify | [13bzflag] 15JMakey pushed 3 new commits to 062.4: 02http://git.io/vmind |
| 21:02.52 | BZnotify | 13bzflag/062.4 14f85d02b 15Jeff Makey: Check the atoi() return value range as the integer it is before stuffing it into an unsigned char. |
| 21:02.52 | BZnotify | 13bzflag/062.4 1476709aa 15Jeff Makey: Compile modeltool with the compiler options generated by configure. |
| 21:02.52 | BZnotify | 13bzflag/062.4 14d4eaccd 15Jeff Makey: In bzwtransform don't bother to include common.h, but do include string.h.... |
| 21:02.52 | *** part/#bzflag BZnotify (~BZnotify@192.30.252.45) |
| 22:45.02 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 22:48.24 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 22:52.32 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 22:55.20 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 22:58.20 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:00.52 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:02.59 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:05.48 | *** join/#bzflag khonkhortisan2 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:08.55 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:11.14 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:13.00 | *** join/#bzflag spldart (~spldart@172.56.15.164) |
| 23:13.00 | *** join/#bzflag spldart (~spldart@bzflag/contributor/spldart) |
| 23:13.00 | *** mode/#bzflag [+v spldart] by ChanServ |
| 23:13.50 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:16.34 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:20.18 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:23.20 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:26.47 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:29.51 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:32.37 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:35.05 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |
| 23:36.09 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:39.20 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:42.01 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:44.20 | *** join/#bzflag khonkhortisan (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:47.19 | *** join/#bzflag khonkhortisan1 (~Kyle@c-24-16-240-200.hsd1.wa.comcast.net) |
| 23:57.38 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |