| 00:45.54 | allejo | JeffM: plugins will only look at API functions which is why the overloaded bz_addURLJob() is needed, right? Do I have to be careful when changing internal functions? e.g. the addJob() function that's called bz_addUrlJob() |
| 00:46.47 | JeffM | They only know the functions they were compiled with |
| 00:47.28 | JeffM | The internal can be whatever |
| 00:47.41 | JeffM | Since you know its built with bzflag |
| 00:47.52 | blast007 | one big purpose of an API is so that you can have a stable outside accessible interface to changing internal code |
| 00:48.08 | JeffM | Yeah. What he said |
| 00:49.05 | allejo | sweet just wanted to confirm |
| 01:47.36 | *** join/#bzflag BZnotify (~BZnotify@192.30.252.40) |
| 01:47.36 | BZnotify | [13bzflag] 15allejo pushed 1 new commit to 062.4: 02https://git.io/v7WIq |
| 01:47.36 | BZnotify | 13bzflag/062.4 1473271a8 15allejo: bz_addURLJob() now supports setting HTTP headers... |
| 01:47.36 | *** part/#bzflag BZnotify (~BZnotify@192.30.252.40) |
| 02:07.38 | JeffM | need to set no-cache? |
| 02:10.40 | *** join/#bzflag nadir (uid134094@gateway/web/irccloud.com/x-yiwxjnxcmzbjyfrd) |
| 02:45.00 | the_map | ~allejo++ |
| 02:46.04 | allejo | JeffM: you mean the Cache-Control header? |
| 02:46.10 | JeffM | yeah |
| 02:46.58 | allejo | should it be a default setting or up to the plug-in dev? |
| 02:47.05 | JeffM | up to the dev |
| 02:48.49 | allejo | that's what I was leaning towards, so you'd just add it to the API string list |
| 04:12.14 | *** join/#bzflag deep-book-gk_ (~1wm_su@159.122.132.44) |
| 04:15.08 | *** part/#bzflag deep-book-gk_ (~1wm_su@159.122.132.44) |
| 04:42.28 | the_map | ~alezakos++ |
| 05:41.21 | allejo | JeffM: what's the use of *token in bz_URLHandler_V2? since you added it |
| 05:41.44 | JeffM | for your plugin to pass in something that gets passed back, so you can know what job it is |
| 05:41.51 | JeffM | if you have multiple jobs going at the same time |
| 05:42.54 | allejo | ah thank you |
| 11:35.35 | blast007 | Cache-Control is a header the web server sets, no? |
| 13:11.53 | *** join/#bzflag FastLizard4 (fastlizard@wikipedia/pdpc.active.FastLizard4) |
| 14:07.19 | *** join/#bzflag FastLizard4 (fastlizard@wikipedia/pdpc.active.FastLizard4) |
| 14:52.47 | *** join/#bzflag Dracos85 (~dracos85@67-60-40-148.cpe.cableone.net) |
| 14:56.45 | JeffM | The spec says it can be set anywhere along the request /response chain |
| 15:59.41 | blast007 | I don't know how much of an impact that will really have though |
| 16:00.13 | blast007 | are you expecting that there's a caching proxy between bzfs and the web server that will respect the Cache-Control header? |
| 16:01.00 | blast007 | "By default, Varnish does not care about the Cache-Control request header. If you want to let users update the cache via a force refresh you need to do it yourself." |
| 16:37.50 | *** part/#bzflag BulletCatcher (~bc@bzflag/developer/BulletCatcher) |
| 17:22.55 | *** join/#bzflag BulletCatcher (~bc@bzflag/developer/BulletCatcher) |
| 17:22.55 | *** mode/#bzflag [+v BulletCatcher] by ChanServ |
| 17:34.10 | brlcad | kierra: I miss you too :) |
| 17:37.47 | *** join/#bzflag Dracos85 (~dracos85@67-60-40-148.cpe.cableone.net) |
| 18:26.01 | JeffM | Sure, headers are just guidelines, any can be ignored :) |
| 18:26.53 | JeffM | But I do believe that the client sets no cache on list requests, so it's reasonable that bzfs could need to as well |
| 18:34.38 | blast007 | CURLOPT_HTTPHEADER is not in our code until the above commit |
| 18:35.54 | *** join/#bzflag goosebumperiono (uid242129@gateway/web/irccloud.com/x-eeomwpmhdiruitez) |
| 18:37.01 | blast007 | "Cache-Control: no-cache" is only part of our HTTP server in bzfs |
| 18:46.07 | kierra | You dear, sweet man, brlcad |
| 18:47.19 | *** join/#bzflag Zehra (~Zehra@unaffiliated/zehra) |
| 18:48.01 | blast007 | neat, I can crash QT Creator by just telling it to run bzflag :P |
| 20:21.20 | *** join/#bzflag Notify (~notify@104.225.5.10) |
| 23:51.05 | *** join/#bzflag bertman (~bert@unaffiliated/bertman) |
| 23:56.04 | *** join/#bzflag Notify (~notify@104.225.5.10) |
| 23:58.24 | *** join/#bzflag deep-book-gk_ (~1wm_su@177.47.27.242) |
| 23:58.58 | *** part/#bzflag deep-book-gk_ (~1wm_su@177.47.27.242) |