| 05:03.40 | *** join/#bzflag Kaelten (~Kaelten@li208-254.members.linode.com) |
| 05:03.40 | *** join/#bzflag Kaelten (~Kaelten@WoWUIDev/WoWAce/WoWIFA/CurseStaff/kaelten) |
| 05:04.22 | *** join/#bzflag blast007 (~blast007@bzflag/developer/Blast) |
| 05:04.42 | *** join/#bzflag McSpider (~McSpider@45.33.118.178) |
| 07:28.43 | *** join/#bzflag BZnotify (~BZnotify@192.30.252.41) |
| 07:28.43 | BZnotify | [13bzflag] 15allejo opened pull request #93: Allow API to trigger CTF capture event (062.4...06feature/api-ctfs) 02https://git.io/vFTfI |
| 07:28.43 | *** part/#bzflag BZnotify (~BZnotify@192.30.252.41) |
| 07:28.57 | allejo | can I get a second pair of eyes on that PR ^ |
| 08:11.24 | *** join/#bzflag L4m3r (~l4m3r@bzflag/developer/L4m3r) |
| 08:11.24 | *** mode/#bzflag [+v L4m3r] by ChanServ |
| 08:38.30 | blast007 | gets Clippy |
| 08:40.05 | blast007 | "It looks like you're writing an API addition. Would you like help with that?" |
| 08:49.44 | allejo | waits for Clippy to give me options |
| 11:27.35 | *** join/#bzflag Swant (swant@freenode/staff/ikea) |
| 11:49.58 | the_map | Save API Changes? [No] [Quit] |
| 16:21.04 | macsforme | the return value is supposed to indicate success or failure? |
| 17:38.55 | allejo | macsforme, yea |
| 18:52.13 | blast007 | allejo: I didn't look to see what we do for other functions, but the order/quantity of teams in TeamColor enum isn't the same as bz_eTeamType |
| 18:52.39 | blast007 | for the main four CTF colors, it matches up, but after that point it differs |
| 18:55.14 | blast007 | not sure if it really matters for this instance, but maybe there should be a sanity check for the teams inside the API function as well? |
| 18:56.21 | blast007 | maybe some else know what happens if you cast one enum type to another and the value goes outside the range of values for the one you're casting to |
| 19:29.36 | allejo | the captureFlag function in bzfs exits our when its a team not between red and purple, however I forgot to add a check for the new parameter I added |
| 19:30.26 | allejo | so I'll add that as well |
| 19:54.38 | blast007 | https://www.securecoding.cert.org/confluence/display/cplusplus/INT50-CPP.+Do+not+cast+to+an+out-of-range+enumeration+value |
| 19:56.25 | blast007 | the examples there are casting an int to an enum, so I don't know if that applies here |
| 20:43.46 | kierra | ~blast007++ |
| 20:44.43 | allejo | blast007: made use of convertTeam() which is what seems like the rest of the API does |
| 23:01.52 | *** join/#bzflag bertman (~bert@unaffiliated/bertman) |