| 00:08.22 | *** join/#bzflag [Gort] (~gort@unaffiliated/gort/x-9231432) |
| 01:21.24 | *** join/#bzflag infobot (ibot@rikers.org) |
| 01:21.24 | *** topic/#bzflag is https://BZFlag.org || http://ohloh.net/p/bzflag || https://bzflag.org/help || Channel Logs: http://infobot.rikers.org/%23bzflag/ || 2.4.12 released! https://forums.bzflag.org/viewtopic.php?f=62&t=19720 |
| 01:21.24 | *** mode/#bzflag [+v infobot] by ChanServ |
| 01:28.44 | *** join/#bzflag nadir (uid134094@gateway/web/irccloud.com/x-vhcvfiwhnwhsvvxj) |
| 02:51.58 | *** join/#bzflag the_map (the_map@gateway/vpn/privateinternetaccess/themap/x-38220869) |
| 11:45.51 | blast007 | in just a bit over 17 hours from now, my provider will be doing some maintenance on the host where the BZFlag web services reside. "A two-hour window is allocated, however the actual downtime should be much less." |
| 14:24.24 | *** join/#bzflag Guest065 (5287aea3@gateway/web/freenode/ip.82.135.174.163) |
| 18:14.21 | JeffM | allejo: you can make a plugin that will spawn everyone a specific distance from any object, even a flag :) |
| 18:15.39 | blast007 | easier option: just spawn them all directly on the flag |
| 18:16.02 | JeffM | that is still a specific distance, a distance of 0 :) |
| 18:33.50 | macsforme | I'm envisioning a plugin that will allow certain whitelisted chat messages from muted players using slash commands... for this purpose, it would be useful for the plugin to know which chat channel the slash command was sent to |
| 18:34.30 | JeffM | the source BZID isn't part of the event? |
| 18:34.35 | macsforme | it doesn't appear that the API supports this... would this feature have any other use cases that might justify a change to the API? or is there another way of doing this that I'm not seeing? |
| 18:34.46 | JeffM | let me look |
| 18:34.56 | JeffM | it's part of the message they send |
| 18:35.16 | JeffM | oh it's probalby stripped by the slash processor |
| 18:35.22 | macsforme | yes |
| 18:35.31 | blast007 | or whitelist the specific messages? |
| 18:35.45 | macsforme | that is also an option |
| 18:35.49 | JeffM | do you get the chat notification event before the slash processor? |
| 18:36.51 | macsforme | I don't think you would get a chat notification at all, would you? |
| 18:37.03 | JeffM | there are multiple events, I don' tknow what ones are sent |
| 18:37.11 | JeffM | I'm looking now |
| 18:38.04 | JeffM | nope. yeah I'd need an API change. |
| 18:40.32 | JeffM | You have the data you'd need in sendPlayerMessage. you would have to pass it to parseServerCommand |
| 18:40.49 | JeffM | then you could make bz_SlashCommandEventData_V2 with that data |
| 18:41.22 | JeffM | extending bz_CustomSlashCommandHandler would be harder. |
| 18:41.53 | JeffM | you'd have to make a bz_CustomSlashCommandHandler_V2, that has a SlashCommand that takes the arg |
| 18:42.17 | JeffM | then make a second bz_registerCustomSlashCommand that takes a V1 class |
| 18:42.40 | JeffM | and if someone registers a v1 class, you wrap it in a v2 class that that ignores the call. |
| 18:47.23 | macsforme | maybe it would be easier to just do them as chat messages instead of slash commands |
| 18:47.38 | JeffM | it's not a hard change, want me to make you a PR? |
| 18:48.04 | macsforme | would be great if you don't mind |
| 18:53.43 | JeffM | must remember how to program in C++ |
| 19:00.43 | JeffM | crap. I did the changes before I made a branch... how can I move my current working dir into a branch with these changes? |
| 19:01.07 | JeffM | oh look, new branch button |
| 19:02.11 | BulletCatcher | Create the desired branch at the desired commit, then force push the other branch back to where you want it. |
| 19:04.12 | *** join/#bzflag BZnotify (BZnotify@gateway/service/github.com/x-qhksmeiqtlfjbxqz) |
| 19:04.12 | BZnotify | [13bzflag] 15JeffM2501 opened pull request #96: Add features to send the slash commands the channel for the command (062.4...06slash_command_source_channel) 02https://git.io/vNWnq |
| 19:04.12 | *** part/#bzflag BZnotify (BZnotify@gateway/service/github.com/x-qhksmeiqtlfjbxqz) |
| 19:04.15 | JeffM | There ya go |
| 19:04.20 | JeffM | give that whirl |
| 19:04.41 | JeffM | and yes allejo I put the editor config in the msvc dir before I started, so it should have the same spacing :) |
| 19:08.54 | JeffM | macsforme: I did both items, added the argument to the event, and to the custom slash handler. |
| 19:09.03 | JeffM | both will now get a "source channel" ID |
| 19:09.35 | macsforme | okay thanks... I'm checking it out now |
| 19:11.10 | macsforme | just FYI the whitespace settings didn't work |
| 19:24.53 | JeffM | then what is the point of .editorconfig :) |
| 20:16.37 | JeffM | maybe I need to put it where the project is |
| 21:38.50 | *** join/#bzflag bboles (~quassel@2607:fcd0:100:8300:1c::a3ed) |
| 21:50.30 | *** join/#bzflag bboles (~quassel@2607:fcd0:100:8300:1c::a3ed) |
| 22:02.44 | *** join/#bzflag dcat (~dcat@c-98-244-106-246.hsd1.va.comcast.net) |
| 22:04.22 | *** join/#bzflag bertman (~bert@unaffiliated/bertman) |
| 22:10.16 | *** join/#bzflag bertman (~bert@unaffiliated/bertman) |
| 23:10.55 | *** join/#bzflag spldart (~spldart@bzflag/contributor/spldart) |
| 23:10.55 | *** mode/#bzflag [+v spldart] by ChanServ |
| 23:11.06 | *** join/#bzflag disco- (~disco@unaffiliated/disco-) |
| 23:24.40 | allejo | JeffM: as is, I don't think sourceChannel has any significant meaning to the API. i.e., 246 is obs chat, admin is 252, public is 254 |
| 23:25.11 | JeffM | Yeah I didnât know what to name it , itâs not a player id |
| 23:25.35 | JeffM | Map it to an enum maybe? |
| 23:25.51 | JeffM | Tho I guess you could /command to a user |
| 23:25.59 | JeffM | Thatâs valid protocol |
| 23:27.04 | allejo | I wouldn't say an enum because direct messaging a player is a valid sourceChannel |
| 23:27.28 | allejo | or, I guess just enums for the upper values? |
| 23:28.09 | JeffM | There are #defs for the upper numbers in the api right? |
| 23:29.11 | allejo | yea, we could add more #defines. however none of the sourceChannel values match the current #defines, if that's what you're asking |
| 23:30.03 | JeffM | bzflag is lame :) |
| 23:30.17 | allejo | :D |
| 23:30.30 | JeffM | well I'd add chat channel #defs |
| 23:30.46 | JeffM | and consider that bzflag basicly has a chat channel for every player + some extra ones |
| 23:31.01 | JeffM | every player, every team, everyone, and admin |
| 23:31.29 | JeffM | because there are team chat channels too |
| 23:32.15 | allejo | yea, each team channel has a unique number too |
| 23:32.49 | JeffM | so add some enums to the API so all the chat functions can use the same defs |
| 23:34.04 | JeffM | then bz_sendTextMessage (-1,AdminChat, ... ) would make sense too |
| 23:34.27 | JeffM | #defs or a custom enum, ether works |
| 23:35.08 | JeffM | bz_sendTextMessage (-1,ChannelIDs::Admin, ... ) looks good to me :) |
| 23:35.17 | allejo | would we have to worry about someone trying to cast a player ID into this new enum? |
| 23:36.09 | JeffM | in C++ they all get turned into int at run time |
| 23:36.12 | JeffM | so no big deal |
| 23:36.24 | JeffM | #defs would work beter with the current API |
| 23:36.48 | JeffM | enums would tecnically be cast to an int |
| 23:37.08 | JeffM | and you want people to still be able to send in PlayerIDs (aka ints) for direct messages |
| 23:37.30 | JeffM | so I'd add a few #defs for the teams and the special channels |
| 23:37.46 | JeffM | and say that player direct channels always match the player iD |
| 23:38.01 | allejo | e.g., BZ_ADMINCHAT |
| 23:38.03 | allejo | ? |
| 23:38.04 | JeffM | yeah |
| 23:38.15 | JeffM | admin chat, everyone, and one for each team. |
| 23:38.40 | JeffM | then you don't need the funcitons that take team colors anymore |
| 23:39.04 | JeffM | treat observer as a team |
| 23:39.07 | JeffM | because it is |
| 23:40.33 | allejo | sending to bz_eTeamType could be deprecated for 2.6 if the current API sticks around. cuz internally, it just sends it to those channel IDs after some maths with the enum |
| 23:40.42 | JeffM | yeah |
| 23:41.18 | JeffM | most of the stuff that's tied to playerID is going to break if you ever get cross server chat and friends lists anyway |
| 23:41.52 | JeffM | but the need for the #defs is unrelated to the pull request. |
| 23:42.14 | JeffM | it makes using that PR easier, but is not required for it to function. |
| 23:42.29 | JeffM | and the #defs affect a range of functions and events. |
| 23:43.18 | allejo | fair |
| 23:45.00 | allejo | also no idea why editorconfig didn't work |
| 23:51.08 | *** join/#bzflag nadir (uid134094@gateway/web/irccloud.com/x-zndxjxwpzhvrljqo) |
| 23:53.03 | JeffM | it's a codebase that was designed for being viewed in a tiny terminal window, it just can't accept anything from a modern editor ;) |
| 23:54.28 | JeffM | maybe making it as unreadable as possible was a security feature when it was closed source. |
| 23:54.48 | allejo | lol |
| 23:56.38 | allejo | or of course, i committed the editorconfig to use tabs instead of spaces. that's a possibility too... |
| 23:57.14 | JeffM | tabs 4 LIFE ! |
| 23:57.38 | spldart | <PROTECTED> |
| 23:58.21 | allejo | also, is V1MappingHandler an apt name? should it be renamed to be some more descriptive that it's slash command handler v1? |
| 23:58.32 | JeffM | sure |
| 23:58.38 | JeffM | whatever floats your boat |
| 23:59.18 | JeffM | V1SlashCommandWrapers is the most descriptive |
| 23:59.35 | JeffM | because eventualy you'll have V2SlashCommandWrapers :) |