| 01:19.28 | *** join/#bzflag infobot (ibot@rikers.org) |
| 01:19.28 | *** topic/#bzflag is https://BZFlag.org || http://ohloh.net/p/bzflag || https://bzflag.org/help || Channel Logs: http://infobot.rikers.org/%23bzflag/ || 2.4.12 released! https://forums.bzflag.org/viewtopic.php?f=62&t=19720 |
| 01:19.28 | *** mode/#bzflag [+v infobot] by ChanServ |
| 05:40.44 | *** join/#bzflag nadir (uid134094@gateway/web/irccloud.com/x-jgzlsqwudkhxiirp) |
| 08:00.58 | *** join/#bzflag BZnotify (BZnotify@gateway/service/github.com/x-yvnexwzayxfhmbvp) |
| 08:00.58 | BZnotify | [13bzflag] 15allejo opened pull request #99: [WIP] Fix World Weapon API and functionality (062.4...06feature/ww-api) 02https://git.io/vAVKc |
| 08:00.58 | *** part/#bzflag BZnotify (BZnotify@gateway/service/github.com/x-yvnexwzayxfhmbvp) |
| 08:01.09 | allejo | can I get some feedback and help testing with that PR? |
| 13:08.34 | *** join/#bzflag disco- (~disco@unaffiliated/disco-) |
| 15:37.04 | JeffM | look at in the event should be called "vector", look at is a concept for computing a vector, but by the time the shot is fired, it is a vector. |
| 15:37.25 | JeffM | same for bz_fireServerShot |
| 15:37.35 | JeffM | just call it vector |
| 15:37.50 | JeffM | and add a function to take a posiion and a look at point, to compute a vector |
| 15:39.01 | JeffM | make a single meta data class that stores an int and a string, and make a single map of those with the same key |
| 15:39.11 | JeffM | that way you don't add a map for every new data type. |
| 15:39.41 | JeffM | or make it store a void* and allocate/deallocate an int or string depending on what is set. |
| 15:41.46 | JeffM | you've got your API taking vectors, but fireShot still takes angles.. commonize on vectors. there is no need for dual APIs |
| 15:42.44 | JeffM | there is no need to keep deprecated API functions. |
| 15:43.19 | JeffM | those are my notes ;) |
| 17:02.13 | *** join/#bzflag bertman (~bert@unaffiliated/bertman) |
| 17:16.50 | *** join/#bzflag zaa (~lewalters@pool-72-74-161-211.bstnma.fios.verizon.net) |
| 18:39.16 | macsforme | could we just remove the old functions and bump the API version instead? |
| 18:53.35 | tupone | I get a gcc warning while compiling BitmapFont. Someone know if that case is wanted? |
| 19:03.17 | blast007 | tupone: in the current 2.4 branch? |
| 19:04.03 | tupone | I think so. Letme check |
| 19:04.22 | tupone | On branch 2.4 |
| 19:08.35 | tupone | It was done by Chestal_ . I suppose is correct but missing breaks on the switch is a compiler warning now |
| 19:20.26 | blast007 | I'll see if I can dupe on Debian Sid, after it updates ~1300 packages :) |
| 19:25.21 | tupone | gcc 7.3 |
| 19:25.46 | blast007 | sid has 7.2 |
| 19:26.51 | tupone | Suspicious block is line 86 to 101 of BitmapFont.cxx |
| 19:27.28 | tupone | Maybe is the correct way of doing it. But I don't know what is doing :) |
| 19:47.19 | JeffM | macsforme: that would work too. |
| 19:53.04 | JeffM | tupone: that looks like very bad code, or at least very poorly written. it's using the results of b from the previous for loop too..... |
| 19:53.20 | JeffM | but I belive the intent IS to have it fall through, otherwise data would not be used. |
| 19:55.44 | JeffM | data is only used in *dstData++ = data; that is at the bottom of case 1, so it looks like the code wants to apply all the flags from (w-b) to 1 as a gorup. |
| 19:56.46 | tupone | That is my result too. |
| 19:57.42 | JeffM | replacing it with something like this may work, https://www.irccloud.com/pastebin/peb5D4J8/ |
| 20:00.41 | blast007 | that or we just remove BitmapFont, which is currently only used if someone manually edits their config to set useBitmapFontRenderer to true (which isn't even shown in the config normally because it isn't defined in the defaults) |
| 20:00.50 | JeffM | oh yeah do that! |
| 20:01.11 | JeffM | ohhh that's the old formating BS, from that messed up font file |
| 20:01.38 | JeffM | the code is useless with out those images, and the game doesn't ship with any of those images, and there is no tool to make them. |
| 20:05.02 | JeffM | Well if you wanted to keep it, I think this has the same results in all cases... https://www.irccloud.com/pastebin/9AuOOPkE/ |
| 20:06.23 | blast007 | I actually don't quite know the real difference.. it seems like both use the .fmt files |
| 22:14.33 | allejo | Iâd much favor removing old the API functions would that really be apt for a point release? macsforme, JeffM |
| 22:15.21 | allejo | itâd break any existing plugins. also why I kept the tilt and direction for the new API function, for consistency with current practices |
| 22:15.52 | macsforme | the point releases are fairly meaningless for the server, as has been pointed out, but we could also wait until later |
| 22:16.51 | blast007 | we could do a mass cleanup for 2.6 |
| 22:21.29 | allejo | my concern is that I wouldnât want to break all my WW plugins if I update my server from 2.4.12 to 2.4.14 |
| 22:22.26 | allejo | granted Iâm probably the only one that maintains several of those for mofo and Iâll be updating them with these changes, I wouldnât want to assume no one else is there |
| 22:22.29 | blast007 | yeah, I'd prefer to break the API at a major release |