| 15:04.49 | *** join/#melange ibot (i=ibot@pdpc/supporter/active/TimRiker/bot/apt) |
| 15:04.49 | *** topic/#melange is Want to make Summer of Code and the Highly Open Participation Contest better? Melange is the next generation GSoC and GHOP web app - Code and more at http://code.google.com/p/soc/ - Want to contribute? Start here: http://code.google.com/p/soc/wiki/GettingStarted - Most especially, feel the love! |
| 15:04.56 | TimRiker | ~save |
| 15:04.56 | ibot | saved user and chan files |
| 15:05.20 | SRabbelier | TimRiker: I hear you're our log guy? :D |
| 15:05.20 | TimRiker | lh: bot addeded. sorry I didn't get online much yesterday. :) |
| 15:05.27 | lh | TimRiker: you rock, dude. |
| 15:05.33 | lh | hands TimRikera laurel wreath |
| 15:05.36 | lh | hrm |
| 15:05.37 | TimRiker | lh: got a couple shirts in the mail though, thx! :) |
| 15:05.40 | lh | a laurel wreath even |
| 15:05.41 | lh | rock! |
| 15:05.46 | lh | loves the swag love |
| 15:05.49 | TimRiker | ~wreath lh |
| 15:05.50 | ibot | ACTION hands lh a laurel wreath and nods in gratitude. |
| 15:05.50 | lh | TimRiker: many many thanks |
| 15:05.59 | lh | i love ibot |
| 15:06.01 | lh | :) |
| 15:06.14 | TimRiker | ~logs |
| 15:06.15 | ibot | All conversations are logged to http://ibot.rikers.org/channel, where "channel" is replaced by the URL-encoded channel name, such as %23freenode for #freenode. Lines starting with spaces are not logged. |
| 15:06.16 | lh | okay folks, we now have perma logging thanks to mr. riker |
| 15:06.44 | lh | folks one sec someone at my desk |
| 15:06.48 | _Allen_ | TimRiker: wreath |
| 15:06.50 | lh | please talk about pawel's mail |
| 15:06.51 | lh | :) |
| 15:07.45 | SRabbelier | I'm not sure what the 'apple' is doing in there :P |
| 15:07.48 | tlarsen | It is fabulous. It touched a deep part of me. :) |
| 15:07.50 | TimRiker | if you're not familiar with ibot... /msg ibot help is a good place to start. |
| 15:08.24 | SRabbelier | but it looks good :) |
| 15:09.35 | TimRiker | what's with tpb? that bot is messaging me with error lines. |
| 15:09.50 | SRabbelier | TimRiker: what's it saying? |
| 15:09.58 | _Allen_ | 10 minutes left before the electric power off |
| 15:10.03 | TimRiker | <tpb> Error: "where" is not a valid command. |
| 15:10.06 | SRabbelier | _Allen_: oh? |
| 15:10.23 | _Allen_ | SRabbelier: it's 23:10 in my country now |
| 15:10.37 | SRabbelier | _Allen_: the power goes of at 23:20? |
| 15:10.51 | _Allen_ | SRabbelier: exactly at 23:30 |
| 15:11.01 | SRabbelier | _Allen_: the power jsut goes off? |
| 15:11.30 | _Allen_ | SRabbelier: power cut |
| 15:11.38 | SRabbelier | _Allen_: how come? |
| 15:12.02 | _Allen_ | SRabbelier: it is the rule of my school |
| 15:12.16 | SRabbelier | _Allen_: lol... ok :P |
| 15:12.47 | _Allen_ | SRabbelier: so this is another discussion? |
| 15:12.51 | *** join/#melange madrazr (n=madhu@59.96.202.123) |
| 15:13.06 | SRabbelier | _Allen_: uhm, we're gonna talk about the demo now |
| 15:13.35 | _Allen_ | SRabbelier: sorry that I can not participate |
| 15:13.36 | tlarsen | I think we need to get the Question/Answer/Questionnaire/Response stuff done before the summit. |
| 15:13.53 | SRabbelier | tlarsen: is there a lot of specific logic for those? |
| 15:13.59 | tlarsen | lh: the Terms of Service, Organization applications, etc. are implemented in terms of this. |
| 15:14.05 | tlarsen | No, here is the plan: |
| 15:14.36 | tlarsen | In the (Site/Sponsor/Organization) Settings, you can: |
| 15:14.38 | tlarsen | 1) pick a Questionnaire that has already been created. |
| 15:15.28 | tlarsen | 2) within that Questionnaire, pick the question that represents the "I agree" question |
| 15:15.28 | SRabbelier | tlarsen: similar to how in SiteSetting a Document is selected? |
| 15:15.40 | lh | TimRiker: thank you for the help hint |
| 15:15.42 | tlarsen | 3) within that Question, select the "I agree" affirmative answer |
| 15:15.49 | tlarsen | SRabbelier: |
| 15:15.51 | tlarsen | SRabbelier: Yes. |
| 15:15.56 | lh | _Allen_: will you be online later? |
| 15:16.09 | tlarsen | The Settings entity would store three things: |
| 15:16.18 | tlarsen | 1) ReferenceProperty to the selected Questionnaire |
| 15:16.37 | _Allen_ | lh: 9 hours later |
| 15:16.48 | tlarsen | 2) StringProperty of the "I agree" Question short_name, or maybe even a ReferenceProperty to the Question entity |
| 15:16.49 | _Allen_ | lh: sorry that I need off now |
| 15:17.04 | SRabbelier | _Allen_: will see you later then |
| 15:17.13 | lh | _Allen_: we have another meeting in 8 hrs - i can push it back if you want to participate |
| 15:17.15 | tlarsen | 3) something to record what the "I agree" answer value needs to be |
| 15:17.18 | lh | _Allen_: no problem |
| 15:17.25 | lh | is happy to do the demo at the summit btw |
| 15:17.43 | tlarsen | SRabbelier: I am going to commit drafts of the Question, Answer, Questionnaire, and Response Models today. |
| 15:17.54 | _Allen_ | lh: that's good |
| 15:18.00 | SRabbelier | tlarsen: I was just reading that mail :) |
| 15:18.01 | tlarsen | SRabbelier: I had them very fleshed out at one point, but I lost the code somehow, so I will have to re-write it. |
| 15:18.03 | lh | _Allen_: will do. |
| 15:18.21 | tlarsen | SRabbelier: I will then create issues in the issue tracker describing these pieces. |
| 15:18.38 | SRabbelier | tlarsen: ok, sounds good; you're meaning just the model and logic code, no view code yet? |
| 15:18.50 | tlarsen | SRabbelier: actually, I only had the Models. |
| 15:18.53 | _Allen_ | lh: also feel free to hold that before I come back, I can see the log |
| 15:18.57 | tlarsen | SRabbelier: I will commit something today. |
| 15:19.01 | SRabbelier | tlarsen: ok, that's np :) |
| 15:19.08 | _Allen_ | lh: hold --> start |
| 15:19.11 | tlarsen | SRabbelier: the required logic was going to be described in a series of issues. |
| 15:19.22 | tlarsen | SRabbelier: A UI is needed as well, to: |
| 15:19.23 | lh | _Allen_: okay, but that's an hour before you are back, we will wait for you |
| 15:19.23 | lh | :) |
| 15:19.26 | SRabbelier | tlarsen: ok, makes sense; would be good for _Allen_ to work on |
| 15:19.33 | tlarsen | 1) create Questions |
| 15:19.44 | tlarsen | 2) create Questionnaires that combine a series of Questions |
| 15:20.12 | _Allen_ | lh: ok, :) |
| 15:20.17 | _Allen_ | see u guys |
| 15:20.19 | tlarsen | 3) let users create Responses containing specific Answers to the Questions in a given Questionnaire |
| 15:20.23 | *** part/#melange _Allen_ (n=user@218.27.64.127) |
| 15:20.29 | SRabbelier | tlarsen: how much different from soc.logic.models.questionaires.getOrInsertFromFields... would the create part be? |
| 15:20.40 | SRabbelier | tlarsen: is there a lot of additional stuff needeD? |
| 15:20.52 | tlarsen | SRabbelier: You'll have to wait and see the Model :) |
| 15:20.59 | SRabbelier | tlarsen: ok, will wait for that :) |
| 15:21.15 | tlarsen | SRabbelier: A lot of the fields are *not* required, since the Question Model supports many types of questions. |
| 15:21.35 | tlarsen | SRabbelier: Now that we have inheritance via PolyModel, I'm thinking about having a small hierarchy. |
| 15:21.50 | tlarsen | SRabbelier: That wasn't available to me before, and the Question Model got unnecessarily complex. |
| 15:21.56 | SRabbelier | tlarsen: the Questions will be stored in teh Questionairy in a ListProperty? |
| 15:22.15 | lh | TimRiker: when will the melange logs show up at ibot.rikers.org? |
| 15:22.36 | tlarsen | SRabbelier: No, in a many-to-many relation between Question and Questionnaire. |
| 15:22.54 | SRabbelier | tlarsen: ok, so a question can appear in multiple questionaires? |
| 15:22.58 | tlarsen | Questions can be reused in other Questionnaires. |
| 15:23.24 | SRabbelier | nods |
| 15:23.31 | SRabbelier | ok, makes sense |
| 15:23.40 | SRabbelier | so we'll have a 'list questions' view etc.? |
| 15:23.59 | lh | please make sure to build this so that hosts can easily add/remove questions for questionairres |
| 15:24.07 | lh | i dont want to bug devs for this every time |
| 15:24.32 | SRabbelier | lh: that's easy to do with a many-to-many relation :) |
| 15:24.33 | tlarsen | lh: It is completely run-time dynamic. |
| 15:24.43 | tlarsen | lh: That is why it is so complicated to describe. |
| 15:25.04 | tlarsen | lh: We couldn't possibly have something like Melange work with code changes being required to change or create Questionnaires. |
| 15:25.25 | tlarsen | lh: They will be a sort of Document (Work, actually) that can be created on-the-fly. |
| 15:25.27 | lh | tlarsen: that's very very good |
| 15:26.12 | tlarsen | Ugh, I have 45 emails related to Melange that I still haven't answered, despite reading my emails on the trail. :( |
| 15:26.42 | SRabbelier | tlarsen: I'm looking forward to your reviews :) |
| 15:26.56 | SRabbelier | I managed to get all but the 'edit' part working generic |
| 15:26.58 | SRabbelier | (for Sponsors) |
| 15:27.07 | SRabbelier | and I haven't got edit workign cos I didnt' have time to start on that yet :P |
| 15:33.17 | lh | ahem |
| 15:33.21 | lh | conversation has stopped |
| 15:33.25 | lh | lets keep it going here folks |
| 15:33.48 | SRabbelier | is not sure what to discuss atm :) |
| 15:33.51 | durin42 | sorry, I vanished because of random bugs I wrote two weeks ago. |
| 15:34.00 | durin42 | Did I miss anything I should have paid attention to? |
| 15:34.02 | lh | durin42: no worries. any time to look at the test suite? |
| 15:34.04 | lh | durin42: no you were fine. |
| 15:34.11 | durin42 | lh: on the agenda for tonight |
| 15:34.13 | lh | SRabbelier: how much work is left on the sponsors area |
| 15:34.16 | lh | durin42: awesome. :) |
| 15:34.19 | lh | thank you! |
| 15:34.24 | SRabbelier | lh: for the refactored view stuff? |
| 15:34.28 | lh | SRabbelier: yes |
| 15:34.35 | durin42 | lh: with the MBP in the shop, I can't do hgsubversion stuff as well |
| 15:34.39 | SRabbelier | lh: I think about an hour of work at most |
| 15:34.54 | lh | durin42: MBP? |
| 15:34.58 | tlarsen | prefers email threads for stuff like this, rather than IRC |
| 15:35.06 | lh | SRabbelier: ok cool |
| 15:35.17 | durin42 | lh: MacBook Pro, aka 'a steev' |
| 15:35.19 | SRabbelier | lh: the concept is up for review though |
| 15:35.21 | lh | tlarsen: i know, but some people prefer this way. we will do both to make sure we have effective logs and discussions |
| 15:35.23 | lh | durin42: understood |
| 15:35.30 | lh | SRabbelier: what do you mean by concept up for review? |
| 15:35.49 | SRabbelier | lh: the 1602 codereview |
| 15:35.54 | tlarsen | lh: For me, it is like 10 conversations going on at once, very hard to follow. |
| 15:35.56 | SRabbelier | lh: it's "pseudo code" |
| 15:36.02 | tlarsen | lh: I guess I will just read the logs later. |
| 15:36.06 | TimRiker | lh: logs run nightly, so tomorrow. |
| 15:36.25 | lh | tlarsen: is it going by too fast for you? |
| 15:36.27 | lh | TimRiker: thank you |
| 15:36.27 | lh | :) |
| 15:36.29 | tlarsen | TimRiker: I can read the back-scroll in my own client, but thanks. |
| 15:36.35 | lh | SRabbelier: checking code review |
| 15:36.41 | SRabbelier | lh: -nod- |
| 15:36.51 | lh | tlarsen: it also logs online forever and ever and stuff. ++ |
| 15:36.56 | tlarsen | lh: No, it is just that no one has the floor and three different conversations are intertwined. |
| 15:37.01 | SRabbelier | lh: the views/model/sponsor.py module will get smaller as we make the django templates more generic |
| 15:37.11 | lh | and has some other features that i dont understand but that sound really good |
| 15:37.17 | lh | tlarsen: i see. |
| 15:37.19 | lh | ok |
| 15:37.21 | lh | serializing |
| 15:37.32 | lh | durin42: you have test suites. anything else on your mind? |
| 15:37.37 | lh | everyone, durin42 has the floor |
| 15:37.47 | tlarsen | lh: it is just as annoying as when three separate conversations are going on in the same face-to-face meeting room. :) |
| 15:38.05 | *** join/#melange solydzajs (n=ps@156.17.48.51) |
| 15:38.10 | lh | tlarsen: it's the way of the open source team. and we are now both talking over durin42 too. :) |
| 15:38.10 | durin42 | I'm going to look into various nose plugins for handling GAE stuff |
| 15:38.17 | solydzajs | hi all |
| 15:38.19 | lh | durin42: cool. |
| 15:38.20 | solydzajs | sorry for being late |
| 15:38.21 | durin42 | from what I've seen, they all have elements of suck |
| 15:38.28 | durin42 | so I'll probably just write something basic we can use |
| 15:38.29 | lh | solydzajs: hey. durin42 is updating us right now. |
| 15:38.35 | SRabbelier | durin42: that would be good, seems like GAE has some particularities that need dealing with for testing |
| 15:38.36 | lh | durin42: cool. what does this do exactly? |
| 15:38.59 | durin42 | lh: makes it possible for people to write tests of the actual views and utility functions |
| 15:39.20 | lh | durin42: very good, thanks for the explanation. |
| 15:39.26 | lh | durin42: anything else on your mind? |
| 15:39.44 | durin42 | Not really. |
| 15:39.47 | solydzajs | durin42: I was also looking into pymox for mocking |
| 15:40.32 | SRabbelier | solydzajs: yeah, that might be usefull with the django stuff |
| 15:40.41 | durin42 | solydzajs: To be perfectly honest, I find a "real" mocking library superfluous with Python |
| 15:40.57 | lh | ok you two get two minutes to talk about testing |
| 15:41.04 | lh | then we are going to ask SRabbelier to update on what he's up to |
| 15:41.07 | lh | then solydzajs |
| 15:41.13 | SRabbelier | nods |
| 15:41.23 | lh | tlarsen has asked that we continue discussing the demo on list, so we will honor that request |
| 15:41.35 | durin42 | I'd rather keep our deps down, and I don't see what pymox gets us. |
| 15:41.47 | tlarsen | I have to agree with durin42 here. |
| 15:41.47 | solydzajs | durin42: ;-) there is some project for using nose with appengine already |
| 15:41.49 | solydzajs | durin42: http://code.google.com/p/nose-gae/ |
| 15:41.50 | tpb | Title: nose-gae - Google Code (at code.google.com) |
| 15:42.01 | tlarsen | It is so easy to mock even existing classes in Python. |
| 15:42.09 | durin42 | solydzajs: I know, but I don't know if JP and Kumar are maintaining it |
| 15:42.40 | durin42 | (I work with the guys that wrote that, the problem as I see it is that we'd have to install it globally) |
| 15:42.40 | solydzajs | durin42: probably not :-) |
| 15:43.05 | durin42 | Thus me looking into just having a 't.py' or something that sets up the environment and then calls nose's test runner |
| 15:43.58 | SRabbelier | durin42: if it's only a simple file? |
| 15:44.04 | tlarsen | durin42: Ummm, t.py? |
| 15:44.20 | tlarsen | durin42: A more descriptive file name, perhaps? :) |
| 15:44.22 | durin42 | tlarsen: or runtests.py or whatever |
| 15:44.39 | durin42 | I'm working over a 1.5 second typing lag here, so cut me a bit of slack ;) |
| 15:45.25 | durin42 | Anywho, that's the state of automated testing. With any luck, we'll have a usable testing framework by the end of the week. |
| 15:45.26 | solydzajs | durin42: btw did you see the link I sent to the group about testing recipe ? |
| 15:45.46 | durin42 | solydzajs: I did, but have not looked at it. I've been knee deep in subversion ctypes stuff until today or so. |
| 15:45.56 | solydzajs | durin42: oh ok :-) |
| 15:46.09 | durin42 | I'll be starting on this stuff around dinnertime for people in Chicago. |
| 15:46.22 | lh | have we talked about testing enough? looks like we have..... |
| 15:46.44 | durin42 | I think so. |
| 15:47.27 | solydzajs | yep |
| 15:48.50 | lh | okay next |
| 15:48.54 | lh | SRabbelier: what's on your mind? |
| 15:49.10 | SRabbelier | did everybody have a look at, or at least see http://codereviews.googleopensourceprograms.com/1602 ? |
| 15:49.12 | tpb | <http://ln-s.net/2KTD> (at codereviews.googleopensourceprograms.com) |
| 15:49.34 | lh | looks at sverre's code review |
| 15:50.09 | lh | SRabbelier: do you need people to review and comment before proceeding? |
| 15:50.22 | solydzajs | SRabbelier: yes I did, but didn't have time to review yet |
| 15:50.25 | SRabbelier | lh: well, I can finish it up to actual working code |
| 15:50.29 | tlarsen | lh: for some things, YES. |
| 15:50.40 | SRabbelier | lh: but before I start refactoring more modules I'd like it to be reviewed |
| 15:50.40 | tlarsen | lh: For major new things, we need to discuss things. |
| 15:50.50 | tlarsen | lh: Also, SRabbelier I believe indicated that this was speculative. |
| 15:51.05 | SRabbelier | tlarsen: speculative? |
| 15:51.14 | SRabbelier | is not sure what that means :$ |
| 15:51.22 | tlarsen | SRabbelier: OK, maybe not that particular review. |
| 15:51.34 | lh | speculative means that it is not necessarily what you want to do, it is just an idea |
| 15:51.36 | lh | okay, so |
| 15:51.43 | lh | tlarsen: do you want to review and comment on 1602 now? |
| 15:51.45 | SRabbelier | ok, -nods- |
| 15:52.02 | SRabbelier | tlarsen: 1602 is what I think would be good, but I'm open for suggestions on how to do it better |
| 15:52.02 | tlarsen | lh: During this meeting? I don't think that is a good idea. |
| 15:52.08 | tlarsen | lh: You can't just mandate a code review. |
| 15:52.19 | tlarsen | lh: We aren't going to pair-program over IRC, sorry. |
| 15:52.25 | SRabbelier | tlarsen: for example the I'm using dicts to store some values, but it's probably a bit overkill |
| 15:52.38 | lh | tlarsen: i am suggesting assigning action items for following this meeting. |
| 15:52.44 | SRabbelier | saw some very awesome Eclipse plugin for pair programming the other day at solydzajs's reader |
| 15:52.49 | tlarsen | SRabbelier: I am working my way through a huge backlog of stuff you just committed on *Sunday*. |
| 15:53.00 | tlarsen | SRabbelier: I was caught up on Saturday evening. :) |
| 15:53.01 | lh | tlarsen: since you are not available due to car problems, is there someone you would like to review instead? i would suggest solydzajs |
| 15:53.21 | tlarsen | lh: I want to review this. |
| 15:53.25 | SRabbelier | tlarsen: -nods-, right, that was mostly in reply to your and pawels' suggestions I think, hopefully it'll mostly be LGTM's, no major changes |
| 15:53.27 | solydzajs | tlarsen: I still have some commits to do regarding your comments to my commits from a week ago :-) |
| 15:53.28 | tlarsen | lh: And I will *make* the time. |
| 15:53.43 | lh | tlarsen: okay, great. can you give SRabbelier an ETA on a review? |
| 15:53.45 | SRabbelier | solydzajs: -reads that a few times- |
| 15:53.59 | tlarsen | lh: SRabbelier and I don't see some things eye-to-eye, and I at least want to get my specific $0.02 in. |
| 15:54.06 | tlarsen | lh: Today. |
| 15:54.07 | lh | tlarsen: that's a good thing. |
| 15:54.18 | lh | tlarsen: okay, any idea when today? just because we are all in different time zones |
| 15:54.22 | solydzajs | lh: yep it's better for tlarsen to review this, cause this is major change |
| 15:54.55 | lh | solydzajs: agreed. just trying to get an idea of timing. |
| 15:55.05 | tlarsen | lh: Before 3 AM Tuesday morning, CDT. |
| 15:55.11 | lh | tlarsen: rocking. |
| 15:55.35 | SRabbelier | tlarsen: ok, then I'll finish it up to where all sponsor views are actually with the new code in place, and put that up for review |
| 15:55.39 | lh | SRabbelier: this means by tuesday afternoon your time you will have comments. can you prioritize your other work around this needed review? |
| 15:55.40 | tlarsen | lh: My wife puts on a sleep mask and ear plugs, so I can work all night if needed. :) |
| 15:55.40 | SRabbelier | after that I'll take a break to work on school stuff |
| 15:55.45 | lh | tlarsen: rock on. :) |
| 15:55.54 | lh | makes note: buy fashion earplugs for mrs. tlarsen |
| 15:56.02 | solydzajs | :-) |
| 15:56.03 | tlarsen | lh: Ewwww... |
| 15:56.04 | SRabbelier | chuckles |
| 15:56.18 | SRabbelier | tlarsen: it's called "sleepign, in stylleeee" |
| 15:56.58 | lh | exactly |
| 15:56.59 | lh | ok |
| 15:57.09 | lh | SRabbelier: do you know what you need to do in between now and tlarsen's review of 1602? |
| 15:57.14 | SRabbelier | lh: I don't have any other work atm except that (and the review) |
| 15:57.42 | solydzajs | SRabbelier: start working on generic profiles |
| 15:57.47 | solydzajs | SRabbelier: Roles |
| 15:57.54 | SRabbelier | solydzajs: can you define that better? |
| 15:57.54 | lh | SRabbelier: there you go, help pawel. |
| 15:58.01 | SRabbelier | solydzajs: what is needed for those? |
| 15:59.05 | *** join/#melange mithro (n=tim@unaffiliated/mithro) |
| 15:59.05 | *** mode/#melange [+v mithro] by ChanServ |
| 15:59.25 | *** topic/#melange by lh -> Want to make Summer of Code and the Highly Open Participation Contest better? Melange is the next generation GSoC and GHOP web app - Code and more at http://code.google.com/p/soc/ - Want to contribute? Start here: http://code.google.com/p/soc/wiki/GettingStarted - Logs at http://ibot.rikers.org/%23melange within 24 hours |
| 15:59.32 | solydzajs | SRabbelier: Generic Profile Form that can be reused in all Roles Profiles, Generic Logic for Profiles (saving in datastore etc) and user view/public view |
| 15:59.56 | SRabbelier | solydzajs: ok, so like my earlier Person related commits? |
| 16:00.14 | solydzajs | SRabbelier: yes like your earlier not finished commits :D |
| 16:00.14 | SRabbelier | s/commits/review/ |
| 16:00.23 | SRabbelier | *LAUGHS* |
| 16:00.25 | SRabbelier | omgomg! |
| 16:00.27 | SRabbelier | that is too awesome |
| 16:00.36 | SRabbelier | s/too/totally |
| 16:00.45 | solydzajs | so we have too bots now for logging :-) |
| 16:00.53 | SRabbelier | s/too/two/ ? |
| 16:01.01 | SRabbelier | figures you need to include teh trailing slash |
| 16:01.03 | SRabbelier | s/teh/the/ |
| 16:01.27 | SRabbelier | did I break it? 0.o |
| 16:01.35 | lh | SRabbelier: focus! |
| 16:01.45 | SRabbelier | solydzajs: ok, I can do that |
| 16:01.46 | lh | SRabbelier: sounds like you have some unfinished coding work to get done. |
| 16:01.53 | SRabbelier | solydzajs: with the new logic and view code it'll be easier |
| 16:02.04 | SRabbelier | lh: I suspended it till after generic logic was done |
| 16:02.21 | SRabbelier | lh: actually, the generic logic code came from working on that module |
| 16:02.48 | lh | SRabbelier: so can you finish it now? |
| 16:03.05 | SRabbelier | lh: yes |
| 16:03.14 | lh | SRabbelier: there you go. |
| 16:03.20 | lh | SRabbelier: anything else on your mind? |
| 16:03.20 | SRabbelier | I'll do the (trivial) logic stuff first |
| 16:03.31 | SRabbelier | and then wait to do the view code till after todd's review |
| 16:03.54 | lh | SRabbelier: sounds good. |
| 16:04.08 | SRabbelier | good thing I didn't delete that branch :P |
| 16:05.15 | lh | okay |
| 16:05.17 | lh | SRabbelier: you done? |
| 16:05.20 | solydzajs | ok good |
| 16:05.24 | tlarsen | Ugh, stupid IRC bot tricks. |
| 16:05.33 | tlarsen | It will be a feature on Letterman before you know it. |
| 16:05.37 | SRabbelier | lh: sure, I'm good to get started |
| 16:05.42 | lh | SRabbelier: good. |
| 16:06.10 | lh | tlarsen: what's on your mind for the next couple of days besides catching up on commits and commenting on CL 1602 for SRabbelier |
| 16:06.37 | tlarsen | Besides taking another week off because the 50-mile hike was tortuous? |
| 16:06.43 | SRabbelier | lh, tlarsen: well, and the fix-ups for r733 I reckon |
| 16:06.59 | tlarsen | SRabbelier: Yes, undoing a bunch of stuff I didn't like in r733. :) |
| 16:07.15 | SRabbelier | tlarsen: we're a concencus community though |
| 16:07.25 | tlarsen | tlarsen: No, really. I want to get the Question/Answer and Questionnaire/Response models defined. |
| 16:07.31 | SRabbelier | tlarsen: I think reverts should be after community concencus |
| 16:07.39 | tlarsen | SRabbelier: Yes, but you didn't have consensus when you committed. :) |
| 16:07.44 | lh | tlarsen: another week off is good. |
| 16:07.55 | tlarsen | lh: one of the hazards of review-before-commit: commit wars! |
| 16:07.58 | lh | tlarsen: you can't always wait for consensus to committ. |
| 16:08.08 | lh | tlarsen: this is a war i am willing to fight. :) |
| 16:08.20 | tlarsen | lh: Yes, and the one who didn't have consensus when he committed can't get upset when someone patches over them. |
| 16:08.35 | tlarsen | lh: I will put my code where my mouth is. |
| 16:08.49 | tlarsen | lh: I outlined in graphic detail in the previous discussion what I plan to do and why. |
| 16:08.53 | lh | tlarsen: that is totally true. |
| 16:08.56 | tlarsen | lh: Existing functionality was *removed* by r733. |
| 16:09.04 | SRabbelier | tlarsen: see my reply to your comments in r733 |
| 16:09.06 | lh | tlarsen: and did it cause breakage? |
| 16:09.09 | tlarsen | lh: I will restore it in the current framework of r733. |
| 16:09.12 | SRabbelier | tlarsen: and also CL1602 |
| 16:09.27 | SRabbelier | tlarsen: I believe that will explain why I think it won't be needed |
| 16:09.29 | tlarsen | lh: No, but it removed my ability to customize the login prompts per-page, which I was planning to do as soon as I had time. |
| 16:09.38 | lh | tlarsen: can this be worked around? |
| 16:09.44 | SRabbelier | tlarsen: right, but with the new view refactor you won't have to |
| 16:09.45 | tlarsen | lh: The current UI is pretty lame regarding asking the user to login when they are not. |
| 16:09.48 | SRabbelier | tlarsen: you can define it in teh base classes |
| 16:09.57 | tlarsen | Sigh. |
| 16:10.53 | lh | okay. so tlarsen, can you look at CL1602 first, then comment on r733? |
| 16:11.04 | tlarsen | lh: The point is this: the functionality was removed, and justification for it being there was provided in the review-after-commit, but no justification of similar weight and coherency was provided as to why it should not be added back. But, yes, I will look at 1602 first. |
| 16:11.26 | lh | tlarsen: thank you. perhaps that would be helpful. |
| 16:11.29 | tlarsen | lh: consensus is meaningless when some of the parties do not justify their position with facts. |
| 16:11.36 | lh | SRabbelier: you may also want to add more detail to r733 too |
| 16:11.44 | lh | tlarsen: we're working on fixing that now, aren't we? :) |
| 16:11.49 | SRabbelier | tlarsen: you read my latest comments to r733? |
| 16:11.51 | tlarsen | lh: Why, yes, we are. |
| 16:12.00 | lh | tlarsen: ++ |
| 16:12.08 | tlarsen | lh: But, please don't be good cop to my bad cop, OK? |
| 16:12.15 | lh | tlarsen: i'm not. i am facilitating. |
| 16:12.35 | tlarsen | lh: So, you won't mind being disintermediated, then? |
| 16:12.50 | lh | tlarsen: what does that mean? |
| 16:12.52 | lh | uses google |
| 16:12.53 | tlarsen | lh: This discussion was going just fine in the code review thread. |
| 16:13.05 | tlarsen | fucking hates IRC |
| 16:13.10 | SRabbelier | tlarsen: if you read my reply, please comment :) |
| 16:13.14 | lh | tlarsen: this is how open source works todd |
| 16:13.17 | tlarsen | It doesn't show when someone else is typing like Jabber does. |
| 16:13.28 | lh | tlarsen: i dont think the discussion should not take place on list too. |
| 16:13.32 | tlarsen | That is the primary reason why people type over each other. |
| 16:13.46 | lh | there has to be a tool that accomodates. |
| 16:14.20 | lh | tlarsen: i am happy to read on list comments too, but can't read them all. this meeting helps me keep in sync. other people, i hope, find it useful. |
| 16:14.22 | tlarsen | lh: "this is how open source works" is also why asbestos underwear is required. :) |
| 16:14.52 | solydzajs | i'm back, so where are we at ? |
| 16:16.03 | durin42 | lh: TBQH, I hate irc too. It's a time drain, and sucks for having coherent conversations most of the time. |
| 16:16.32 | SRabbelier | must be too young |
| 16:16.54 | tlarsen | durin42: exactly. |
| 16:16.56 | solydzajs | how about we make a Skype conference call next time ? |
| 16:16.58 | lh | durin42: to each their own |
| 16:17.01 | lh | solydzajs: i like this idea. |
| 16:17.08 | SRabbelier | solydzajs: +1 on that |
| 16:17.12 | lh | tlarsen: thoughts? |
| 16:17.12 | SRabbelier | does everybody have a mic/headset? |
| 16:17.20 | solydzajs | SRabbelier: I do |
| 16:17.20 | tlarsen | solydzajs: How about we just use Jabber, with the "someone is typing" indicator? |
| 16:17.31 | SRabbelier | tlarsen: skype has that -nods- |
| 16:17.39 | solydzajs | tlarsen: we can do that too, make a gtalk group chat |
| 16:17.49 | SRabbelier | solydzajs: that would work |
| 16:18.01 | durin42 | does pidgin support grouptalk on gtalk? |
| 16:18.10 | SRabbelier | durin42: not really |
| 16:18.10 | durin42 | (and if so, does Adium?) |
| 16:18.13 | SRabbelier | durin42: only half |
| 16:18.26 | SRabbelier | durin42: you get the invite, but last time I tried it didn't know what to do with it |
| 16:18.50 | lh | i dont give a crap what tool we use. |
| 16:18.57 | lh | you guys figure that out |
| 16:19.37 | SRabbelier | I'm fine with whatever is good for you |
| 16:20.08 | lh | i want tlarsen to be happy with our tool choice. sounds like jabber works well for him. however, skype offers voice. |
| 16:20.20 | SRabbelier | doesn't have a jabber profile |
| 16:20.26 | SRabbelier | how do you make one? |
| 16:20.29 | SRabbelier | jabber.com or such? |
| 16:20.36 | solydzajs | SRabbelier: you have gmail.com |
| 16:20.45 | SRabbelier | solydzajs: that works? |
| 16:20.55 | solydzajs | SRabbelier: GTalk is based on XMPP and has group chat |
| 16:21.14 | lh | do we all agree that our next meeting with be on GChat? |
| 16:21.27 | lh | if so is there a way to bridge that so that our meeting still gets logged to our regular logs |
| 16:21.35 | SRabbelier | lh: I'm good with gchat |
| 16:21.56 | lh | okay. |
| 16:22.22 | lh | GChat it is |
| 16:22.31 | lh | i will paste the logs in channel so they get logged by ibot |
| 16:22.34 | lh | okay |
| 16:22.37 | lh | so |
| 16:22.41 | lh | solydzajs: what are you up to right now? |
| 16:23.57 | SRabbelier | tlarsen: on the email=id thing, it works only because str(id) returns id.email() |
| 16:24.25 | tlarsen | SRabbelier: Yes, but id.email() is explicit and conveys *intent*. |
| 16:24.30 | SRabbelier | tlarsen: Pawel asked me to do a patch to clean all those up and us id.email() everywhere |
| 16:24.32 | tlarsen | SRabbelier: That is important in readable code. |
| 16:24.36 | SRabbelier | tlarsen: right, I agree |
| 16:24.45 | tlarsen | SRabbelier: Yes, please fix this. |
| 16:25.00 | solydzajs | lh: after recent code reviews, I'm working on Delete Document feature and when I commit that I will move to Promote to Host probably |
| 16:25.07 | lh | solydzajs: sounds good. |
| 16:25.09 | tlarsen | SRabbelier: we have pretty much established "id" in the code meaning Google Account (as a users.User object). |
| 16:25.24 | SRabbelier | tlarsen: ok, then let's go with that everywhere |
| 16:25.34 | SRabbelier | tlarsen: I'll double check the code to see if it's not abused anywhere |
| 16:26.15 | lh | ok gentlemen |
| 16:26.21 | lh | i am 30 minutes late for another meeting |
| 16:26.37 | lh | _Allen_ requested that we move our next meeting back so he could attend |
| 16:26.42 | lh | does this work for all? |
| 16:26.43 | lh | http://tinyurl.com/melangemondaymeeting |
| 16:26.45 | tpb | Title: The World Clock - Time Zone Converter - U.S.A. California San Francisco vs Poland Warsaw (at tinyurl.com) |
| 16:27.03 | SRabbelier | lh: 3am in the morning? |
| 16:27.13 | SRabbelier | :P |
| 16:27.29 | SRabbelier | why is our next meeting so soon though? |
| 16:27.36 | solydzajs | 3 AM doesn't work for me :-) |
| 16:27.47 | SRabbelier | solydzajs: same here |
| 16:28.16 | lh | hrm. |
| 16:28.29 | lh | SRabbelier: it was our regularly scheduled meeting |
| 16:28.35 | lh | i will just check in with _Allen_ tonight |
| 16:28.39 | lh | do we need that meeting at all? |
| 16:28.51 | SRabbelier | not me personally |
| 16:29.01 | lh | solydzajs: you need it? |
| 16:29.04 | lh | tlarsen: you need it? |
| 16:29.06 | lh | durin42: you need it? |
| 16:29.09 | solydzajs | lh: tlarsen wrote _Allen_ what he could work on, so I think he will be fine when he reads his inbox :-) |
| 16:29.12 | tlarsen | lh: No I do not. |
| 16:29.27 | tlarsen | lh: I believe these are mostly for you. :) |
| 16:30.01 | lh | tlarsen: done, today is canceled |
| 16:30.08 | lh | i will still check in with _Allen_ |
| 16:30.27 | lh | tlarsen: i scheduled them because people wanted to make sure i was commenting. :) so i hope they are good for more than just me. |
| 16:30.28 | tlarsen | lh: I'm sure he will check his email once power is restored. |
| 16:31.53 | solydzajs | Is there anything else to discuss ? I would like to get back to work and do some coding :-) |
| 16:32.05 | SRabbelier | would like to get to dinner himself :P |
| 16:32.23 | lh | SRabbelier: go eat |
| 16:32.34 | lh | tlarsen: always nice to say hello too |
| 16:32.38 | lh | solydzajs: i think we are done |
| 16:32.44 | lh | anyone have anything to add? |
| 16:33.11 | SRabbelier | lh: I like them, it's nice to make sure we all stay in touch |
| 16:33.24 | SRabbelier | uhm, "Eta Beta Pi" (eat a better pie :P) |
| 16:33.25 | lh | SRabbelier: cool. |
| 16:33.34 | lh | SRabbelier: wtf dude. :p |
| 16:33.39 | SRabbelier | :D |
| 16:33.49 | lh | alright |
| 16:33.51 | lh | goes to other meeting |
| 16:34.00 | SRabbelier | lh: ok, ttyl |
| 16:34.46 | tlarsen | definitely prefers the store-and-forward nature of email, given his ridiculously hectic schedule. |
| 16:36.40 | solydzajs | okie dokie guys :-) |
| 16:36.59 | solydzajs | I'm going back to coding |
| 16:37.10 | solydzajs | ciao |
| 16:37.15 | tlarsen | Sigh. I am continuing to code review. |
| 16:37.21 | tlarsen | puts on his Code Review Monkey hat. |
| 16:38.02 | solydzajs | yay |
| 16:38.06 | solydzajs | ttyl |
| 16:38.11 | solydzajs | i'm going offline |
| 16:38.11 | solydzajs | :-) |
| 16:39.27 | tlarsen | SRabbelier: was this committed? http://codereviews.googleopensourceprograms.com/1601 |
| 16:39.30 | tpb | <http://ln-s.net/2KUU> (at codereviews.googleopensourceprograms.com) |
| 16:39.35 | tlarsen | SRabbelier: If so, has the review been marked "closed"? |
| 16:40.32 | SRabbelier | tlarsen: mhhh, yes, it has been committed, didn't close it yet since you hadn't commented on that version; I'll close it now |
| 16:47.20 | *** join/#melange mithro (n=tim@unaffiliated/mithro) |
| 16:47.20 | *** mode/#melange [+v mithro] by ChanServ |
| 17:13.59 | SRabbelier | tlarsen: pawel and I suggested earlier for the reviewer today to fix style mistakes instead of pointing them out, since now it takes trice the time; once for you to point them out, once for me to fix them, then once more for you to see if they were fixed to satistfaction |
| 17:14.53 | SRabbelier | tlarsen: style, spelling, indentation, little things like that |
| 17:15.27 | tlarsen | SRabbelier: Sorry, but when I am code reviewing, I point out everything. I don't know until I am done that I will end up with only style mistakes. |
| 17:15.40 | tlarsen | So, I send out what I have already taken the time to type. |
| 17:16.05 | tlarsen | SRabbelier: when I am focused on the code, I see everything (or, I am not focused enough and miss important stuff). |
| 17:16.13 | tlarsen | SRabbelier: Sorry, but that is the way my brain works. :) |
| 17:17.08 | tlarsen | SRabbelier: I don't know how to do two different kinds of code review. I don't think the burden should be on the reviewer, since review-before-commit would catch this and the burden would still be on the committer. |
| 17:17.17 | tlarsen | SRabbelier: it is part of the price that is paid for review-after-commit. |
| 17:17.33 | tlarsen | SRabbelier: That being said, when I see stuff in existing files that I am modifying, I'll just fix it. |
| 17:17.58 | tlarsen | SRabbelier: This is one of the reasons we do not do review-after-commit at Google, ever (except for to-be-reviewed *emergencies*). |
| 17:31.09 | SRabbelier | tlarsen: ok, I understand, no problem :) |
| 17:31.16 | SRabbelier | tlarsen: thanks for the explanation :) |
| 17:34.13 | tlarsen | SRabbelier: The point is that the committer, not the reviewer, is responsible for correctly reviewer comments. |
| 17:34.46 | SRabbelier | tlarsen: yes, I agree on the responsibility part -nod- |
| 17:35.00 | tlarsen | I have *tons* of reviews sent to me each week. If I had to *fix* as well as review, I'd just stop reviewing. :) |
| 17:35.13 | tlarsen | (Melange plus Google internal code reviews) |
| 17:35.38 | SRabbelier | tlarsen: -nod-, yeah, I can imagine |
| 18:26.43 | tlarsen | SRabbelier: OK, first thoughts on 1602 sent. |
| 18:26.56 | SRabbelier | tlarsen: thanks, -reads- |
| 18:27.43 | tlarsen | Sorry it took so long. |
| 18:27.49 | tlarsen | SRabbelier: I had a lot to say, I suppose. |
| 18:27.51 | SRabbelier | tlarsen: I don't see a TODo above existing code? |
| 18:27.54 | SRabbelier | it's ok, :) |
| 18:28.23 | SRabbelier | tlarsen: oh, on the silly import naming scheme, sometimes it just breaks for no reason |
| 18:28.43 | SRabbelier | tlarsen: when you do "from soc.logic import models" and then later on models.settings, it says there's no settings module |
| 18:28.45 | tlarsen | Please respond in the code review tool and not on IRC. |
| 18:28.46 | tlarsen | Thanks. |
| 18:28.54 | tlarsen | Yes, you need: |
| 18:29.05 | tlarsen | from soc.logic.models import settings |
| 18:29.12 | tlarsen | Then just use settings.Foo() |
| 18:29.18 | tlarsen | Or: |
| 18:29.25 | tlarsen | from soc.logic import models |
| 18:29.31 | tlarsen | import soc.logic.models.settings |
| 18:29.36 | tlarsen | and then models.settings will work. |
| 18:29.39 | SRabbelier | tlarsen: aaaah, ok! |
| 18:29.41 | SRabbelier | tlarsen: thank you! |
| 18:29.48 | SRabbelier | goes to clean up code |
| 18:31.28 | SRabbelier | tlarsen: how about a script that detects things like that; do you know of one? |
| 18:31.43 | tlarsen | pychecker? |
| 18:32.09 | SRabbelier | tlarsen: mhh, I remember you mentioning it earlier, was there a reason we're not really using it? |
| 18:33.16 | tlarsen | I am all out of round tuits. |
| 18:33.43 | SRabbelier | round tuits? |
| 18:51.31 | tlarsen | "I will do it when I get around to it..." |
| 18:51.36 | tlarsen | "a round tuit" |
| 18:51.41 | SRabbelier | lol, ok |
| 18:51.52 | tlarsen | http://www.myrtlewoodgallery.com/get_a_round_tuit.htm |
| 18:51.53 | tpb | <http://ln-s.net/2KWs> (at www.myrtlewoodgallery.com) |
| 18:52.02 | tlarsen | I have lots of the square ones these days. |
| 18:52.18 | SRabbelier | tlarsen: cute, never heard that one :) |
| 18:53.47 | *** join/#melange mithro (n=tim@unaffiliated/mithro) |
| 18:53.47 | *** mode/#melange [+v mithro] by ChanServ |
| 19:42.24 | SRabbelier | tlarsen: replied :) |
| 19:42.29 | SRabbelier | tlarsen: thanks for the detailed review |
| 21:04.45 | *** join/#melange TimRiker (n=timr@72-62-179-250.area1.spcsdns.net) |
| 21:05.09 | *** part/#melange TimRiker (n=timr@bzflag/projectlead/TimRiker) |
| 21:17.22 | *** join/#melange solydzajs (n=solydzaj@apn-77-113-116-102.gprs.plus.pl) |
| 21:17.22 | *** mode/#melange [+v solydzajs] by ChanServ |
| 21:18.10 | solydzajs | tlarsen: ping |
| 21:18.26 | SRabbelier | tlarsen: replying now, then going to bed :) |
| 21:19.09 | solydzajs | tlarsen: "Pawel, what about the more-generic HomeSettings class that already exists in soc/models/home_settings.py?" You mean to replace SiteSettings with HomeSettings ?because right now SiteSettings inherits from HomeSettings |
| 22:03.33 | *** join/#melange James--Crook (n=client@89.100.50.76) |
| 22:21.28 | *** part/#melange James--Crook (n=client@89.100.50.76) |
| 22:33.48 | SRabbelier | time for bed |
| 22:33.49 | SRabbelier | g'night |
| 22:34.01 | SRabbelier | holy cr*p |
| 22:36.23 | SRabbelier | solydzajs: damn Pawel, please tell me you used a script to sort those imports? |
| 22:36.37 | solydzajs | SRabbelier: yo :-) |
| 22:36.45 | solydzajs | SRabbelier: no |
| 22:36.58 | solydzajs | SRabbelier: why ?;-) |
| 22:37.16 | SRabbelier | solydzajs: cos I hate manual labor like that :P |
| 22:37.24 | SRabbelier | solydzajs: nice job! |
| 22:37.40 | solydzajs | SRabbelier: it was my break (no need to use brain ;-) ) :D |
| 22:38.04 | SRabbelier | solydzajs: thanks for applying Todd's suggestions, I did not have time to code at all today, have been doing code review (well, it was really design the app I guess) all day |
| 22:38.09 | SRabbelier | solydzajs: hehe, sweet :) |
| 22:38.21 | solydzajs | sure no problem |
| 22:38.25 | solydzajs | I just need to clear my inbox |
| 22:38.26 | solydzajs | :-) |
| 22:38.36 | solydzajs | so I'm fixing what ever I can |
| 22:38.37 | solydzajs | :-) |
| 22:39.06 | SRabbelier | solydzajs: awesome :) |
| 22:40.48 | SRabbelier | solydzajs: btw, implicit LGTM on everything that I don't comment on :P |
| 22:40.59 | solydzajs | SRabbelier: ok :-) |
| 22:41.11 | SRabbelier | (downside of that ofcourse is if for some reason I don't have time to review, a LGTM is unjustifiedly assumed :P) |
| 22:41.32 | SRabbelier | anyway |
| 22:41.37 | SRabbelier | I must really be off to bed now |
| 22:41.44 | SRabbelier | solydzajs: ps: will you code the _as_table template? |
| 22:41.58 | solydzajs | SRabbelier: hopefully tomorrow |
| 22:42.18 | SRabbelier | solydzajs: really? awesome! |
| 22:42.27 | SRabbelier | hopefully we can generalize even more views that way :) |
| 22:42.30 | solydzajs | SRabbelier: hope so |
| 22:43.09 | SRabbelier | g'night then :) |
| 22:43.46 | SRabbelier | tlarsen: thanks for the reviews (it felt more like design than review though :), that's good I think) |
| 22:45.53 | solydzajs | g'night |
| 23:36.36 | *** join/#melange _Allen_ (n=user@218.27.66.131) |