| 00:00.15 | *** join/#storm wallflower (n=wallflow@ip-205-246-113-216.pool.grokthis.net) |
| 05:56.31 | *** join/#storm jbot (i=ibot@pdpc/supporter/active/TimRiker/bot/apt) |
| 05:56.31 | *** topic/#storm is The Storm Python ORM - http://storm.canonical.com/ - 0.11 released! || Review branches: https://bugs.launchpad.net/storm/+bugs?field.tag=review |
| 06:49.18 | *** join/#storm jukart (n=jukart@194.183.146.181) |
| 06:59.45 | *** join/#storm dobee (n=dobeee@194.183.146.186) |
| 07:47.33 | *** join/#storm bozzo (n=bozzo@BSN-77-236-112.dial-up.dsl.siol.net) |
| 09:08.27 | *** join/#storm ubot3 (n=ubot3@unaffiliated/nalioth/bot/ubot3) [NETSPLIT VICTIM] |
| 09:08.27 | *** join/#storm michelp (n=michelp@69-30-72-119.dq1sf.easystreet.com) [NETSPLIT VICTIM] |
| 09:08.27 | *** join/#storm ajmitch (n=ajmitch@ubuntu/member/ajmitch) [NETSPLIT VICTIM] |
| 09:25.46 | *** join/#storm ubot3 (n=ubot3@unaffiliated/nalioth/bot/ubot3) [NETSPLIT VICTIM] |
| 09:25.46 | *** join/#storm michelp (n=michelp@69-30-72-119.dq1sf.easystreet.com) [NETSPLIT VICTIM] |
| 09:25.46 | *** join/#storm ajmitch (n=ajmitch@ubuntu/member/ajmitch) [NETSPLIT VICTIM] |
| 10:14.54 | *** join/#storm therve (n=th@sd-5831.dedibox.fr) |
| 10:14.59 | therve | hi! |
| 10:52.07 | *** join/#storm bozzo_ (n=bozzo@BSN-210-221-88.dial-up.dsl.siol.net) |
| 11:28.45 | *** join/#storm bozzo (n=bozzo@85.10.14.223) |
| 12:14.29 | *** join/#storm lymxz (n=lymxz@123.116.113.192) |
| 12:21.35 | *** join/#storm niemeyer (n=niemeyer@201-14-56-127.ctame705.dsl.brasiltelecom.net.br) |
| 13:03.36 | *** join/#storm trisiak (n=tree@chello084010084214.chello.pl) |
| 13:11.11 | radix | therve: good morning! |
| 13:11.32 | radix | I just got the worst review response ever |
| 13:31.08 | *** part/#storm lymxz (n=lymxz@123.116.113.192) |
| 13:32.01 | *** join/#storm goschtl (n=goschtl@p5495D5DF.dip.t-dialin.net) |
| 13:32.10 | therve | radix: which was ? |
| 13:37.44 | radix | bernd's. he seemed to disagree with every single one of my points, and ignored many of my suggestions |
| 13:38.00 | radix | or didn't read it very clearly, or something |
| 13:38.37 | therve | heh, reviewing is also a social thing :) |
| 13:39.35 | therve | hum, not knowing what LoC means is a bit disturbing |
| 13:39.53 | therve | radix: I came here to point at http://bugs.python.org/issue1549 |
| 13:40.32 | radix | oh, huh |
| 13:40.35 | radix | yeah I remember that ticket |
| 13:41.12 | radix | is this going to affect Columns? |
| 13:41.43 | therve | it affetcs Comparable |
| 13:41.57 | radix | yeah |
| 13:42.32 | therve | and also ClassInfo I guess |
| 13:42.55 | therve | storm tests completely explodes on current trunk |
| 13:43.30 | therve | and that really really pisses me off |
| 13:43.50 | therve | because of this f***** abc that nobody cares |
| 13:44.23 | radix | hmm, by exarkun's argument, it seems he thinks it's ok for Storm to not work |
| 13:44.30 | radix | right? since we actually override __eq__ |
| 13:44.34 | therve | well, yeah |
| 13:44.44 | therve | but it doesn't work in a unfriendly way |
| 13:45.20 | therve | an exception 'your class is not hashable' would help *a bit* |
| 13:45.20 | radix | although that's strange, I thought this was already the case that hash() would blow up if __eq__ was defined |
| 13:45.24 | radix | or is that only __cmp__? |
| 13:45.26 | radix | therve: agreed |
| 13:46.02 | therve | no, I think that until then, it still used the id as hash |
| 13:47.50 | radix | ohhhh |
| 13:47.55 | radix | I'm thinking of old-style classes, apparently |
| 13:48.41 | radix | If you implemented __cmp__ on a classic class with no __hash__, hashing *would* fail |
| 13:48.48 | radix | but not so in new-style classes |
| 13:53.41 | *** join/#storm Zenom (n=aj1973@unaffiliated/aj1973) |
| 15:14.20 | *** join/#storm Zenom (n=aj1973@unaffiliated/aj1973) |
| 16:28.50 | *** join/#storm dobee (n=dobeee@81-223-53-162.dornbirn.xdsl-line.inode.at) |
| 18:34.31 | *** join/#storm jukart (n=jukart@85-124-221-45.static.xdsl-line.inode.at) |
| 20:28.09 | radix | niemeyer: if you ever get a chance, it'd be good if you checked out the strong ref cache branch. I did a review and bernd seemed to disagree with every point I made |
| 20:33.15 | *** join/#storm goschtl (n=goschtl@pD9E5EF4E.dip.t-dialin.net) |
| 20:35.18 | niemeyer | radix: Cool, I'll check it out :-) |
| 20:47.15 | niemeyer | radix: Hmm.. I guess I disagree with most of them as well :-) |
| 20:51.02 | radix | crap :( |
| 20:51.13 | radix | Ok, then I guess I will have to explain them more. |
| 20:51.16 | radix | niemeyer: Can you please post a comment? |
| 20:52.07 | niemeyer | radix: Sure thing |
| 21:20.31 | *** join/#storm niemeyer_ (n=niemeyer@201-14-56-127.ctame705.dsl.brasiltelecom.net.br) |
| 21:59.18 | *** join/#storm weatherman (n=weatherm@204-174-36-245.unknown-dhcp802.dsl.ucc-net.ca) |
| 21:59.18 | weatherman | storm/strongrefcache r203 committed by gustavo@niemeyer.net |
| 21:59.18 | weatherman | Introducing new changes coded with Chris about his review on #172357. |
| 22:05.21 | *** join/#storm bozzo (n=bozzo@BSN-210-221-88.dial-up.dsl.siol.net) |
| 22:34.23 | weatherman | storm/trunk r199 committed by gustavo@niemeyer.net |
| 22:34.23 | weatherman | Merged mysql-reconnection branch [r=jkakar,radix] [f=94986] |
| 22:34.28 | weatherman | This branch introduces the automatic reconnecting support for MySQL. |