| 21:12.51 | *** join/#wowace purl (ibot@rikers.org) |
| 21:12.51 | *** topic/#wowace is http://wowace.com/ | 7.0.x ToC: 70000 | http://wowace.com/paste/ | http://lua.org | This channel is logged, via purl | Check out the beta site at http://beta.wowace.com |
| 21:13.14 | znf | lol |
| 21:13.33 | znf | give legendary belt :( |
| 21:14.24 | Stanzilla | he got the shoulders |
| 21:14.43 | znf | ouch |
| 21:19.48 | znf | Stanzilla, whisper him "You seem a little tense..." |
| 21:20.12 | Gnarfoz | anyone know what the args to the combatlog event CHALLENGE_MODE_END are? I have InstanceMapID, ?, Mythic+ level, completion time in ms |
| 21:20.35 | Stanzilla | znf: already did that :D |
| 21:21.25 | znf | Stanzilla, what trinket did he want, anyway? |
| 21:22.02 | *** join/#wowace Freddan962_ (~Freddan96@m176-71-211-211.cust.tele2.se) |
| 21:22.43 | nevcairiel | Gnarfoz: mapId, success, medla, completionTime, interpretation is up to you =p |
| 21:22.49 | nevcairiel | medal* |
| 21:23.05 | Gnarfoz | ah, success makes sense |
| 21:23.49 | Gnarfoz | have to manually fix my combatlog, since LoggerHead only asks "hey, new zone, wanna turn on logging now and in the future?" after CHALLENGE_MODE_START has already fired >_> |
| 21:24.17 | nevcairiel | LHL seems to be fine |
| 21:24.56 | Stanzilla | znf spider bossi n arcway |
| 21:25.03 | znf | ah |
| 21:25.26 | znf | waut |
| 21:25.30 | znf | what trinket?! |
| 21:25.42 | Gnarfoz | nevcairiel: nope, was actually talking about LHL |
| 21:25.52 | znf | the last boss has a haste trinket |
| 21:26.04 | nevcairiel | was fine for me, popup appeared after loading screen |
| 21:26.08 | Gnarfoz | yep |
| 21:26.12 | nevcairiel | while the countdown is going on |
| 21:26.17 | Gnarfoz | doesn't catch CHALLENGE_MODE_START, though |
| 21:26.27 | Stanzilla | I think he meant relic |
| 21:26.28 | Gnarfoz | I doubt I took 10 seconds to click that popup 3 times in a row :C |
| 21:26.43 | nevcairiel | its an event, w hy would it catch it |
| 21:26.49 | nevcairiel | its not a combatlog event |
| 21:26.50 | Gnarfoz | hm? |
| 21:26.51 | Gnarfoz | no |
| 21:27.00 | Gnarfoz | I meant, the logging only started after that already happened |
| 21:27.04 | Gnarfoz | so it ends up not being in the file |
| 21:27.13 | nevcairiel | ? that wouldnt get into the log anyway |
| 21:27.17 | Gnarfoz | of course |
| 21:27.17 | nevcairiel | its not a combatlog event |
| 21:27.18 | Gnarfoz | it's in there |
| 21:27.30 | Gnarfoz | 9/25 19:52:41.823 CHALLENGE_MODE_END,1456,1,4,1721198 |
| 21:27.49 | Gnarfoz | 9/25 19:23:57.406 CHALLENGE_MODE_START,1456,4,[5] |
| 21:27.52 | nevcairiel | guess they log non-CLEU stuff as well then |
| 21:27.53 | Gnarfoz | (excuse the wrong order :P) |
| 21:28.10 | Gnarfoz | definitely, the combat log file has more info than CLEU shows in game |
| 21:28.19 | nevcairiel | but its not something loggerhead alike addons can do for you then, unless they manually get some hackery to catch ujsing the orb or some shit |
| 21:28.37 | Gnarfoz | true, I solved it by editing my SVs |
| 21:32.01 | Gnarfoz | bleeeh |
| 21:32.09 | Gnarfoz | hunter pets don't contribute to GBoM damage |
| 21:32.14 | Gnarfoz | that sucks :D |
| 21:32.26 | Gnarfoz | got a BM hunter in my M+ team |
| 21:32.44 | nevcairiel | wtf is GBoM |
| 21:32.53 | Stanzilla | greater blessing of mongrel |
| 21:33.01 | Gnarfoz | the weirdest mechanic Blizzard has come up with for Paladins, yet |
| 21:33.07 | *** join/#wowace Seerah (~RyanNL@104-180-66-29.lightspeed.mmphtn.sbcglobal.net) |
| 21:33.31 | Gnarfoz | Greater Blessing of Might; I give it to you, it procs on you, doing some extra damage which gets attributed to me |
| 21:34.06 | Gnarfoz | https://www.warcraftlogs.com/reports/2tFbZ7CfVvB3gDyY#fight=18&type=damage-done&source=3 hover over it here |
| 21:34.19 | Gnarfoz | (hunter was MM there, so it looks like it should) |
| 21:34.40 | Gnarfoz | had it on not one but two BM hunters on Nythendra, though ;D |
| 21:35.03 | nevcairiel | cant you just use another player then :p |
| 21:35.06 | Gnarfoz | (also, I died, but that's besides the point) |
| 21:35.13 | Gnarfoz | in raids, sure |
| 21:35.23 | nevcairiel | there is also another dpser in M+ |
| 21:35.24 | nevcairiel | :D |
| 21:35.28 | Gnarfoz | I can buff it 3 times |
| 21:35.34 | Gnarfoz | (left that bit out) |
| 21:35.44 | nevcairiel | is that a talent or something? |
| 21:35.50 | nevcairiel | arent they once usually |
| 21:35.51 | Gnarfoz | no, just ret-only |
| 21:36.05 | Gnarfoz | I can give out 3 greater blessings, any of the 3 I have |
| 21:36.15 | Gnarfoz | (GBoK and GBoW are super trash, though) |
| 21:36.16 | nevcairiel | oh, i thought it has to be one of every |
| 21:36.30 | Gnarfoz | many paladins I encounter think that, too |
| 21:36.48 | Gnarfoz | anyway, I'll end up giving it to the tank, the non-hunter dps and myself, I guess |
| 21:36.55 | Gnarfoz | not ideal, but what are you gonna do ^^ |
| 21:37.07 | nevcairiel | if it doesnt work properly on BM hunters, then sure |
| 21:37.17 | nevcairiel | not like tanks are low on damage or hits or whatever it needs |
| 21:44.04 | Gnarfoz | 10% chance on attack to do 30% bonus damage as holy |
| 21:44.26 | Gnarfoz | not sure what that actually means in regards to "who best to buff" |
| 21:44.36 | Gnarfoz | I went with "top dps on last boss" during our first raid ;p |
| 21:44.51 | nevcairiel | if it uses some of the more modern proc tech it should be about equal |
| 21:45.00 | nevcairiel | if its just flat chance on hit, melees preferably, i guess |
| 21:45.52 | znf | what's the proc base? |
| 21:45.58 | znf | erm |
| 21:45.59 | znf | I mean |
| 21:46.02 | znf | how does it work for dots? |
| 21:47.01 | znf | I ask because last raid I did, the paladin had it on me for some reasons |
| 21:47.35 | znf | A: All of it will be able to proc Blessing of Might. It applies to literally any damage that you deal, except itself. Itâs a 3% average increase to damage done, should be no exceptions. |
| 21:47.37 | znf | oh |
| 21:48.03 | znf | A: ALL damage that comes from the buffed player (not pets/guardians), except for itself. Yes, DoT ticks. Yes, trinket damage. |
| 21:49.11 | nevcairiel | souinds like it uses smart proc tech |
| 21:49.53 | Gnarfoz | "not pets" sounds not so smart |
| 21:49.57 | Gnarfoz | znf: source link plx? |
| 21:50.16 | nevcairiel | well pets are a different unit, so that makes sense |
| 21:50.24 | znf | see this comment: http://www.wowhead.com/spell=203528/greater-blessing-of-might#comments:id=2328771 |
| 21:50.32 | Gnarfoz | they make it work in other situations, so it's not impossible ^^ |
| 21:51.05 | Gnarfoz | also I heard that it does indeed proc off itself, or rather, off other Paladin's copies. i.e. if 3 rets all buff one player |
| 21:51.10 | Gnarfoz | but that might be unintended |
| 21:51.20 | Gnarfoz | I'm the only one, though, so I don't get to try it out. :D |
| 21:51.29 | Gnarfoz | (guess I could pug something, or do LFR some day) |
| 21:52.00 | znf | Although there are very few incidents in which this is relevant, it is worth noting that procs from this buff trigger Atonement. Of course, it is healing for a percentage of the extra damage, but it is extra damage (and thus, healing) nonetheless. |
| 21:52.00 | znf | ha |
| 21:53.10 | znf | hey Gnarfoz - I made an attempt on reverse-searing just with my oven: https://goo.gl/photos/3Bc4g1cEtctL1bor5 |
| 21:53.13 | znf | (and it's grill setting) |
| 21:53.31 | Gnarfoz | I have no idea what that is |
| 21:53.49 | Gnarfoz | but it looks tasty |
| 21:53.51 | znf | also, a hint: if you use baking paper, DO NOT LEAVE THE BAKING PAPER IN WHEN YOU TURN ON THE GRILL SETTING ON THE OVEN |
| 21:54.11 | Gnarfoz | isn't baking paper intended to be used for baking temperatures? :p |
| 21:54.16 | znf | because you can imagine how my house smells after this: https://usercontent.irccloud-cdn.com/file/6bws63cC/20160926_002833_HDR.jpg |
| 21:54.44 | znf | well, yeah, it is. Baking paper holds up to 250°C |
| 21:54.48 | znf | didn't connect the dots :D |
| 21:56.31 | Gnarfoz | that depends on your baking paper, I guess... but my oven doesn't even go higher than that ^^ |
| 21:57.15 | znf | my oven doesn't go higher, either |
| 21:57.21 | znf | but the grill setting does |
| 21:59.55 | Gnarfoz | hehe |
| 22:00.46 | znf | that reminds me, I need to do the self-cleaning procedure these days |
| 22:03.35 | Repo | loggerheadlite: 03gnarfoz * r14 Config.lua: Support dungeons in the options pane, too |
| 22:03.41 | Gnarfoz | there, OCD satisified |
| 22:04.27 | Gnarfoz | no more endless list of mapIDs under "unknown" |
| 22:15.20 | Stanzilla | semlar |
| 22:15.55 | Stanzilla | any eta on new nomi addon |
| 22:16.02 | Stanzilla | current version makes an addon error |
| 22:16.08 | Stanzilla | which is weird |
| 22:21.58 | Repo | ldb-artifact: 03Znuff 04v1.4 * a57d612 /: [new tag] tagging as v1.4 |
| 22:22.09 | znf | I really need to be reminded to tag shit after I commit |
| 22:22.44 | znf | ...why did I randomly got this while AFK? http://i.imgur.com/qAwxOzG.png |
| 22:22.56 | Gnarfoz | nebula: I only now saw that the addon description of LHL says "only cares about raid zones", but since it already supported dungeons by way of the popup anyway, I assumed fixing the options window would be ok ^^ |
| 22:24.55 | Gnarfoz | enough addon things done for today, I should get back to these world quests. |
| 22:25.03 | znf | I need to do the pvp ones |
| 22:26.23 | znf | You used to scrawl me in your fel tome \o/ |
| 22:48.30 | Semlar | Stanzilla: what error |
| 22:48.45 | Semlar | there shouldn't be any errors |
| 22:48.57 | Stanzilla | Semlar: a "table index is nil" one in a different addon than your |
| 22:48.58 | Stanzilla | s |
| 22:49.23 | znf | Why is it 'nil'? |
| 22:49.25 | znf | and not null? |
| 22:50.04 | Gnarfoz | because that's how Lua rolls |
| 22:50.08 | Semlar | what |
| 22:50.33 | Semlar | what addon |
| 22:50.37 | znf | yours |
| 22:50.37 | Stanzilla | professiontabs |
| 22:51.57 | Semlar | sounds like it's probably inappropriately reacting to TRADE_SKILL_SHOW and assuming the tradeskill window is going to be open |
| 22:52.40 | Semlar | what's the actual error |
| 22:52.48 | Semlar | the full line number and everything |
| 22:54.09 | Semlar | it looks like it's assuming TradeSkillFrame will always exist without checking whether the tradeskill ui has been loaded, since it's a load on demand addon |
| 22:54.23 | Semlar | that's something they need to fix |
| 23:00.05 | Semlar | i mean the only way i could fix that is unregistering the event from every frame in the interface |
| 23:01.11 | Stanzilla | http://paste2.org/y0Nm6ULn |
| 23:01.58 | Stanzilla | I can just add tradeskill ui to deps |
| 23:02.04 | Stanzilla | the addon is not maintained anyway |
| 23:02.36 | EthanCentaurai | would LoadWith work? |
| 23:02.39 | Stanzilla | yes |
| 23:04.26 | Semlar | i believe the error is from this line local owner = ATSWFrame or MRTSkillFrame or SkilletFrame or TradeSkillFrame resulting in nil, then attempting to look that up in a table |
| 23:04.47 | Semlar | it's assuming one of those exists on TRADE_SKILL_SHOW, which isn't guaranteed |
| 23:05.49 | Semlar | since my addon is unregistering the TRADE_SKILL_SHOW event from UIParent when it requests your tradeskill information, it doesn't load the tradeskill ui |
| 23:06.23 | Semlar | if i don't unregister the event, it will open the tradeskill window every time it looks up your recipes |
| 23:06.40 | Stanzilla | still, LoadWith should fix it |
| 23:06.44 | Semlar | i could force the tradeskill ui to load with my addon |
| 23:06.44 | Stanzilla | or not? |
| 23:06.47 | Semlar | but i don't do anything with it |
| 23:07.16 | Semlar | it should work to add it as a dependency |
| 23:07.27 | Stanzilla | I did both |
| 23:08.08 | Semlar | you could also just return if object doesn't exist in the HandleTabs function |
| 23:08.31 | Semlar | or maybe if owner doesn't exist in the TRADE_SKILL_SHOW function |
| 23:08.50 | Semlar | if not owner then return end |
| 23:09.41 | Stanzilla | yea |
| 23:10.30 | Semlar | i might end up unregistering the event from frames anyway, because i don't really want anything reacting to me "opening" the tradeskill to look up information |
| 23:10.41 | Semlar | it's similar to the WORLD_MAP_UPDATE problem |
| 23:26.55 | Repo | ark-inventory: 03arkayenro * r601 (19 files in 2 directories): (4 lines trimmed from commit message) |
| 23:26.55 | Repo | *3.07.12 (xx-SEP-2016)* |
| 23:26.55 | Repo | <PROTECTED> |
| 23:26.55 | Repo | <PROTECTED> |
| 23:26.55 | Repo | <PROTECTED> |
| 23:28.49 | Repo | ark-inventory: 03arkayenro 043.07.12 * r602 : Tagging as 3.07.12 |
| 23:47.51 | Repo | ark-inventory: 03arkayenro * r603 (2 files in 1 directory): *3.07.13 (26-SEP-2016)* |
| 23:47.52 | Repo | <PROTECTED> |
| 23:51.17 | Repo | ark-inventory: 03arkayenro 043.07.13 * r604 : Tagging as 3.07.13 |
